Skip to contentSkip to conversation

iio: stmpe-adc: avoid harmless clang warning

PATCH In review Arnd Bergmann 2 participants 3 messages Mar 22, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: stmpe-adc: avoid harmless clang warning

Clang points out a control flow bug, which happens to be harmless:

drivers/iio/adc/stmpe-adc.c:204:13: error: variable 'data' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

The warning is sensible here, so let's just avoid the case by adding appropriate error handling.

---
 drivers/iio/adc/stmpe-adc.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/adc/stmpe-adc.c +2 -0
index 37f4b74a5d32..ed3817c5c896 100644
@@ -205,6 +205,8 @@ static irqreturn_t stmpe_adc_isr(int irq, void *dev_id)
 		/* Read value */
 		stmpe_block_read(info->stmpe, STMPE_REG_TEMP_DATA, 2,
 				(u8 *) &data);
+	} else {
+		return IRQ_NONE;
 	}
 
 	info->value = (u32) be16_to_cpu(data);
Signature · 7 lines
2.20.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 28 lines · Arnd Bergmann

Clang points out a control flow bug, which happens to be harmless:

drivers/iio/adc/stmpe-adc.c:204:13: error: variable 'data' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

The warning is sensible here, so let's just avoid the case by adding appropriate error handling.

---
 drivers/iio/adc/stmpe-adc.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/adc/stmpe-adc.c +2 -0
index 37f4b74a5d32..ed3817c5c896 100644
@@ -205,6 +205,8 @@ static irqreturn_t stmpe_adc_isr(int irq, void *dev_id)
 		/* Read value */
 		stmpe_block_read(info->stmpe, STMPE_REG_TEMP_DATA, 2,
 				(u8 *) &data);
+	} else {
+		return IRQ_NONE;
 	}
 
 	info->value = (u32) be16_to_cpu(data);
Signature · 1 line
2.20.0

I sent a similar patch, which is sitting in Jonathan's testing branch:

https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?id=e15146e4d4349b3f309f5591ea8de8d24071265f

Nathan

#2 lore raw
Quoted 26 lines · Nathan Chancellor
Quoted 24 lines · Arnd Bergmann

Clang points out a control flow bug, which happens to be harmless:

drivers/iio/adc/stmpe-adc.c:204:13: error: variable 'data' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

The warning is sensible here, so let's just avoid the case by adding appropriate error handling.

---
 drivers/iio/adc/stmpe-adc.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/adc/stmpe-adc.c +2 -0
index 37f4b74a5d32..ed3817c5c896 100644
@@ -205,6 +205,8 @@ static irqreturn_t stmpe_adc_isr(int irq, void *dev_id)
              /* Read value */
              stmpe_block_read(info->stmpe, STMPE_REG_TEMP_DATA, 2,
                              (u8 *) &data);
+     } else {
+             return IRQ_NONE;
      }
 
Quoted 8 lines
Quoted 4 lines
drivers/iio/adc/stmpe-adc.c +0 -1
      info->value = (u32) be16_to_cpu(data);
--

2.20.0

I sent a similar patch, which is sitting in Jonathan's testing branch:

https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?id=e15146e4d4349b3f309f5591ea8de8d24071265f

Ok, sorry for the dup. Your seems to be better than mine, too.

Arnd