Skip to contentSkip to conversation

tracing: initialize variable in create_dyn_event()

PATCH Applied [email protected] 3 participants 3 messages Mar 22, 2019 – Mar 23, 2019 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tracing: initialize variable in create_dyn_event()

From: Frank Rowand <[email protected]>

Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized in this function [-Wuninitialized].

Fixes 5448d44c3855 ("tracing: Add unified dynamic event framework")

---

changes since v1:
- initialize to -ENODEV instead of 0, as suggested by Steve

 kernel/trace/trace_dynevent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_dynevent.c +1 -1
index dd1f43588d70..fa100ed3b4de 100644
@@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
 static int create_dyn_event(int argc, char **argv)
 {
 	struct dyn_event_operations *ops;
-	int ret;
+	int ret = -ENODEV;
 
 	if (argv[0][0] == '-' || argv[0][0] == '!')
 		return dyn_event_release(argc, argv, NULL);
Signature · 1 line
Frank Rowand <[email protected]>
maintainer Applied
#1 lore raw
Quoted 8 lines · On Thu, 21 Mar 2019 23:58:20 -0700 [email protected] wrote:

From: Frank Rowand <[email protected]>

Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized in this function [-Wuninitialized].

Fixes 5448d44c3855 ("tracing: Add unified dynamic event framework")

Applied. Thanks Frank!

-- Steve

Quoted 21 lines

---

changes since v1:
- initialize to -ENODEV instead of 0, as suggested by Steve

 kernel/trace/trace_dynevent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_dynevent.c +1 -1
index dd1f43588d70..fa100ed3b4de 100644
@@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
 static int create_dyn_event(int argc, char **argv)
 {
 	struct dyn_event_operations *ops;
-	int ret;
+	int ret = -ENODEV;
 
 	if (argv[0][0] == '-' || argv[0][0] == '!')
 		return dyn_event_release(argc, argv, NULL);
maintainer Acked-by
#2 lore raw
Quoted 5 lines · On Fri, 22 Mar 2019 15:20:00 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 2 lines · On Thu, 21 Mar 2019 23:58:20 -0700 [email protected] wrote:

From: Frank Rowand <[email protected]>

Quoted 8 lines
Quoted 6 lines

Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized in this function [-Wuninitialized].

Fixes 5448d44c3855 ("tracing: Add unified dynamic event framework")

Applied. Thanks Frank!

Thank you Frank and Steve,

feel free to add my ack.

Thanks!

Quoted 25 lines

-- Steve

Quoted 21 lines

---

changes since v1:
- initialize to -ENODEV instead of 0, as suggested by Steve

 kernel/trace/trace_dynevent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_dynevent.c +1 -1
index dd1f43588d70..fa100ed3b4de 100644
@@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
 static int create_dyn_event(int argc, char **argv)
 {
 	struct dyn_event_operations *ops;
-	int ret;
+	int ret = -ENODEV;
 
 	if (argv[0][0] == '-' || argv[0][0] == '!')
 		return dyn_event_release(argc, argv, NULL);
Signature · 1 line
Masami Hiramatsu <[email protected]>