iommu: Don't print warning when IOMMU driver only supports unmanaged domains
Joerg Roedel
maintainerPATCH 1/1 iommu: Don't print warning when IOMMU driver only supports unmanaged domains
From: Joerg Roedel <[email protected]>
Print the warning about the fall-back to IOMMU_DOMAIN_DMA in iommu_group_get_for_dev() only when such a domain was actually allocated.
Otherwise the user will get misleading warnings in the kernel log when the iommu driver used doesn't support IOMMU_DOMAIN_DMA and IOMMU_DOMAIN_IDENTITY.
Fixes fccb4e3b8ab09 ('iommu: Allow default domain type to be set on the kernel command line')
Signed-off-by Joerg Roedel <[email protected]>
--- drivers/iommu/iommu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/iommu/iommu.c +5 -3
@@ -1105,10 +1105,12 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev) dom =__iommu_domain_alloc (dev->bus, iommu_def_domain_type);if (!dom && iommu_def_domain_type !=IOMMU_DOMAIN_DMA ) { -dev_warn (dev, -"failed to allocate default IOMMU domain of type %u; falling back to IOMMU_DOMAIN_DMA" , - iommu_def_domain_type); dom =__iommu_domain_alloc (dev->bus,IOMMU_DOMAIN_DMA ); +if (dom) { +dev_warn (dev, +"failed to allocate default IOMMU domain of type %u; falling back to IOMMU_DOMAIN_DMA" , + iommu_def_domain_type); + } } group->default_domain = dom;
Signature · 1 line
2.16.4
Joerg Roedel
AppliedQuoted 10 lines · Joerg Roedel
From: Joerg Roedel <[email protected]>
Print the warning about the fall-back to
IOMMU_DOMAIN_DMAiniommu_group_get_for_dev()only when such a domain was actually allocated.Otherwise the user will get misleading warnings in the kernel log when the iommu driver used doesn't support
IOMMU_DOMAIN_DMAandIOMMU_DOMAIN_IDENTITY.
Quoted 5 lines
Fixes fccb4e3b8ab09 ('iommu: Allow default domain type to be set on the kernel command line')Signed-off-by Joerg Roedel <[email protected]>--- drivers/iommu/iommu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
Applied.