Skip to contentSkip to conversation

target/arm: default config

PATCH Applied Andrew Jones 4 participants 5 messages Mar 22, 2019 – Mar 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/arm: default config

In the kconfig shuffle arm lost pci-testdev which is used by kvm-unit-tests. Let's add it back.

---
 default-configs/arm-softmmu.mak | 1 +
 1 file changed, 1 insertion(+)
default-configs/arm-softmmu.mak +1 -0
index 2a7efc11674a..613d19a06db2 100644
@@ -2,6 +2,7 @@
 
 CONFIG_PCI=y
 CONFIG_PCI_DEVICES=y
+CONFIG_PCI_TESTDEV=y
 CONFIG_VGA=y
 CONFIG_NAND=y
 CONFIG_ECC=y
Signature · 1 line
2.17.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Andrew Jones

In the kconfig shuffle arm lost pci-testdev which is used by kvm-unit-tests. Let's add it back.

... the other architectures use "imply TEST_DEVICES" in the Kconfig files, but since the Kconfig-for-arm patches have not included before the hard-freeze, your patch here is likely the better work-around for 4.0.

#3 lore raw
Quoted 5 lines · Peter Maydell
Quoted 4 lines · Andrew Jones

In the kconfig shuffle arm lost pci-testdev which is used by kvm-unit-tests. Let's add it back.

Quoted 7 lines
Quoted 3 lines
---
 default-configs/arm-softmmu.mak | 1 +

Applied to target-arm.next (with a tweaked subject line), thanks.

Sounds good, and safer than CONFIG_TEST_DEVICES for 4.0 so I'm okay with your call! Thanks,

Paolo

#4 lore raw
In reply to Andrew Jones
Quoted 14 lines · Andrew Jones

In the kconfig shuffle arm lost pci-testdev which is used by kvm-unit-tests. Let's add it back.

---
 default-configs/arm-softmmu.mak | 1 +
 1 file changed, 1 insertion(+)
default-configs/arm-softmmu.mak +0 -0
index 2a7efc11674a..613d19a06db2 100644

default-configs/arm-softmmu.mak line 8

Quoted 7 lines
default-configs/arm-softmmu.mak +1 -0
@@ -2,6 +2,7 @@
 
 CONFIG_PCI=y
 CONFIG_PCI_DEVICES=y
+CONFIG_PCI_TESTDEV=y
 CONFIG_VGA=y
 CONFIG_NAND=y
 CONFIG_ECC=y

Let's add all of CONFIG_TEST_DEVICES instead.

Paolo