Skip to contentSkip to conversation

staging: rtl8723bs: include: Fix a space issue

PATCH Superseded Vatsala Narang 2 participants 5 messages Mar 23, 2019 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: include: Fix a space issue

Replace 'foo * bar' with 'foo *bar' to fix a checkpatch warning

---
 drivers/staging/rtl8723bs/include/rtw_recv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/include/rtw_recv.h +1 -1
index 1f53c1c7b0da..7d54cf211315 100644
@@ -302,7 +302,7 @@ struct recv_buf
 
 	u32 ref_cnt;
 
-	struct adapter * adapter;
+	struct adapter *adapter;
 
 	u8 *pbuf;
 	u8 *pallocated_buf;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 12 lines · Vatsala Narang

Replace 'foo * bar' with 'foo *bar' to fix a checkpatch warning

---
 drivers/staging/rtl8723bs/include/rtw_recv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/include/rtw_recv.h +0 -0
index 1f53c1c7b0da..7d54cf211315 100644

drivers/staging/rtl8723bs/include/rtw_recv.h struct recv_buf · line 308

Quoted 8 lines
drivers/staging/rtl8723bs/include/rtw_recv.h +1 -1
@@ -302,7 +302,7 @@ struct recv_buf
 
 	u32 ref_cnt;
 
-	struct adapter * adapter;
+	struct adapter *adapter;
 
 	u8 *pbuf;
 	u8 *pallocated_buf;

It looks like there are more opportunities for improving this file, by getting rid of the "p"s on these names.

julia

Quoted 10 lines

--
2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190323132716.904-1-vatsalanarang%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
Quoted 16 lines

drivers/staging/rtl8723bs/include/rtw_recv.h struct recv_buf · line 308

Quoted 7 lines
drivers/staging/rtl8723bs/include/rtw_recv.h +1 -1
-        struct adapter * adapter; 
+        struct adapter *adapter; 
 
         u8 *pbuf; 
         u8 *pallocated_buf; 

It looks like there are more opportunities for improving this file, by getting rid of the "p"s on these names.

julia

okay ,can I make this change in v2 of same patch or else should I make it a patchset?

#3 lore raw
Quoted 15 lines · Vatsala Narang
Quoted 1 line
      > -        struct adapter * adapter;
      > +        struct adapter *adapter;
      >
      >          u8 *pbuf;
      >          u8 *pallocated_buf;

      It looks like there are more opportunities for improving this
      file, by
      getting rid of the "p"s on these names.

      julia

      okay ,can I make this change in v2 of same patch or else should
      I make it a patchset?

It's a different issue, so a patch set (which would be v2 because it would contain this patch again) would be better.

julia

Quoted 12 lines

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/245673de-1d54-4183-8b92- 0e95c6fe1596%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.