Skip to contentSkip to conversation

auxdisplay for v5.1-rc2

GIT PULL Merged Miguel Ojeda 3 participants 4 messages Mar 23, 2019 – Mar 24, 2019

lore
Share & tools
lore
#0 lore raw

Hi Linus,

Please pull these fixes and improvements for auxdisplay.

Cheers,
Miguel

The following changes since commit 1c163f4c7b3f621efff9b28a47abb36f7378d783:

Linux 5.0 (2019-03-03 15:21:29 -0800)

are available in the Git repository at:

https://github.com/ojeda/linux.git tags/auxdisplay-for-linus-v5.1-rc2

for you to fetch changes up to cc5d04d840d62d7c75e268c51da7cd0be2ee03c0:

auxdisplay: charlcd: make backlight initial state configurable (2019-03-17 08:48:45 +0100)

----------------------------------------------------------------
A few fixes and improvements for auxdisplay:

- Series to fix a memory leak in hd44780
while introducing charlcd_free().
From Andy Shevchenko

- Series to clean up the Kconfig menus and
a couple of improvements for charlcd.
From Mans Rullgard

----------------------------------------------------------------
Andy Shevchenko (5):
auxdisplay: hd44780: Fix memory leak on ->remove()
auxdisplay: charlcd: Move to_priv() to charlcd namespace
auxdisplay: charlcd: Introduce charlcd_free() helper
auxdisplay: panel: Convert to use charlcd_free()
auxdisplay: hd44780: Convert to use charlcd_free()

Mans Rullgard (3):
auxdisplay: deconfuse configuration
auxdisplay: charlcd: simplify init message display
auxdisplay: charlcd: make backlight initial state configurable

 drivers/auxdisplay/Kconfig   | 38 ++++++++++++++++++++++++++----
 drivers/auxdisplay/Makefile  |  2 +-
 drivers/auxdisplay/charlcd.c | 55 ++++++++++++++++++++++++++++----------------
 drivers/auxdisplay/hd44780.c |  4 +++-
 drivers/auxdisplay/panel.c   |  4 ++--
 include/misc/charlcd.h       |  1 +
 6 files changed, 75 insertions(+), 29 deletions(-)
#2 lore raw
In reply to Miguel Ojeda
Quoted 4 lines · Miguel Ojeda

- Series to clean up the Kconfig menus and
a couple of improvements for charlcd.
From Mans Rullgard

Side note: this is very annoying. As part of the rc release I'm going through things like this, and I notice that the new Kconfig option has absolutely no help text.

That might be acceptable if the choice of options made sense and would be obvious to people, but they aren't obvious. Particularly not when you come from not having an option at all, it's not at all clear that what _used_ to happen was that "flash" option.

And yes, the Kconfig source code makes it look like there are help texts. But a help text on the individual options for a choice isn't actually shown when you ask for help - it's the help text for the *choice* that matters. Not that those invisible help texts actually _help_ anything anyway.

Linus

#3 lore raw

Hi Linus,

Quoted 10 lines · Linus Torvalds

Side note: this is very annoying. As part of the rc release I'm going through things like this, and I notice that the new Kconfig option has absolutely no help text.

That might be acceptable if the choice of options made sense and would be obvious to people, but they aren't obvious. Particularly not when you come from not having an option at all, it's not at all clear that what _used_ to happen was that "flash" option.

Quoted 5 lines

And yes, the Kconfig source code makes it look like there are help texts. But a help text on the individual options for a choice isn't actually shown when you ask for help - it's the help text for the *choice* that matters. Not that those invisible help texts actually _help_ anything anyway.

The help on the actual option is a good point; we will add it. Also the Kconfig in general needs a bit of love, I think.

Thanks a lot for taking a look, by the way!

Cheers,
Miguel