Skip to contentSkip to conversation

staging: rtl8723bs: include: Replace 'int16_t' with 's16_t'

PATCH In review Vatsala Narang 2 participants 3 messages Mar 23, 2019 – Mar 24, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: include: Replace 'int16_t' with 's16_t'

Prefer kernel type 's16_t' over 'int16_t' to get rid of checkpatch warning

---
 drivers/staging/rtl8723bs/include/wifi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/include/wifi.h +1 -1
index e729ecd5e9ab..d3deb18d3267 100644
@@ -1142,7 +1142,7 @@ struct rtw_regulatory {
 	u32 tp_scale;
 	u16 current_rd;
 	u16 current_rd_ext;
-	int16_t power_limit;
+	s16_t power_limit;
 	struct regd_pair_mapping *regpair;
 };
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 2 lines · Vatsala Narang

Prefer kernel type 's16_t' over 'int16_t' to get rid of checkpatch warning

What warning? What is "s16_t"? Ick, that's not a "real" kernel type at all.

Quoted 11 lines
---
 drivers/staging/rtl8723bs/include/wifi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/include/wifi.h +0 -0
index e729ecd5e9ab..d3deb18d3267 100644

drivers/staging/rtl8723bs/include/wifi.h struct rtw_regulatory { · line 1145

Quoted 5 lines
drivers/staging/rtl8723bs/include/wifi.h +1 -1
@@ -1142,7 +1142,7 @@ struct rtw_regulatory {
 	u32 tp_scale;
 	u16 current_rd;
 	u16 current_rd_ext;
-	int16_t power_limit;
+	s16_t power_limit;

You might have just changed the type of this variable, are you _sure_ about this?

greg k-h

#2 lore raw
Quoted 7 lines

What warning? What is "s16_t"? Ick, that's not a "real" kernel type at all.

Quoted 8 lines

drivers/staging/rtl8723bs/include/wifi.h struct rtw_regulatory { · line 1145

Quoted 2 lines
drivers/staging/rtl8723bs/include/wifi.h +1 -1
-        int16_t power_limit; 
+        s16_t power_limit; 

You might have just changed the type of this variable, are you _sure_ about this?

greg k-h

I replaced int16_t with s16_t as it was there in checkpatch warning
sorry if its not a "real" kernel type
thanks,
Vatsala