iio: gyro: bmg160 add device tree support
Subsystems (2)
cover iio: gyro: bmg160 add device tree support
There is no device tree support since the of_device_id table is missing.
H. Nikolaus Schaller (2):
iio: gyro: bmg160: add device tree compatibility table
dt-bindings: iio: add Bosch BMG160 gyroscope sensor
.../bindings/iio/gyroscope/bmg160.txt | 20 +++++++++++++++++++ drivers/iio/gyro/bmg160_i2c.c | 9 +++++++++ 2 files changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/bmg160.txt
Signature · 1 line
2.19.1
PATCH 1/2 iio: gyro: bmg160: add device tree compatibility table
Add of_match_table.
--- drivers/iio/gyro/bmg160_i2c.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/iio/gyro/bmg160_i2c.c +9 -0
@@ -54,10 +54,19 @@ static const struct i2c_device_id bmg160_i2c_id[] = {MODULE_DEVICE_TABLE (i2c, bmg160_i2c_id); +static const struct of_device_id bmg160_of_match[] = { + { .compatible ="bosch,bmg160" }, + { .compatible ="bosch,bmi055_gyro" }, + { } +}; + +MODULE_DEVICE_TABLE (of, bmg160_of_match); +static struct i2c_driver bmg160_i2c_driver = { .driver = { .name ="bmg160_i2c" , .acpi_match_table =ACPI_PTR (bmg160_acpi_match), + .of_match_table = bmg160_of_match, .pm = &bmg160_pm_ops, }, .probe = bmg160_i2c_probe,
Signature · 1 line
2.19.1
Jonathan Cameron
maintainerRe: [PATCH 1/2] iio: gyro: bmg160: add device tree compatibility table
Quoted 3 lines · On Mon, 18 Mar 2019 16:14:14 +0100 "H. Nikolaus Schaller" <[email protected]>…
Add
of_match_table.Signed-off-by H. Nikolaus Schaller <[email protected]>
I'm not against doing this, but do note that there is still a back up path in which the i2c_device_id table is used to match but without the vendor part of the string.
I theory the plan is to eventually remove that, but it's not the case that this driver could not be probed from devicetree previously.
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
Quoted 28 lines
--- drivers/iio/gyro/bmg160_i2c.c | 9 +++++++++ 1 file changed, 9 insertions(+)drivers/iio/gyro/bmg160_i2c.c +9
-0@@ -54,10 +54,19 @@ static const struct i2c_device_id bmg160_i2c_id[] = {MODULE_DEVICE_TABLE (i2c, bmg160_i2c_id); +static const struct of_device_id bmg160_of_match[] = { + { .compatible ="bosch,bmg160" }, + { .compatible ="bosch,bmi055_gyro" }, + { } +}; + +MODULE_DEVICE_TABLE (of, bmg160_of_match); +static struct i2c_driver bmg160_i2c_driver = { .driver = { .name ="bmg160_i2c" , .acpi_match_table =ACPI_PTR (bmg160_acpi_match), + .of_match_table = bmg160_of_match, .pm = &bmg160_pm_ops, }, .probe = bmg160_i2c_probe,
Re: [PATCH 1/2] iio: gyro: bmg160: add device tree compatibility table
Hi Jonathan,
Quoted 12 lines
Am 24.03.2019 um 19:05 schrieb Jonathan Cameron <[email protected]>:
Quoted 3 lines · On Mon, 18 Mar 2019 16:14:14 +0100 "H. Nikolaus Schaller" <[email protected]>…
Add
of_match_table.Signed-off-by H. Nikolaus Schaller <[email protected]>I'm not against doing this, but do note that there is still a back up path in which the
i2c_device_idtable is used to match but without the vendor part of the string.
Quoted 5 lines
I theory the plan is to eventually remove that, but it's not the case that this driver could not be probed from devicetree previously.
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.
Thanks,
Nikolaus
Quoted 34 lines
Thanks,
Jonathan
Quoted 28 lines
---
drivers/iio/gyro/bmg160_i2c.c| 9 +++++++++1 file changed, 9 insertions(+)drivers/iio/gyro/bmg160_i2c.c +9
-0@@ -54,10 +54,19 @@ static const struct i2c_device_id bmg160_i2c_id[] = {MODULE_DEVICE_TABLE (i2c, bmg160_i2c_id); +static const struct of_device_id bmg160_of_match[] = { + { .compatible ="bosch,bmg160" }, + { .compatible ="bosch,bmi055_gyro" }, + { } +}; + +MODULE_DEVICE_TABLE (of, bmg160_of_match); +static struct i2c_driver bmg160_i2c_driver = { .driver = { .name ="bmg160_i2c" , .acpi_match_table =ACPI_PTR (bmg160_acpi_match), + .of_match_table = bmg160_of_match, .pm = &bmg160_pm_ops, }, .probe = bmg160_i2c_probe,
PATCH 2/2 dt-bindings: iio: add Bosch BMG160 gyroscope sensor
In reply to H. Nikolaus SchallerDefine bindings for "bosch,bmg160" and "bosch,bmi055_gyro".
--- .../bindings/iio/gyroscope/bmg160.txt | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/bmg160.txt
Documentation/devicetree/bindings/iio/gyroscope/bmg160.txt new file +20 -0
@@ -0,0 +1,20 @@ +* Bosch BMG160 triaxial rotation sensor (gyroscope) + +Required properties: + + - compatible : should be "bosch,bmg160" or "bosch,bmi055_gyro" + - reg : the I2C address of the sensor (0x69) + +Optional properties: + + - interrupts : interrupt mapping for GPIO IRQ, it should by configured with + flags IRQ_TYPE_EDGE_RISING + +Example: + +bmg160@69 { + compatible = "bosch,bmg160"; + reg = <0x69>; + interrupt-parent = <&gpio6>; + interrupts = <18 (IRQ_TYPE_EDGE_RISING)>; +};
Signature · 1 line
2.19.1
Jonathan Cameron
maintainerRe: [PATCH 2/2] dt-bindings: iio: add Bosch BMG160 gyroscope sensor
Quoted 3 lines · On Mon, 18 Mar 2019 16:14:15 +0100 "H. Nikolaus Schaller" <[email protected]>…
Define bindings for "bosch,bmg160" and "bosch,bmi055_gyro".
Signed-off-by H. Nikolaus Schaller <[email protected]>
Simple binding so applied to the togreg branch of iio.git and pushed out as testing. Still time for a devicetree ack (or to pull it ;) if anyone has time to look.
Thanks,
Jonathan
Quoted 31 lines
--- .../bindings/iio/gyroscope/bmg160.txt | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/bmg160.txtDocumentation/devicetree/bindings/iio/gyroscope/bmg160.txt new file +20
-0@@ -0,0 +1,20 @@ +* Bosch BMG160 triaxial rotation sensor (gyroscope) + +Required properties: + + - compatible : should be "bosch,bmg160" or "bosch,bmi055_gyro" + - reg : the I2C address of the sensor (0x69) + +Optional properties: + + - interrupts : interrupt mapping for GPIO IRQ, it should by configured with + flags IRQ_TYPE_EDGE_RISING + +Example: + +bmg160@69 { + compatible = "bosch,bmg160"; + reg = <0x69>; + interrupt-parent = <&gpio6>; + interrupts = <18 (IRQ_TYPE_EDGE_RISING)>; +};
Re: [PATCH 2/2] dt-bindings: iio: add Bosch BMG160 gyroscope sensor
Quoted 6 lines
Am 24.03.2019 um 19:06 schrieb Jonathan Cameron <[email protected]>:
On Mon, 18 Mar 2019 16:14:15 +0100
"H. Nikolaus Schaller" <[email protected]> wrote:
Quoted 6 lines
Quoted 3 lines
Define bindings for "bosch,bmg160" and "bosch,bmi055_gyro".
Signed-off-by H. Nikolaus Schaller <[email protected]>Simple binding so applied to the togreg branch of iio.git and pushed out as testing. Still time for a devicetree ack (or to pull it ;) if anyone has time to look.
It is more or less an adapation of the bma180 bindings.
Quoted 37 lines
Thanks,
Jonathan
Quoted 31 lines
---
.../bindings/iio/gyroscope/bmg160.txt| 20 +++++++++++++++++++1 file changed, 20 insertions(+)create mode 100644
Documentation/devicetree/bindings/iio/gyroscope/bmg160.txtDocumentation/devicetree/bindings/iio/gyroscope/bmg160.txt new file +20
-0@@ -0,0 +1,20 @@ +* Bosch BMG160 triaxial rotation sensor (gyroscope) + +Required properties: + + - compatible : should be "bosch,bmg160" or "bosch,bmi055_gyro" + - reg : the I2C address of the sensor (0x69) + +Optional properties: + + - interrupts : interrupt mapping for GPIO IRQ, it should by configured with + flags IRQ_TYPE_EDGE_RISING + +Example: + +bmg160@69 { + compatible = "bosch,bmg160"; + reg = <0x69>; + interrupt-parent = <&gpio6>; + interrupts = <18 (IRQ_TYPE_EDGE_RISING)>; +};
Re: [PATCH 2/2] dt-bindings: iio: add Bosch BMG160 gyroscope sensor
In reply to H. Nikolaus SchallerQuoted 8 lines · H. Nikolaus Schaller
Define bindings for "bosch,bmg160" and "bosch,bmi055_gyro".
Signed-off-by H. Nikolaus Schaller <[email protected]>--- .../bindings/iio/gyroscope/bmg160.txt | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/bmg160.txt