Skip to contentSkip to conversation

tests/kms_color: Fix CRC mismatch issues with ctm test

PATCH Superseded Uma Shankar 2 participants 2 messages Mar 25, 2019

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 tests/kms_color: Fix CRC mismatch issues with ctm test

Due to Gamma/Degamma limitation with precision (lack of exact 1.0 representation) due to ABI restriction, applying linear gamma affects crc. This patch fixes the same by making ctm tests independant of gamma/degamma.

v2: Disable degamma/gamma programming for ctm max test as it leads to crc mimsmatch. Limiting it to this test case alone as other tests need it to be enabled, hence not touching those scenarios.

v3: Fixed a fumble with compilation.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147

---
 tests/kms_color.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
tests/kms_color.c +14 -2
index decf3c2..dcc86ad 100644
@@ -696,8 +696,15 @@ static bool test_pipe_ctm(data_t *data,
 		igt_assert(fb_modeset_id);
 		igt_plane_set_fb(primary, &fb_modeset);
 
-		set_degamma(data, primary->pipe, degamma_linear);
-		set_gamma(data, primary->pipe, gamma_linear);
+		/*
+		 * Don't program LUT's for max CTM cases as limitation of
+		 * representing 1.0 due to ABI limits causes crc mismatch
+		 */
+		if (memcmp(before, after, sizeof(color_t))) {
+			set_degamma(data, primary->pipe, degamma_linear);
+			set_gamma(data, primary->pipe, gamma_linear);
+		}
+
 		disable_ctm(primary->pipe);
 		igt_display_commit(&data->display);
 
@@ -1005,6 +1012,11 @@ run_tests_for_pipe(data_t *data, enum pipe p)
 		 * produce with an 8 bits per color framebuffer. */
 		igt_require(!IS_CHERRYVIEW(data->devid));
 
+		/* Disable and let default luts be applied by kernel */
+		disable_degamma(primary->pipe);
+		disable_gamma(primary->pipe);
+		igt_display_commit(&data->display);
+
 		igt_assert(test_pipe_ctm(data, primary, red_green_blue,
 					 full_rgb, ctm));
 	}
Signature · 6 lines
1.9.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Fix CRC mismatch issues with ctm test (rev3)

== Series Details ==

== Series Details ==

Series: tests/kms_color: Fix CRC mismatch issues with ctm test (rev3)
URL : https://patchwork.freedesktop.org/series/58412/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5807 -> IGTPW_2697
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2697 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2697, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/58412/revisions/3/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2697:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: PASS -> DMESG-FAIL

Known issues
------------

Here are the changes found in IGTPW_2697 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@userptr:
- fi-whl-u: NOTRUN -> SKIP [fdo#109271] +41

* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-cfl-guc: NOTRUN -> SKIP [fdo#109271] +49

* igt@gem_exec_basic@readonly-bsd1:
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] +57

* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76

* igt@i915_selftest@live_execlists:
- fi-apl-guc: NOTRUN -> INCOMPLETE [fdo#103927] / [fdo#109720]

* igt@kms_addfb_basic@addfb25-y-tiled-small:
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] +56

* igt@kms_busy@basic-flip-a:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

* igt@kms_busy@basic-flip-c:

    - fi-byt-j1900:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-byt-n2820:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62
- fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] +52

* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> SKIP [fdo#109271] +41

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-whl-u: NOTRUN -> FAIL [fdo#103375] +3

* igt@kms_psr@cursor_plane_move:
- fi-whl-u: NOTRUN -> FAIL [fdo#107383] +3

* igt@kms_psr@primary_mmap_gtt:
- fi-skl-guc: NOTRUN -> SKIP [fdo#109271] +49
- fi-cfl-8109u: NOTRUN -> SKIP [fdo#109271] +37

* igt@kms_psr@primary_page_flip:
- fi-apl-guc: NOTRUN -> SKIP [fdo#109271] +50

* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720]

#### Possible fixes ####

* igt@i915_selftest@live_uncore:
- fi-skl-gvtdvm: DMESG-FAIL [fdo#110210] -> PASS

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210

Participating hosts (25 -> 31)
------------------------------

Additional (11): fi-bsw-n3050 fi-byt-j1900 fi-skl-guc fi-cfl-guc fi-apl-guc fi-snb-2520m fi-whl-u fi-cfl-8109u fi-pnv-d510 fi-byt-n2820 fi-skl-6600u
Missing (5): fi-ilk-m540 fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-icl-u3

Build changes
-------------

* IGT: IGT_4900 -> IGTPW_2697

CI_DRM_5807: c45f897bb33c20c85eb4e3955d5e77fa440a4f95 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2697: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2697/
IGT_4900: 09796413394c5490c4adfc5cded5d4344af6af17 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2697/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev