sunxi: Use clrsetbits_le32 instead of multiple instruction
Subsystems (3)
PATCH v6 3/3 sunxi: Use clrsetbits_le32 instead of multiple instruction
From: Michael Trimarchi <[email protected]>
This will improve code readabilty
Signed-off-by Michael Trimarchi <[email protected]>
Signed-off-by Shyam Saini <[email protected]>
---
Changelogs:
V1->V2: none
V2->V3: Fix use of clrsetbits_le32 and setbits_le32 functions
V3->V4: Rebase to original series's patch 2 and 3
V4->V5: Use correct clear bit function
V5->V6: Use one single function same as clrsetbits_le32 and make
everything logically correct
---
arch/arm/mach-sunxi/dram_sun8i_a33.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)arch/arm/mach-sunxi/dram_sun8i_a33.c +2 -6
@@ -145,12 +145,8 @@ static void auto_set_timing_para(struct dram_para *para) reg_val = (tcksrx <<24 ) | (tcksre <<16 ) | (tckesr <<8 ) | (tcke <<0 );writel (reg_val, &mctl_ctl->dramtmg5);/* Set two rank timing and exit self-refresh timing */ - reg_val =readl (&mctl_ctl->dramtmg8); - reg_val &= ~(0xff <<8 ); - reg_val &= ~(0xff <<0 ); - reg_val |= (0x33 <<8 ); - reg_val |= (0x10 <<0 ); -writel (reg_val, &mctl_ctl->dramtmg8); +clrsetbits_le32 (&mctl_ctl->dramtmg8, (0xff <<8 ) | (0xff <<0 ), + (0x33 <<8 ) | (0x10 <<0 ));/* Set phy interface time */ reg_val = (0x2 <<24 ) | (t_rdata_en <<16 ) | (0x1 <<8 ) | (wr_latency <<0 );
Signature · 1 line
2.11.0
PATCH v6 3/3 sunxi: Use clrsetbits_le32 instead of multiple instruction
Quoted 8 lines · Shyam Saini
From: Michael Trimarchi <[email protected]>
This will improve code readabilty
Signed-off-by Michael Trimarchi <[email protected]>Signed-off-by Shyam Saini <[email protected]>---
Is this patch on master? couldn't apply at all?
PATCH v6 3/3 sunxi: Use clrsetbits_le32 instead of multiple instruction
Hi
Quoted 5 lines · Jagan Teki
Quoted 3 lines · Shyam Saini
From: Michael Trimarchi <[email protected]>
Quoted 7 lines
Quoted 5 lines
This will improve code readabilty
Signed-off-by Michael Trimarchi <[email protected]>Signed-off-by Shyam Saini <[email protected]>---
Is this patch on master? couldn't apply at all?
I think you should apply 1 and 2
Michael
Quoted 4 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Signature · 4 lines
| Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com |