lockdep: avoid bogus clang warning
PATCH 1/1 lockdep: avoid bogus clang warning
When lockdep is enabled, and -Wuninitialized warnings are enabled, clang produces a silly warning for every file we compile:
In file included from kernel/sched/fair.c:23:
kernel/sched/sched.h:1094:15: error: variable 'cookie' is uninitialized when used here [-Werror,-Wuninitialized]
rf->cookie = lockdep_pin_lock(&rq->lock);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/lockdep.h:474:60: note: expanded from macro 'lockdep_pin_lock'
#define lockdep_pin_lock(l) ({ struct pin_cookie cookie; cookie; })
^~~~~~
kernel/sched/sched.h:1094:15: note: variable 'cookie' is declared here
include/linux/lockdep.h:474:34: note: expanded from macro 'lockdep_pin_lock'
#define lockdep_pin_lock(l) ({ struct pin_cookie cookie; cookie; })
^As the 'struct pin_cookie' structure is empty in this configuration, there is no need to initialize it for correctness, but it also does not hurt to set it to an empty structure, so do that to avoid the warning.
--- include/linux/lockdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/lockdep.h +1 -1
@@ -471,7 +471,7 @@ struct pin_cookie { };#define NIL_COOKIE (struct pin_cookie){ } -#define lockdep_pin_lock (l) ({ struct pin_cookie cookie; cookie; }) +#define lockdep_pin_lock (l) ({ struct pin_cookie cookie = {}; cookie; })#define lockdep_repin_lock (l, c) do { (void)(l); (void)(c); } while (0)#define lockdep_unpin_lock (l, c) do { (void)(l); (void)(c); } while (0)
Signature · 1 line
2.20.0
Quoted 7 lines · On Mon, 25 Mar 2019 13:57:57 +0100 Arnd Bergmann <[email protected]> wrote:
When lockdep is enabled, and -Wuninitialized warnings are enabled, clang produces a silly warning for every file we compile:
In file included from
kernel/sched/fair.c:23:
kernel/sched/sched.h:1094:15: error: variable 'cookie' is uninitialized when used here [-Werror,-Wuninitialized]rf->cookie = lockdep_pin_lock(&rq->lock); ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Sad it warns as struct pin_cookie is of size zero. But hey.
Quoted 22 lines
include/linux/lockdep.h:474:60: note: expanded from macro 'lockdep_pin_lock'#define lockdep_pin_lock(l) ({ struct pin_cookie cookie; cookie; }) ^~~~~~ kernel/sched/sched.h:1094:15: note: variable 'cookie' is declared here include/linux/lockdep.h:474:34: note: expanded from macro 'lockdep_pin_lock' #define lockdep_pin_lock(l) ({ struct pin_cookie cookie; cookie; }) ^As the 'struct
pin_cookie' structure is empty in this configuration, there is no need to initialize it for correctness, but it also does not hurt to set it to an empty structure, so do that to avoid the warning.Signed-off-by Arnd Bergmann <[email protected]>--- include/linux/lockdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/lockdep.h +0
-0
include/linux/lockdep.h struct pin_cookie { }; · line 474
Quoted 5 lines
include/linux/lockdep.h +1
-1@@ -471,7 +471,7 @@ struct pin_cookie { };#define NIL_COOKIE (struct pin_cookie){ } -#define lockdep_pin_lock (l) ({ struct pin_cookie cookie; cookie; }) +#define lockdep_pin_lock (l) ({ struct pin_cookie cookie = {}; cookie; })
-- Steve
Quoted 3 lines
include/linux/lockdep.h +0
-0#define lockdep_repin_lock (l, c) do { (void)(l); (void)(c); } while (0)#define lockdep_unpin_lock (l, c) do { (void)(l); (void)(c); } while (0)
Quoted 29 lines · Arnd Bergmann
When lockdep is enabled, and -Wuninitialized warnings are enabled, clang produces a silly warning for every file we compile:
In file included from
kernel/sched/fair.c:23:
kernel/sched/sched.h:1094:15: error: variable 'cookie' is uninitialized when used here [-Werror,-Wuninitialized]rf->cookie = lockdep_pin_lock(&rq->lock); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/lockdep.h:474:60: note: expanded from macro 'lockdep_pin_lock' #define lockdep_pin_lock(l) ({ struct pin_cookie cookie; cookie; }) ^~~~~~ kernel/sched/sched.h:1094:15: note: variable 'cookie' is declared here include/linux/lockdep.h:474:34: note: expanded from macro 'lockdep_pin_lock' #define lockdep_pin_lock(l) ({ struct pin_cookie cookie; cookie; }) ^As the 'struct
pin_cookie' structure is empty in this configuration, there is no need to initialize it for correctness, but it also does not hurt to set it to an empty structure, so do that to avoid the warning.Signed-off-by Arnd Bergmann <[email protected]>--- include/linux/lockdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/lockdep.h +0
-0
include/linux/lockdep.h struct pin_cookie { }; · line 476
Quoted 7 lines
include/linux/lockdep.h +1
-1@@ -471,7 +471,7 @@ struct pin_cookie { };#define NIL_COOKIE (struct pin_cookie){ } -#define lockdep_pin_lock (l) ({ struct pin_cookie cookie; cookie; }) +#define lockdep_pin_lock (l) ({ struct pin_cookie cookie = {}; cookie; })#define lockdep_repin_lock (l, c) do { (void)(l); (void)(c); } while (0)#define lockdep_unpin_lock (l, c) do { (void)(l); (void)(c); } while (0)
Will
tip-bot for Arnd Bergmann
merge bot[tip:locking/core] locking/lockdep: Avoid bogus Clang warning
In reply to Arnd Bergmannlocking/lockdep: Avoid bogus Clang warning
Commit-ID: 3771b0fe9dfc3801eac0142d1af6ba94dee83c6c Gitweb: https://git.kernel.org/tip/3771b0fe9dfc3801eac0142d1af6ba94dee83c6c Author: Arnd Bergmann <[email protected]> AuthorDate: Mon, 25 Mar 2019 13:57:57 +0100 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 18 Apr 2019 14:01:17 +0200
locking/lockdep: Avoid bogus Clang warning
When lockdep is enabled, and -Wuninitialized warnings are enabled, Clang produces a silly warning for every file we compile:
In file included from kernel/sched/fair.c:23:
kernel/sched/sched.h:1094:15: error: variable 'cookie' is uninitialized when used here [-Werror,-Wuninitialized]
rf->cookie = lockdep_pin_lock(&rq->lock);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/lockdep.h:474:60: note: expanded from macro 'lockdep_pin_lock'
#define lockdep_pin_lock(l) ({ struct pin_cookie cookie; cookie; })
^~~~~~
kernel/sched/sched.h:1094:15: note: variable 'cookie' is declared here
include/linux/lockdep.h:474:34: note: expanded from macro 'lockdep_pin_lock'
#define lockdep_pin_lock(l) ({ struct pin_cookie cookie; cookie; })
^As the 'struct pin_cookie' structure is empty in this configuration, there is no need to initialize it for correctness, but it also does not hurt to set it to an empty structure, so do that to avoid the warning.
--- include/linux/lockdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/lockdep.h +1 -1
@@ -471,7 +471,7 @@ struct pin_cookie { };#define NIL_COOKIE (struct pin_cookie){ } -#define lockdep_pin_lock (l) ({ struct pin_cookie cookie; cookie; }) +#define lockdep_pin_lock (l) ({ struct pin_cookie cookie = { }; cookie; })#define lockdep_repin_lock (l, c) do { (void)(l); (void)(c); } while (0)#define lockdep_unpin_lock (l, c) do { (void)(l); (void)(c); } while (0)