rcutorture: Select from only online CPUs
Subsystems (2)
PATCH 1/1 rcutorture: Select from only online CPUs
The rcutorture jitter.sh script selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system.
--- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
tools/testing/selftests/rcutorture/bin/jitter.sh +10 -1
@@ -47,10 +47,19 @@ do exit 0; fi - # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online | sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'` + + for c in $cpus; do + if [ "$(cat /sys/devices/system/cpu/cpu$c/online)" == "1" ]; + then + cpus_tmp="$cpus_tmp $c" + fi + done + cpus=$cpus_tmp + cpumask=`awk -v cpus="$cpus" -v me=$me -v n=$n 'BEGIN { srand(n + me + systime()); ncpus = split(cpus, ca);
Signature · 1 line
2.21.0.392.gf8f6787159e-goog
Quoted 7 lines · Joel Fernandes (Google)
The rcutorture
jitter.shscript selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system.Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>
Good catch!
Please see below for one suggestion for simplification.
Thanx, Paul
Quoted 9 lines
--- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 51
Quoted 6 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +1
-1@@ -47,10 +47,19 @@ do exit 0; fi - # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online |
cpus=`grep 1 /sys/devices/system/cpu/*/online |
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 53
Quoted 2 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'`
Of course, now I have no idea why I excluded CPU 0... :-/
Quoted 15 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +9
-0+ + for c in $cpus; do + if [ "$(cat /sys/devices/system/cpu/cpu$c/online)" == "1" ]; + then + cpus_tmp="$cpus_tmp $c" + fi + done + cpus=$cpus_tmp + cpumask=`awk -v cpus="$cpus" -v me=$me -v n=$n 'BEGIN { srand(n + me + systime()); ncpus = split(cpus, ca);Signature · 1 line
2.21.0.392.gf8f6787159e-goog
Quoted 28 lines · Paul E. McKenney
Quoted 7 lines · Joel Fernandes (Google)
The rcutorture
jitter.shscript selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system.Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Good catch!
Please see below for one suggestion for simplification.
Thanx, Paul
Quoted 12 lines
--- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0@@ -47,10 +47,19 @@ do exit 0; fi
Quoted 6 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 51
Quoted 3 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +1
-1- # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online |cpus=`grep 1
/sys/devices/system/cpu/*/online|
Yes, this is better. Lets do it this way :)
Quoted 4 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 53
Quoted 2 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'`Of course, now I have no idea why I excluded CPU 0... :-/
Yes, I was wondering as well about that :-)
thanks,
- Joel
Quoted 35 lines · Joel Fernandes
Quoted 28 lines · Paul E. McKenney
Quoted 7 lines · Joel Fernandes (Google)
The rcutorture
jitter.shscript selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system.Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Good catch!
Please see below for one suggestion for simplification.
Thanx, Paul
Quoted 12 lines
--- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0@@ -47,10 +47,19 @@ do exit 0; fiQuoted 5 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 51
Quoted 3 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +1
-1- # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online |cpus=`grep 1
/sys/devices/system/cpu/*/online|
Quoted 8 lines
Yes, this is better. Lets do it this way :)
Quoted 4 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 53
Quoted 2 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'`Of course, now I have no idea why I excluded CPU 0... :-/
Yes, I was wondering as well about that :-)
Please feel free to try including CPU 0 and running the set of single-CPU rcutorture scenarios. ;-)
Thanx, Paul
Quoted 41 lines · Paul E. McKenney
Quoted 40 lines · Joel Fernandes
Quoted 28 lines · Paul E. McKenney
Quoted 7 lines · Joel Fernandes (Google)
The rcutorture
jitter.shscript selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system.Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Good catch!
Please see below for one suggestion for simplification.
Thanx, Paul
Quoted 12 lines
--- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0@@ -47,10 +47,19 @@ do exit 0; fiQuoted 5 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 51
Quoted 3 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +1
-1- # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online |cpus=`grep 1
/sys/devices/system/cpu/*/online|Yes, this is better. Lets do it this way :)
Quoted 3 lines
Quoted 2 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'`
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Of course, now I have no idea why I excluded CPU 0... :-/
Yes, I was wondering as well about that :-)
Please feel free to try including CPU 0 and running the set of single-CPU rcutorture scenarios. ;-)
Sounds good, I will test that out on your latest dev branch. Thanks,
- Joel
Quoted 42 lines · Paul E. McKenney
Quoted 40 lines · Joel Fernandes
Quoted 28 lines · Paul E. McKenney
Quoted 7 lines · Joel Fernandes (Google)
The rcutorture
jitter.shscript selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system.Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Good catch!
Please see below for one suggestion for simplification.
Thanx, Paul
Quoted 12 lines
--- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0@@ -47,10 +47,19 @@ do exit 0; fiQuoted 5 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 51
Quoted 3 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +1
-1- # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online |cpus=`grep 1
/sys/devices/system/cpu/*/online|Yes, this is better. Lets do it this way :)
Quoted 3 lines
Quoted 2 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'`
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Of course, now I have no idea why I excluded CPU 0... :-/
Yes, I was wondering as well about that :-)
Please feel free to try including CPU 0 and running the set of single-CPU rcutorture scenarios. ;-)
Will do and then will update the patch by adding the CPU back, if all is well. Thanks.
Quoted 45 lines · Joel Fernandes
Quoted 44 lines · Paul E. McKenney
Quoted 42 lines · Joel Fernandes
Quoted 28 lines · Paul E. McKenney
Quoted 7 lines · Joel Fernandes (Google)
The rcutorture
jitter.shscript selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system.Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Good catch!
Please see below for one suggestion for simplification.
Thanx, Paul
Quoted 12 lines
--- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0@@ -47,10 +47,19 @@ do exit 0; fiQuoted 5 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 51
Quoted 3 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +1
-1- # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online |cpus=`grep 1
/sys/devices/system/cpu/*/online|Yes, this is better. Lets do it this way :)
Quoted 4 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 53
Quoted 2 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'`Of course, now I have no idea why I excluded CPU 0... :-/
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Yes, I was wondering as well about that :-)
Please feel free to try including CPU 0 and running the set of single-CPU rcutorture scenarios. ;-)
Will do and then will update the patch by adding the CPU back, if all is well. Thanks.
And rcutorture doesn't like the rcu_is_cpu_rrupt_from_idle() patch on scenarios SRCU-P, TASKS01, and TREE05, which are the Tree RCU scenarios that enable CONFIG_PROVE_RCU. The compiler error is:
kernel/rcu/tree.c:391:2: error: implicit declaration of function ‘_this_cpu_read’ [-Werror=implicit-function-declaration]
My guess is that the initial underscore needs to go. I will drop these two patches in favor of an update from you. ;-)
Thanx, Paul
Quoted 54 lines · Paul E. McKenney
Quoted 45 lines · Joel Fernandes
Quoted 44 lines · Paul E. McKenney
Quoted 42 lines · Joel Fernandes
Quoted 28 lines · Paul E. McKenney
Quoted 7 lines · Joel Fernandes (Google)
The rcutorture
jitter.shscript selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system.Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Good catch!
Please see below for one suggestion for simplification.
Thanx, Paul
Quoted 12 lines
--- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0@@ -47,10 +47,19 @@ do exit 0; fiQuoted 5 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 51
Quoted 3 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +1
-1- # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online |cpus=`grep 1
/sys/devices/system/cpu/*/online|Yes, this is better. Lets do it this way :)
Quoted 4 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 53
Quoted 2 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'`Of course, now I have no idea why I excluded CPU 0... :-/
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Yes, I was wondering as well about that :-)
Please feel free to try including CPU 0 and running the set of single-CPU rcutorture scenarios. ;-)
Will do and then will update the patch by adding the CPU back, if all is well. Thanks.
Quoted 8 lines
And rcutorture doesn't like the
rcu_is_cpu_rrupt_from_idle()patch on scenarios SRCU-P, TASKS01, and TREE05, which are the Tree RCU scenarios that enableCONFIG_PROVE_RCU. The compiler error is:
kernel/rcu/tree.c:391:2: error: implicit declaration of function ‘_this_cpu_read’ [-Werror=implicit-function-declaration]My guess is that the initial underscore needs to go. I will drop these two patches in favor of an update from you. ;-)
Sorry, I fixed that up and running tests now.
By the way, may be you decided to not run the jitter on CPU0 just because on some systems, CPU0 does not have an 'online' file? In this case, the grep may throw errors I guess which troubles the script.
Quoted 1 line
From the old cpu hotplug docs, I found that if
CONFIG_BOOTPARAM_HOTPLUG_CPU0
or cpu0_hotplug boot command line option is not passed, then cpu0 cannot be offlined in which case, presumably the 'online' file will be missing, like some systems I am testing on.
thanks,
- Joel
Quoted 66 lines · Joel Fernandes
Quoted 54 lines · Paul E. McKenney
Quoted 45 lines · Joel Fernandes
Quoted 44 lines · Paul E. McKenney
Quoted 42 lines · Joel Fernandes
Quoted 28 lines · Paul E. McKenney
Quoted 7 lines · Joel Fernandes (Google)
The rcutorture
jitter.shscript selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system.Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Good catch!
Please see below for one suggestion for simplification.
Thanx, Paul
Quoted 12 lines
--- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0@@ -47,10 +47,19 @@ do exit 0; fiQuoted 5 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 51
Quoted 3 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +1
-1- # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online |cpus=`grep 1
/sys/devices/system/cpu/*/online|Yes, this is better. Lets do it this way :)
Quoted 4 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 53
Quoted 2 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'`Of course, now I have no idea why I excluded CPU 0... :-/
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Yes, I was wondering as well about that :-)
Please feel free to try including CPU 0 and running the set of single-CPU rcutorture scenarios. ;-)
Will do and then will update the patch by adding the CPU back, if all is well. Thanks.
Quoted 8 lines
And rcutorture doesn't like the
rcu_is_cpu_rrupt_from_idle()patch on scenarios SRCU-P, TASKS01, and TREE05, which are the Tree RCU scenarios that enableCONFIG_PROVE_RCU. The compiler error is:
kernel/rcu/tree.c:391:2: error: implicit declaration of function ‘_this_cpu_read’ [-Werror=implicit-function-declaration]My guess is that the initial underscore needs to go. I will drop these two patches in favor of an update from you. ;-)
Sorry, I fixed that up and running tests now.
Quoted 8 lines
By the way, may be you decided to not run the jitter on CPU0 just because on some systems, CPU0 does not have an 'online' file? In this case, the grep may throw errors I guess which troubles the script.
From the old cpu hotplug docs, I found that if
CONFIG_BOOTPARAM_HOTPLUG_CPU0orcpu0_hotplugboot command line option is not passed, then cpu0 cannot be offlined in which case, presumably the 'online' file will be missing, like some systems I am testing on.
Never mind, the "*" in your path search would take care of not erroring out :-)
The other reason you may have done it is for making the jitter be consistent across systems that can offline CPU0, and the others that can't :-). I am just guessing.
Any way, I will just add back CPU0 forcefully to the cpus list in my testing, without checking for the online file existence, and see what happens :-) If there's no smoke, then I'll roll that into a patch and send it out.
thanks.
Quoted 60 lines · Joel Fernandes
Quoted 59 lines · Joel Fernandes
Quoted 58 lines · Paul E. McKenney
Quoted 45 lines · Joel Fernandes
Quoted 44 lines · Paul E. McKenney
Quoted 42 lines · Joel Fernandes
Quoted 28 lines · Paul E. McKenney
Quoted 7 lines · Joel Fernandes (Google)
The rcutorture
jitter.shscript selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system.Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Good catch!
Please see below for one suggestion for simplification.
Thanx, Paul
Quoted 12 lines
--- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0@@ -47,10 +47,19 @@ do exit 0; fiQuoted 5 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 51
Quoted 3 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +1
-1- # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online |cpus=`grep 1
/sys/devices/system/cpu/*/online|Yes, this is better. Lets do it this way :)
Quoted 4 lines
tools/testing/selftests/rcutorture/bin/jitter.sh do · line 53
Quoted 2 lines
tools/testing/selftests/rcutorture/bin/jitter.sh +0
-0sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'`Of course, now I have no idea why I excluded CPU 0... :-/
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Yes, I was wondering as well about that :-)
Please feel free to try including CPU 0 and running the set of single-CPU rcutorture scenarios. ;-)
Will do and then will update the patch by adding the CPU back, if all is well. Thanks.
And rcutorture doesn't like the
rcu_is_cpu_rrupt_from_idle()patch on scenarios SRCU-P, TASKS01, and TREE05, which are the Tree RCU scenarios that enableCONFIG_PROVE_RCU. The compiler error is:
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
kernel/rcu/tree.c:391:2: error: implicit declaration of function ‘_this_cpu_read’ [-Werror=implicit-function-declaration]My guess is that the initial underscore needs to go. I will drop these two patches in favor of an update from you. ;-)
Sorry, I fixed that up and running tests now.
Very good. ;-)
Quoted 9 lines
Quoted 8 lines
By the way, may be you decided to not run the jitter on CPU0 just because on some systems, CPU0 does not have an 'online' file? In this case, the grep may throw errors I guess which troubles the script.
From the old cpu hotplug docs, I found that if
CONFIG_BOOTPARAM_HOTPLUG_CPU0orcpu0_hotplugboot command line option is not passed, then cpu0 cannot be offlined in which case, presumably the 'online' file will be missing, like some systems I am testing on.
Quoted 5 lines
Never mind, the "*" in your path search would take care of not erroring out :-)
The other reason you may have done it is for making the jitter be consistent across systems that can offline CPU0, and the others that can't :-). I am just guessing.
Or maybe I was just being stupid. If I wasn't being stupid, it might have been that in the uniprocessor case the jitter caused some failure. But the kernel is a lot better about handling preemption these days, so that might well be an obsolete concern. Who knows? ;-)
Quoted 3 lines
Any way, I will just add back CPU0 forcefully to the cpus list in my testing, without checking for the online file existence, and see what happens :-) If there's no smoke, then I'll roll that into a patch and send it out.
Sounds good, especially if you include a few of the uniprocessor tests. ;-)
Thanx, Paul
On Tue, Mar 26, 2019@01:46:13PM -0700, Paul E. McKenney wrote:
[snip]
Quoted 5 lines
Quoted 3 lines
Any way, I will just add back CPU0 forcefully to the cpus list in my testing, without checking for the online file existence, and see what happens :-) If there's no smoke, then I'll roll that into a patch and send it out.
Sounds good, especially if you include a few of the uniprocessor tests. ;-)
Yes, I will do those as well. Thanks for the reminder :-). Let us wait on merging until then, then. I will reply back here about the uni processor testing tomorrow.
thanks,
- Joel