Skip to contentSkip to conversation

install pkgconfig files into libdir

PATCH In review Olaf Hering 2 participants 2 messages Mar 25, 2019 – May 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 install pkgconfig files into libdir

Most pkgconfig files contain a Libs: variable, which is either /usr/lib or /usr/lib64. If a 32bit and a 64bit variant of xen libraries is installed, the last one wins. As a result compiling for the other bitsize will fail.

Instead of sharedir use libdir as install target. This matches both the documentation and the expected result.

---

I think this deserves a backport to relesed versions.

 config/Paths.mk.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
config/Paths.mk.in +1 -1
index 8a518d5a5d..dc9d0c0353 100644
@@ -58,4 +58,4 @@ XENFIRMWAREDIR           := @XENFIRMWAREDIR@
 XEN_CONFIG_DIR           := @XEN_CONFIG_DIR@
 XEN_SCRIPT_DIR           := @XEN_SCRIPT_DIR@
 
-PKG_INSTALLDIR           := ${SHAREDIR}/pkgconfig
+PKG_INSTALLDIR           := ${libdir}/pkgconfig

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Olaf Hering

Most pkgconfig files contain a Libs: variable, which is either /usr/lib or /usr/lib64. If a 32bit and a 64bit variant of xen libraries is installed, the last one wins. As a result compiling for the other bitsize will fail.

Instead of sharedir use libdir as install target. This matches both the documentation and the expected result.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel