MLK-12883 usb: limit USB_MAX_XFER_BLK to 256
RFC PATCH 1/1 MLK-12883 usb: limit USB_MAX_XFER_BLK to 256
From: Peng Fan <[email protected]>
For Some USB mass storage devices, such as:
"
- Kingston DataTraveler 2.0 001D7D06CF09B04199C7B3EA
- Class: (from Interface) Mass Storage
- PacketSize: 64 Configurations: 1
- Vendor: 0x0930 Product 0x6545 Version 1.16
"
When usb read 0x80000000 0 0x2000, we met "EHCI timed out on TD - token=0x80008d80".
The devices does not support scsi VPD page, we are not able to get the maximum transfer length for READ(10)/WRITE(10).
So we limit this to 256 blocks as READ(6).
---
This comes from NXP's downstream and has proven to tremendously improve the situation with those odd USB mass storage aka memory sticks. This is why I post it here asking whether or not this may be something benefiting more people. Any feedback and suggestions are welcome.
common/usb_storage.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
common/usb_storage.c +5 -1
@@ -949,7 +949,11 @@ static void usb_stor_set_max_xfer_blk(struct usb_device *udev,* there is enough free heap space left, but the SCSI READ(10) and * WRITE(10) commands are limited to 65535 blocks. */ - blk =USHRT_MAX ; +/* +* Some USB Massstorage devices have issues, limiting this to 256 +* fixes this. +*/ + blk =256 ;#else blk =20 ;#endif
Signature · 1 line
2.20.1
RFC PATCH 1/1 MLK-12883 usb: limit USB_MAX_XFER_BLK to 256
There is a typo in the comment: USB Massstorage
Also regarding refering to a specific commit ("(cherry picked from commit df0052575b2bc9d66ae73584768e1a457ed5d914)" line):
Quoted 3 lines
If you want to refer to a specific commit, don’t just refer to the SHA-1 ID of the commit.
Please also include the oneline summary of the commit, to make it easier for reviewers to know what it is about. Example:
Commite21d2170f36602ae2708("video: remove unnecessaryplatform_set_drvdata()")
[1]: https://www.kernel.org/doc/html/v5.1-rc2/process/submitting-patches.html
Quoted 55 lines · Marcel Ziswiler
From: Peng Fan <[email protected]>
For Some USB mass storage devices, such as:
"
- Kingston DataTraveler 2.0 001D7D06CF09B04199C7B3EA
- Class: (from Interface) Mass Storage
- PacketSize: 64 Configurations: 1
- Vendor:0x0930Product0x6545Version 1.16
"
Whenusb read 0x80000000 0 0x2000, we met "EHCI timed out on TD - token=0x80008d80".The devices does not support scsi VPD page, we are not able to get the maximum transfer length for READ(10)/WRITE(10).
So we limit this to 256 blocks as READ(6).
Signed-off-by Peng Fan <[email protected]>Acked-by Marcel Ziswiler <[email protected]>(cherry picked from commit df0052575b2bc9d66ae73584768e1a457ed5d914)---
This comes from NXP's downstream and has proven to tremendously improve the situation with those odd USB mass storage aka memory sticks. This is why I post it here asking whether or not this may be something benefiting more people. Any feedback and suggestions are welcome.common/usb_storage.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)common/usb_storage.c +5
-2@@ -949,7 +949,11 @@ static void usb_stor_set_max_xfer_blk(struct usb_device *udev,* there is enough free heap space left, but the SCSI READ(10) and * WRITE(10) commands are limited to 65535 blocks. */ - blk =USHRT_MAX ; +/* +* Some USB Massstorage devices have issues, limiting this to 256 +* fixes this. +*/ + blk =256 ;#else blk =20 ;#endif --2.20.1
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
RFC PATCH 1/1 MLK-12883 usb: limit USB_MAX_XFER_BLK to 256
Quoted 1 line · Igor Opaniuk
There is a typo in the comment: USB Massstorage
I believe it is just everywhere called USB mass storage really.
Quoted 2 lines
Also regarding refering to a specific commit ("(cherry picked from commit
df0052575b2bc9d66ae73584768e1a457ed5d914)" line):
That is really just git's default cherry pick message as added by its -x command line argument. None of my doing really.
Quoted 6 lines
Quoted 6 lines
If you want to refer to a specific commit, don’t just refer to the SHA-1 ID of the commit.
Please also include the oneline summary of the commit, to make it easier for reviewers to know what it is about. Example:
Commite21d2170f36602ae2708("video: remove unnecessaryplatform_set_drvdata()")
I am fully aware of this, however, I believe usually the hash would be shortened to just 12 characters.
Quoted 65 lines
[1]:
https://www.kernel.org/doc/html/v5.1-rc2/process/submitting-patches.htmlQuoted 60 lines · Marcel Ziswiler
From: Peng Fan <[email protected]>
For Some USB mass storage devices, such as:
"
- Kingston DataTraveler 2.0 001D7D06CF09B04199C7B3EA
- Class: (from Interface) Mass Storage
- PacketSize: 64 Configurations: 1
- Vendor:0x0930Product0x6545Version 1.16
"
Whenusb read 0x80000000 0 0x2000, we met "EHCI timed out on TD - token=0x80008d80".The devices does not support scsi VPD page, we are not able to get the maximum transfer length for READ(10)/WRITE(10).
So we limit this to 256 blocks as READ(6).
Signed-off-by Peng Fan <[email protected]>Acked-by Marcel Ziswiler <[email protected]>(cherry picked from commit
df0052575b2bc9d66ae73584768e1a457ed5d914)---
This comes from NXP's downstream and has proven to tremendously improve
the situation with those odd USB mass storage aka memory sticks. This is
why I post it here asking whether or not this may be something benefiting more people. Any feedback and suggestions are welcome.common/usb_storage.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)common/usb_storage.c +0
-0@@ -949,7 +949,11 @@ static void usb_stor_set_max_xfer_blk(structusb_device *udev, * there is enough free heap space left, but the SCSIREAD(10) and
* WRITE(10) commands are limited to 65535 blocks. */common/usb_storage.c +2
-1- blk =USHRT_MAX ; +/* +* Some USB Massstorage devices have issues, limiting this to 256
common/usb_storage.c +3
-1+* fixes this. +*/ + blk =256 ;#else blk =20 ;#endif --2.20.1
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot