Staging: media: davinci_vpfe: Fix preferred form of passing a size
Subsystems (2)
PATCH v3 1/1 Staging: media: davinci_vpfe: Fix preferred form of passing a size
Fix preferred form of passing a size of a struct to improve readability and eradicate an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not.
Signed-off-by Madhumitha Prabakaran <[email protected]>
---
Changes in v3:
- Include change log and correct spelling mistake of preferred in commit log
Changes in v2:
- Include second parameters of kmallocs in same line
--- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +2 -4
@@ -1264,8 +1264,7 @@ static int ipipe_s_config(struct v4l2_subdev *sd, struct vpfe_ipipe_config *cfg) module_if = &ipipe_modules[i]; from = *(void **)((void *)cfg + module_if->config_offset); - params =kmalloc (sizeof (struct ipipe_module_params ), -GFP_KERNEL ); + params =kmalloc (sizeof (*params),GFP_KERNEL ); to = (void *)params + module_if->param_offset; size = module_if->param_size;
@@ -1306,8 +1305,7 @@ static int ipipe_g_config(struct v4l2_subdev *sd, struct vpfe_ipipe_config *cfg) module_if = &ipipe_modules[i]; to = *(void **)((void *)cfg + module_if->config_offset); - params =kmalloc (sizeof (struct ipipe_module_params ), -GFP_KERNEL ); + params =kmalloc (sizeof (*params),GFP_KERNEL ); from = (void *)params + module_if->param_offset; size = module_if->param_size;
Signature · 1 line
2.17.1