Skip to contentSkip to conversation

staging: tegra-vde: Add comment for the lock declaration

PATCH In review Jules Irenge 2 participants 3 messages Mar 25, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: tegra-vde: Add comment for the lock declaration

Add comment for the lock declaration to fix checkpatch warning Issue found by checkpatch.pl warning:
"CHECK: struct mutex definition without comment".

---
 drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/tegra-vde/tegra-vde.c +1 -1
index a5020dbf6eef..78ad78e03d12 100644
@@ -59,7 +59,7 @@ struct tegra_vde {
 	void __iomem *ppb;
 	void __iomem *vdma;
 	void __iomem *frameid;
-	struct mutex lock;
+	struct mutex lock; /* generic mutex lock for tegra-vde driver */
 	struct miscdevice miscdev;
 	struct reset_control *rst;
 	struct reset_control *rst_mc;
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 6 lines · Jules Irenge

Add comment for the lock declaration to fix checkpatch warning Issue found by checkpatch.pl warning:
"CHECK: struct mutex definition without comment".

---
 drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

No signed-off-by?

maintainer
#2 lore raw
In reply to Jules Irenge
Quoted 12 lines · Jules Irenge

Add comment for the lock declaration to fix checkpatch warning Issue found by checkpatch.pl warning:
"CHECK: struct mutex definition without comment".

---
 drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/tegra-vde/tegra-vde.c +0 -0
index a5020dbf6eef..78ad78e03d12 100644

drivers/staging/media/tegra-vde/tegra-vde.c struct tegra_vde { · line 62

Quoted 5 lines
drivers/staging/media/tegra-vde/tegra-vde.c +1 -1
@@ -59,7 +59,7 @@ struct tegra_vde {
 	void __iomem *ppb;
 	void __iomem *vdma;
 	void __iomem *frameid;
-	struct mutex lock;
+	struct mutex lock; /* generic mutex lock for tegra-vde driver */

Also, we know this is a lock, but what we don't know is _what_ it does :)

You need a much better explaination than this, sorry. I don't recommend this being a good "first patch" unless you really know this specific driver's codebase.

thanks,

greg k-h