Skip to contentSkip to conversation

package/owfs: drop unneeded first patch

PATCH New Fabrice Fontaine 3 participants 7 messages Mar 24, 2019 – Mar 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 package/owfs: drop unneeded first patch

Patch is not needed since version 3.1p2 and
https://github.com/owfs/owfs/commit/2982df8ca648bd9cec4d820151046b044ef504e0
because localtime_r is now correctly checked

---
 ...1-configure.ac-check-for-localtime_r.patch | 35 -------------------
 ...1-include-sys-sysmacros.h-for-major.patch} |  0
 package/owfs/owfs.mk                          |  2 +-
 3 files changed, 1 insertion(+), 36 deletions(-)
 delete mode 100644 package/owfs/0001-configure.ac-check-for-localtime_r.patch
 rename package/owfs/{0002-include-sys-sysmacros.h-for-major.patch => 0001-include-sys-sysmacros.h-for-major.patch} (100%)
package/owfs/0001-configure.ac-check-for-localtime_r.patch deleted +0 -35
deleted file mode 100644
index b25aa59878..0000000000
@@ -1,35 +0,0 @@
-From 75e92438bcdb78a90912366b07bf503646806686 Mon Sep 17 00:00:00 2001
-From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]>
-Date: Sun, 21 Feb 2016 17:02:06 +0100
-Subject: [PATCH] configure.ac: check for localtime_r
-
-HAVE_LOCALTIME_R is used in owftp.c, so it should be checked for.
-
-Without this, static build fails because localtime_r is defined twice.
-
-Upstream-Status: Submitted
-https://sourceforge.net/p/owfs/mailman/message/34873667/
-
-Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
-[Bernd: rebased against version 3.2p1]
-Signed-off-by: Bernd Kuhls <[email protected]>
----
- configure.ac | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/configure.ac b/configure.ac
-index c22dde9..12fdd18 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -1646,7 +1646,7 @@
- AC_FUNC_STRFTIME
- AC_FUNC_STRTOD
- AC_TYPE_SIGNAL
--AC_CHECK_FUNCS([accept daemon getaddrinfo freeaddrinfo gethostbyname2_r gethostbyaddr_r gethostbyname_r getservbyname_r getopt getopt_long gmtime_r gettimeofday localtime_r inet_ntop inet_pton memchr memset select socket strcasecmp strchr strdup strncasecmp strtol strtoul twalk tsearch tfind tdelete tdestroy vasprintf strsep vsprintf vsnprintf writev getline])
-+AC_CHECK_FUNCS([accept daemon getaddrinfo freeaddrinfo gethostbyname2_r gethostbyaddr_r gethostbyname_r getservbyname_r getopt getopt_long gmtime_r gettimeofday localtime_r inet_ntop inet_pton memchr memset select socket strcasecmp strchr strdup strncasecmp strtol strtoul twalk tsearch tfind tdelete tdestroy vasprintf strsep vsprintf vsnprintf writev getline localtime_r])
- 
- save_LIBS="$LIBS"
- LIBS=""
--- 
-2.7.0
-
package/owfs/0001-include-sys-sysmacros.h-for-major.patch renamed from package/owfs/0002-include-sys-sysmacros.h-for-major.patch +0 -0
similarity index 100%
rename from package/owfs/0002-include-sys-sysmacros.h-for-major.patch
rename to package/owfs/0001-include-sys-sysmacros.h-for-major.patch
package/owfs/owfs.mk +1 -1
index e120147151..2d0f24fb7c 100644
@@ -9,7 +9,7 @@ OWFS_SITE = http://downloads.sourceforge.net/project/owfs/owfs/$(OWFS_VERSION)
 OWFS_DEPENDENCIES = host-pkgconf
 OWFS_CONF_OPTS = --disable-owperl --without-perl5 --disable-owtcl --without-tcl
 
-# 0001-configure.ac-check-for-localtime_r.patch touches configure.ac
+# We're patching configure.ac
 OWFS_AUTORECONF = YES
 
 # owtcl license is declared in module/ownet/c/src/include/ow_functions.h
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/3 package/libftdi1: fix libftdi1-config

Add libftdi1-config to LIBFTDI1_CONFIG_SCRIPTS

---
 package/libftdi1/libftdi1.mk | 1 +
 1 file changed, 1 insertion(+)
package/libftdi1/libftdi1.mk +1 -0
index c45c83a711..014dd8401e 100644
@@ -11,6 +11,7 @@ LIBFTDI1_INSTALL_STAGING = YES
 LIBFTDI1_DEPENDENCIES = libusb
 LIBFTDI1_LICENSE = LGPL-2.0 (libftdi1), GPL-2.0 with exception (ftdipp1)
 LIBFTDI1_LICENSE_FILES = LICENSE COPYING.GPL COPYING.LIB
+LIBFTDI1_CONFIG_SCRIPTS = libftdi1-config
 LIBFTDI1_CONF_OPTS = -DDOCUMENTATION=OFF -DEXAMPLES=OFF
 
 ifeq ($(BR2_PACKAGE_LIBFTDI1_LIBFTDIPP1),y)
Signature · 1 line
2.20.1
#3 lore raw

PATCH 3/3 package/owfs: add optional libftdi dependency

In reply to Fabrice Fontaine

ftdi support has been added in version 3.1p2 and
https://github.com/owfs/owfs/commit/2982df8ca648bd9cec4d820151046b044ef504e0

---
 package/owfs/owfs.mk | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
package/owfs/owfs.mk +14 -0
index 2d0f24fb7c..cd1c2dba6d 100644
@@ -42,6 +42,20 @@ else
 OWFS_CONF_OPTS += --disable-owfs
 endif
 
+ifeq ($(BR2_PACKAGE_LIBFTDI1),y)
+OWFS_CONF_OPTS += \
+	--enable-ftdi \
+	--with-libftdi-config=$(STAGING_DIR)/usr/bin/libftdi1-config
+OWFS_DEPENDENCIES += libftdi1
+else ifeq ($(BR2_PACKAGE_LIBFTDI),y)
+OWFS_CONF_OPTS += \
+	--enable-ftdi \
+	--with-libftdi-config=$(STAGING_DIR)/usr/bin/libftdi-config
+OWFS_DEPENDENCIES += libftdi
+else
+OWFS_CONF_OPTS += --disable-ftdi
+endif
+
 ifeq ($(BR2_PACKAGE_LIBUSB),y)
 OWFS_CONF_OPTS += --enable-usb
 OWFS_DEPENDENCIES += libusb
Signature · 1 line
2.20.1
#5 lore raw

PATCH 1/3 package/owfs: drop unneeded first patch

In reply to Fabrice Fontaine

Hello,

Quoted 4 lines · On Sun, 24 Mar 2019 23:10:17 +0100 Fabrice Fontaine…

Patch is not needed since version 3.1p2 and
https://github.com/owfs/owfs/commit/2982df8ca648bd9cec4d820151046b044ef504e0
because localtime_r is now correctly checked

Quoted 8 lines
---
 ...1-configure.ac-check-for-localtime_r.patch | 35 -------------------
 ...1-include-sys-sysmacros.h-for-major.patch} |  0
 package/owfs/owfs.mk                          |  2 +-
 3 files changed, 1 insertion(+), 36 deletions(-)
 delete mode 100644 package/owfs/0001-configure.ac-check-for-localtime_r.patch
 rename package/owfs/{0002-include-sys-sysmacros.h-for-major.patch => 0001-include-sys-sysmacros.h-for-major.patch} (100%)

Series applied to master. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH 1/3 package/owfs: drop unneeded first patch

In reply to Fabrice Fontaine
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Patch is not needed since version 3.1p2 and
https://github.com/owfs/owfs/commit/2982df8ca648bd9cec4d820151046b044ef504e0
because localtime_r is now correctly checked

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard