Skip to contentSkip to conversation

board: rename pine64 to pine64_a64

PATCH Superseded Jagan Teki 2 participants 3 messages Mar 25, 2019 – Mar 27, 2019 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jagan Teki

author
#1 lore raw

PATCH v2 1/1 board: rename pine64 to pine64_a64

Quoted 3 lines · On Sat, Feb 2, 2019 at 9:35 AM <[email protected]> wrote:

From: Philip Molloy <[email protected]>

I'm commenting based on the code, since there is not commit message for this patch.

board/pine64/a64/genimage.cfg

Quoted 34 lines
---
 DEVELOPERS                                         | 2 +-
 board/pine64/{pine64 => a64}/boot.cmd              | 0
 board/pine64/{pine64 => a64}/genimage.cfg          | 0
 board/pine64/{pine64 => a64}/readme.txt            | 8 ++++----
 configs/{pine64_defconfig => pine64_a64_defconfig} | 4 ++--
 5 files changed, 7 insertions(+), 7 deletions(-)
 rename board/pine64/{pine64 => a64}/boot.cmd (100%)
 rename board/pine64/{pine64 => a64}/genimage.cfg (100%)
 rename board/pine64/{pine64 => a64}/readme.txt (80%)
 rename configs/{pine64_defconfig => pine64_a64_defconfig} (93%)
DEVELOPERS +1 -1
index c1950bb0f4..d54708add5 100644
@@ -999,7 +999,7 @@ F:  configs/orangepi_pc2_defconfig
 F:     configs/orangepi_prime_defconfig
 F:     configs/orangepi_win_defconfig
 F:     configs/orangepi_zero_plus2_defconfig
-F:     configs/pine64_defconfig
+F:     configs/pine64_a64_defconfig
 F:     configs/pine64_sopine_defconfig
 
 N:     James Hilliard <[email protected]>
board/pine64/a64/boot.cmd renamed from board/pine64/pine64/boot.cmd +0 -0
similarity index 100%
rename from board/pine64/pine64/boot.cmd
rename to board/pine64/a64/boot.cmd
board/pine64/a64/genimage.cfg renamed from board/pine64/pine64/genimage.cfg +0 -0
similarity index 100%
rename from board/pine64/pine64/genimage.cfg
rename to board/pine64/a64/genimage.cfg

pine64 is vendor who produced pine64 board. and same vendor producing sopine. so renaming to a64 doesn't valid.

Quoted 8 lines
board/pine64/a64/readme.txt renamed from board/pine64/pine64/readme.txt +0 -0
similarity index 80%
rename from board/pine64/pine64/readme.txt
rename to board/pine64/a64/readme.txt
index 85226fdd17..c35bf62037 100644

board/pine64/a64/readme.txt Intro · line 9

Quoted 10 lines
board/pine64/a64/readme.txt renamed from board/pine64/pine64/readme.txt +2 -2
@@ -2,10 +2,10 @@ Intro
 =====
 
 This default configuration will allow you to start experimenting with the
-buildroot environment for the Pine64. With the current configuration
+buildroot environment for the Pine A64. With the current configuration
 it will bring-up the board, and allow access through the serial console.
 
-Pine64 link:
+Pine A64 link:
 https://www.pine64.org/?page_id=1194

It has wiki link below, that intern routing pine64 board link. wiki has Mainline stuff information.

#2 lore raw

PATCH v2 1/1 board: rename pine64 to pine64_a64

Hello,

I haven't seen the original patch. Was it sent to the Buildroot mailing list ? It doesn't seem like it reached the mailing list.

Philip: did you register on the mailing list before sending your patch ? If not, could you subscribe to the mailing list and resend ? Thanks!

Quoted 4 lines · On Mon, 25 Mar 2019 10:43:45 +0530 Jagan Teki <[email protected]>…
Quoted 4 lines

N: James Hilliard <[email protected]>

board/pine64/a64/boot.cmd renamed from board/pine64/pine64/boot.cmd +0 -0
similarity index 100%
rename from board/pine64/pine64/boot.cmd
Quoted 8 lines

board/pine64/a64/genimage.cfg

Quoted 5 lines

rename to board/pine64/a64/boot.cmd

board/pine64/a64/genimage.cfg renamed from board/pine64/pine64/genimage.cfg +0 -0
similarity index 100%
rename from board/pine64/pine64/genimage.cfg
rename to board/pine64/a64/genimage.cfg  

pine64 is vendor who produced pine64 board. and same vendor producing sopine. so renaming to a64 doesn't valid.

What? I'm sorry I don't understand what you mean here.

The typical Buildroot folder organization is:

	board/<vendor>/<boardname>/

pine64 is indeed a vendor name, and a64 is a board name, according to
https://www.pine64.org/?page_id=46823. So the change looks perfect correct to me. It will allow to add support for other boards produced by Pine64, in board/pine64/<boardname>/.

Quoted 6 lines

board/pine64/a64/genimage.cfg

Quoted 3 lines
board/pine64/a64/genimage.cfg renamed from board/pine64/pine64/genimage.cfg +1 -1
-Pine64 link:
+Pine A64 link:
 https://www.pine64.org/?page_id=1194  

It has wiki link below, that intern routing pine64 board link. wiki has Mainline stuff information.

I'm not a native English speaker, so I might be wrong, but I believe "that intern routing pine64 board link" doesn't make any sense in English. What are you trying to say here ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#3 lore raw

PATCH v2 1/1 board: rename pine64 to pine64_a64

Quoted 28 lines · Thomas Petazzoni

Hello,

I haven't seen the original patch. Was it sent to the Buildroot mailing list ? It doesn't seem like it reached the mailing list.

Philip: did you register on the mailing list before sending your patch ? If not, could you subscribe to the mailing list and resend ? Thanks!

Quoted 4 lines · On Mon, 25 Mar 2019 10:43:45 +0530 Jagan Teki <[email protected]>…
Quoted 4 lines

N: James Hilliard <[email protected]>

board/pine64/a64/boot.cmd renamed from board/pine64/pine64/boot.cmd +0 -0
similarity index 100%
rename from board/pine64/pine64/boot.cmd
Quoted 8 lines

board/pine64/a64/genimage.cfg

Quoted 5 lines

rename to board/pine64/a64/boot.cmd

board/pine64/a64/genimage.cfg renamed from board/pine64/pine64/genimage.cfg +0 -0
similarity index 100%
rename from board/pine64/pine64/genimage.cfg
rename to board/pine64/a64/genimage.cfg

pine64 is vendor who produced pine64 board. and same vendor producing sopine. so renaming to a64 doesn't valid.

What? I'm sorry I don't understand what you mean here.

Quoted 8 lines

The typical Buildroot folder organization is:

        board/<vendor>/<boardname>/

pine64 is indeed a vendor name, and a64 is a board name, according to
https://www.pine64.org/?page_id=46823. So the change looks perfect correct to me. It will allow to add support for other boards produced by Pine64, in board/pine64/<boardname>/.

The above link is for LTS which typically share different dts. The existing support is been added for non LTS based
https://www.pine64.org/?page_id=1194

So the board name is PINE same as SOPINE on here
https://www.pine64.org/?page_id=1491

We can structure board/pine64/pine and board/pine64/sopine (which is already present).

Quoted 11 lines
Quoted 7 lines

board/pine64/a64/genimage.cfg

Quoted 4 lines
board/pine64/a64/genimage.cfg renamed from board/pine64/pine64/genimage.cfg +1 -1
-Pine64 link:
+Pine A64 link:
 https://www.pine64.org/?page_id=1194

It has wiki link below, that intern routing pine64 board link. wiki has Mainline stuff information.

I'm not a native English speaker, so I might be wrong, but I believe "that intern routing pine64 board link" doesn't make any sense in English. What are you trying to say here ?

What I'm saying here is, the wiki has board link and we may not specify explicitly.