Skip to contentSkip to conversation

staging: sm750fb: lower case to fix camelcase checkpatch warning

PATCH RESEND Superseded Jules Irenge 2 participants 3 messages Mar 25, 2019

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 staging: sm750fb: lower case to fix camelcase checkpatch warning

Lower case to fix CamelCase checkpatch.pl warning
"CHECK: Avoid CamelCase: <ulActualMxClk>".

---
 drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +2 -2
index 6bdf643707c2..3fe4479401e5 100644
@@ -56,7 +56,7 @@ static unsigned int get_mxclk_freq(void)
 static void set_chip_clock(unsigned int frequency)
 {
 	struct pll_value pll;
-	unsigned int ulActualMxClk;
+	unsigned int ul_actual_mx_clk;
 
 	/* Cheok_0509: For SM750LE, the chip clock is fixed. Nothing to set. */
 	if (sm750_get_chip_type() == SM750LE)
@@ -76,7 +76,7 @@ static void set_chip_clock(unsigned int frequency)
 		 * Return value of sm750_calc_pll_value gives the actual
 		 * possible clock.
 		 */
-		ulActualMxClk = sm750_calc_pll_value(frequency, &pll);
+		ul_actual_mx_clk = sm750_calc_pll_value(frequency, &pll);
 
 		/* Master Clock Control: MXCLK_PLL */
 		poke32(MXCLK_PLL_CTRL, sm750_format_pll_reg(&pll));
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 13 lines · Jules Irenge

Lower case to fix CamelCase checkpatch.pl warning
"CHECK: Avoid CamelCase: <ulActualMxClk>".

---
 drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +0 -0
index 6bdf643707c2..3fe4479401e5 100644

drivers/staging/sm750fb/ddk750_chip.c static unsigned int get_mxclk_freq(void) · line 59

Quoted 5 lines
drivers/staging/sm750fb/ddk750_chip.c +1 -1
@@ -56,7 +56,7 @@ static unsigned int get_mxclk_freq(void)
 static void set_chip_clock(unsigned int frequency)
 {
 	struct pll_value pll;
-	unsigned int ulActualMxClk;
+	unsigned int ul_actual_mx_clk;

There is no need for the "ul" right?

#2 lore raw
Quoted 11 lines · Greg KH

Review

Quoted 9 lines · Jules Irenge

Lower case to fix CamelCase checkpatch.pl warning
"CHECK: Avoid CamelCase: <ulActualMxClk>".

---
 drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/sm750fb/ddk750_chip.c

Quoted 11 lines
Quoted 10 lines

index 6bdf643707c2..3fe4479401e5 100644

drivers/staging/sm750fb/ddk750_chip.c +1 -1
@@ -56,7 +56,7 @@ static unsigned int get_mxclk_freq(void)
 static void set_chip_clock(unsigned int frequency)
 {
      struct pll_value pll;
-     unsigned int ulActualMxClk;
+     unsigned int ul_actual_mx_clk;

There is no need for the "ul" right?

Yes, there is no need. I am removing it now and resend. Thanks