net: openvswitch: Add a new action check_pkt_len
Subsystems (3)
PATCH v2 1/1 net: openvswitch: Add a new action check_pkt_len
From: Numan Siddique <[email protected]>
This patch adds a new action - 'check_pkt_len' which checks the packet length and executes a set of actions if the packet length is greater than the specified length or executes another set of actions if the packet length is lesser or equal to.
This action takes below nlattrs
* OVS_CHECK_PKT_LEN_ATTR_PKT_LEN - 'pkt_len' to check for
* OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_GREATER - Nested actions to apply if the packet length is greater than the specified 'pkt_len'
* OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_LESS_EQUAL - Nested actions to apply if the packet length is lesser or equal to the specified 'pkt_len'.
The main use case for adding this action is to solve the packet drops because of MTU mismatch in OVN virtual networking solution. When a VM (which belongs to a logical switch of OVN) sends a packet destined to go via the gateway router and if the nic which provides external connectivity, has a lesser MTU, OVS drops the packet if the packet length is greater than this MTU.
With the help of this action, OVN will check the packet length and if it is greater than the MTU size, it will generate an ICMP packet (type 3, code 4) and includes the next hop mtu in it so that the sender can fragment the packets.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2018-July/047039.html
---
v1 -> v2
-----
* Addressed the review comments.
- Removed the vlan-tag length when checking the packet length
- Reordered the netlink attributes
- Changed the comments to use 'attribute' instead of 'action'
Corresponding OVS patch (submitted as RFC for now) which makes use of this action can be found here - https://patchwork.ozlabs.org/patch/1059081/
include/uapi/linux/openvswitch.h | 42 ++++++++ net/openvswitch/actions.c | 48 +++++++++ net/openvswitch/flow_netlink.c | 171 +++++++++++++++++++++++++++++++ 3 files changed, 261 insertions(+)
include/uapi/linux/openvswitch.h +42 -0
@@ -798,6 +798,44 @@ struct ovs_action_push_eth {struct ovs_key_ethernet addresses; }; +/* +* enum ovs_check_pkt_len_attr - Attributes for %OVS_ACTION_ATTR_CHECK_PKT_LEN. +* +* @OVS_CHECK_PKT_LEN_ATTR_PKT_LEN: u16 Packet length to check for. +* @OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_GREATER: Nested OVS_ACTION_ATTR_* +* actions to apply if the packer length is greater than the specified +* length in the attr - OVS_CHECK_PKT_LEN_ATTR_PKT_LEN. +* @OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_LESS_EQUAL - Nested OVS_ACTION_ATTR_* +* actions to apply if the packer length is lesser or equal to the specified +* length in the attr - OVS_CHECK_PKT_LEN_ATTR_PKT_LEN. +*/ +enum ovs_check_pkt_len_attr { +OVS_CHECK_PKT_LEN_ATTR_UNSPEC , +OVS_CHECK_PKT_LEN_ATTR_PKT_LEN , +OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_GREATER , +OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_LESS_EQUAL , + __OVS_CHECK_PKT_LEN_ATTR_MAX, + +#ifdef __KERNEL__ +OVS_CHECK_PKT_LEN_ATTR_ARG /* struct check_pkt_len_arg */ +#endif +}; + +#define OVS_CHECK_PKT_LEN_ATTR_MAX (__OVS_CHECK_PKT_LEN_ATTR_MAX - 1) + +#ifdef __KERNEL__ +struct check_pkt_len_arg { +u16 pkt_len;/* Same value as OVS_CHECK_PKT_LEN_ATTR_PKT_LEN'. */ +bool exec_for_greater;/* When true, actions in IF_GREATER will +* not change flow keys. False otherwise. +*/ +bool exec_for_lesser_equal;/* When true, actions in IF_LESS_EQUAL +* will not change flow keys. False +* otherwise. +*/ +}; +#endif +/** * enum ovs_action_attr - Action types. *
@@ -842,6 +880,9 @@ struct ovs_action_push_eth {* packet, or modify the packet (e.g., change the DSCP field). * @OVS_ACTION_ATTR_CLONE: make a copy of the packet and execute a list of * actions without affecting the original packet and key. +* @OVS_ACTION_ATTR_CHECK_PKT_LEN: Check the packet length and execute a set +* of actions if greater than the specified packet length, else execute +* another set of actions. * * Only a single header can be set with a single %OVS_ACTION_ATTR_SET. Not all * fields within a header are modifiable, e.g. the IPv4 protocol and fragment
@@ -876,6 +917,7 @@ enum ovs_action_attr {OVS_ACTION_ATTR_POP_NSH ,/* No argument. */ OVS_ACTION_ATTR_METER ,/* u32 meter ID. */ OVS_ACTION_ATTR_CLONE ,/* Nested OVS_CLONE_ATTR_*. */ +OVS_ACTION_ATTR_CHECK_PKT_LEN ,/* Nested OVS_CHECK_PKT_LEN_ATTR_*. */ __OVS_ACTION_ATTR_MAX, /* Nothing past this will be accepted* from userspace. */
net/openvswitch/actions.c +48 -0
66 lines not on this page · raw message
net/openvswitch/flow_netlink.c +171 -0
207 lines not on this page · raw message
Signature · 1 line
2.20.1
Quoted 44 lines · On Mon, Mar 25, 2019 at 5:44 PM <[email protected]> wrote:
From: Numan Siddique <[email protected]>
This patch adds a new action - '
check_pkt_len' which checks the packet length and executes a set of actions if the packet length is greater than the specified length or executes another set of actions if the packet length is lesser or equal to.This action takes below nlattrs
*OVS_CHECK_PKT_LEN_ATTR_PKT_LEN- 'pkt_len' to check for*
OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_GREATER- Nested actions to apply if the packet length is greater than the specified 'pkt_len'*
OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_LESS_EQUAL- Nested actions to apply if the packet length is lesser or equal to the specified 'pkt_len'.The main use case for adding this action is to solve the packet drops because of MTU mismatch in OVN virtual networking solution. When a VM (which belongs to a logical switch of OVN) sends a packet destined to go via the gateway router and if the nic which provides external connectivity, has a lesser MTU, OVS drops the packet if the packet length is greater than this MTU.
With the help of this action, OVN will check the packet length and if it is greater than the MTU size, it will generate an ICMP packet (type 3, code 4) and includes the next hop mtu in it so that the sender can fragment the packets.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2018-July/047039.htmlSuggested-by Ben Pfaff <[email protected]>Signed-off-by Numan Siddique <[email protected]>CC Gregory Rose <[email protected]>CC Pravin B Shelar <[email protected]>---
v1 -> v2
-----
* Addressed the review comments.
- Removed the vlan-tag length when checking the packet length
- Reordered the netlink attributes
- Changed the comments to use 'attribute' instead of 'action'
Quoted 3 lines
Corresponding OVS patch (submitted as RFC for now) which makes use of this action can be found here - https://patchwork.ozlabs.org/patch/1059081/
Looks good to me.
Quoted 44 lines · Pravin Shelar
Quoted 43 lines · On Mon, Mar 25, 2019 at 5:44 PM <[email protected]> wrote:
From: Numan Siddique <[email protected]>
This patch adds a new action - '
check_pkt_len' which checks the packet length and executes a set of actions if the packet length is greater than the specified length or executes another set of actions if the packet length is lesser or equal to.This action takes below nlattrs
*OVS_CHECK_PKT_LEN_ATTR_PKT_LEN- 'pkt_len' to check for*
OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_GREATER- Nested actions to apply if the packet length is greater than the specified 'pkt_len'*
OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_LESS_EQUAL- Nested actions to apply if the packet length is lesser or equal to the specified 'pkt_len'.The main use case for adding this action is to solve the packet drops because of MTU mismatch in OVN virtual networking solution. When a VM (which belongs to a logical switch of OVN) sends a packet destined to go via the gateway router and if the nic which provides external connectivity, has a lesser MTU, OVS drops the packet if the packet length is greater than this MTU.
With the help of this action, OVN will check the packet length and if it is greater than the MTU size, it will generate an ICMP packet (type 3, code 4) and includes the next hop mtu in it so that the sender can fragment the packets.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2018-July/047039.htmlSuggested-by Ben Pfaff <[email protected]>Signed-off-by Numan Siddique <[email protected]>CC Gregory Rose <[email protected]>CC Pravin B Shelar <[email protected]>---
v1 -> v2
-----
* Addressed the review comments.
- Removed the vlan-tag length when checking the packet length
- Reordered the netlink attributes
- Changed the comments to use 'attribute' instead of 'action'
Quoted 5 lines
Quoted 3 lines
Corresponding OVS patch (submitted as RFC for now) which makes use of this action can be found here - https://patchwork.ozlabs.org/patch/1059081/
Looks good to me.
Acked-by Pravin B Shelar <[email protected]>
From: [email protected]
Date: Tue, 26 Mar 2019 06:13:46 +0530
Quoted 29 lines
From: Numan Siddique <[email protected]>
This patch adds a new action - '
check_pkt_len' which checks the packet length and executes a set of actions if the packet length is greater than the specified length or executes another set of actions if the packet length is lesser or equal to.This action takes below nlattrs
*OVS_CHECK_PKT_LEN_ATTR_PKT_LEN- 'pkt_len' to check for*
OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_GREATER- Nested actions to apply if the packet length is greater than the specified 'pkt_len'*
OVS_CHECK_PKT_LEN_ATTR_ACTIONS_IF_LESS_EQUAL- Nested actions to apply if the packet length is lesser or equal to the specified 'pkt_len'.The main use case for adding this action is to solve the packet drops because of MTU mismatch in OVN virtual networking solution. When a VM (which belongs to a logical switch of OVN) sends a packet destined to go via the gateway router and if the nic which provides external connectivity, has a lesser MTU, OVS drops the packet if the packet length is greater than this MTU.
With the help of this action, OVN will check the packet length and if it is greater than the MTU size, it will generate an ICMP packet (type 3, code 4) and includes the next hop mtu in it so that the sender can fragment the packets.
Quoted 4 lines
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2018-July/047039.htmlSuggested-by Ben Pfaff <[email protected]>Signed-off-by Numan Siddique <[email protected]>
Applied, thanks.