Skip to contentSkip to conversation

drm: connector firmware nodes

PATCH In review Heikki Krogerus 4 participants 9 messages Mar 25, 2019 – Mar 27, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover drm: connector firmware nodes

Hi,

If the system firmware supplies device nodes representing the display connectors on integrated video hardware, those nodes should probable always be associated with the display connector entries (struct drm_connector).

With the USB Type-C DisplayPort alt mode, we will need a way to inform the correct drm connector entry about HPD IRQ, lane counts and other details. In ACPI (and most likely in DT too) the device node representing a DisplayPort behind USB Type-C connector should have a reference to the device node representing the USB Type-C connector (or vise versa). Once we have associated the DP connector device nodes with the drm connector entries, we can use those references to find the correct drm connector that the information the USB Type-C drivers are sending is meant for.

Because I think the connector firmware nodes should be associated with the connector entries in any case (those nodes do seem to be supplying the connectors all kinds of resources, not only references to other components), I'm proposing this now instead of waiting for the USB Type-C patches.

thanks,

Heikki Krogerus (2):
drm: Add fwnode member to the struct drm_connector drm/i915: Associate ACPI connector nodes with connector entries

 drivers/gpu/drm/drm_sysfs.c          | 49 +++++++++++++++++++---------
 drivers/gpu/drm/i915/intel_display.c | 40 +++++++++++++++++++++++
 include/drm/drm_connector.h          |  2 ++
 3 files changed, 76 insertions(+), 15 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/2 drm: Add fwnode member to the struct drm_connector

If the system firmware supplies nodes that represent the connectors, they need to be associated with the connector entries.

ACPI tables at least always supply a device node for every connector on integrated video hardware - this is explained in ACPI specification's ch. "Appendix B Video Extension". Many drivers appear to already deal with those connector firmware nodes "indirectly" in order to support custom Operation Regions, _DSM (device specific method) and access other resources the nodes supply for the connectors.

This commit will only add the fwnode member. It's first up to the drivers to assign and take advantage of it. For convenience, the nodes are assigned to the device entries that are used for exposing the connectors to the user space via sysfs. That makes it possible to see the link between the connector and its node also from user space. In case of ACPI, the connector's sysfs directory will have a symlink named "firmware_node" pointing to the node object directory in sysfs if a node is associated with the connector.

---
 drivers/gpu/drm/drm_sysfs.c | 49 +++++++++++++++++++++++++------------
 include/drm/drm_connector.h |  2 ++
 2 files changed, 36 insertions(+), 15 deletions(-)
drivers/gpu/drm/drm_sysfs.c +34 -15
index ecb7b33002bb..7667939ef1c0 100644
@@ -264,26 +264,50 @@ static const struct attribute_group *connector_dev_groups[] = {
 	NULL
 };
 
+static void drm_sysfs_release(struct device *dev)
+{
+	kfree(dev);
+}
+
 int drm_sysfs_connector_add(struct drm_connector *connector)
 {
 	struct drm_device *dev = connector->dev;
+	struct device *kdev;
+	int ret;
 
 	if (connector->kdev)
 		return 0;
 
-	connector->kdev =
-		device_create_with_groups(drm_class, dev->primary->kdev, 0,
-					  connector, connector_dev_groups,
-					  "card%d-%s", dev->primary->index,
-					  connector->name);
-	DRM_DEBUG("adding \"%s\" to sysfs\n",
-		  connector->name);
+	kdev = kzalloc(sizeof(*kdev), GFP_KERNEL);
+	if (!kdev)
+		return -ENOMEM;
 
-	if (IS_ERR(connector->kdev)) {
-		DRM_ERROR("failed to register connector device: %ld\n", PTR_ERR(connector->kdev));
-		return PTR_ERR(connector->kdev);
+	device_initialize(kdev);
+	kdev->class = drm_class;
+	kdev->parent = dev->primary->kdev;
+	kdev->fwnode = connector->fwnode;
+	kdev->groups = connector_dev_groups;
+	kdev->release = drm_sysfs_release;
+	dev_set_drvdata(kdev, connector);
+
+	ret = dev_set_name(kdev, "card%d-%s", dev->primary->index,
+			   connector->name);
+	if (ret) {
+		kfree(kdev);
+		return ret;
+	}
+
+	DRM_DEBUG("adding \"%s\" to sysfs\n", connector->name);
+
+	ret = device_add(kdev);
+	if (ret) {
+		DRM_ERROR("failed to register connector device: %d\n", ret);
+		put_device(kdev);
+		return ret;
 	}
 
+	connector->kdev = kdev;
+
 	/* Let userspace know we have a new connector */
 	drm_sysfs_hotplug_event(dev);
 
@@ -330,11 +354,6 @@ void drm_sysfs_hotplug_event(struct drm_device *dev)
 }
 EXPORT_SYMBOL(drm_sysfs_hotplug_event);
 
-static void drm_sysfs_release(struct device *dev)
-{
-	kfree(dev);
-}
-
 struct device *drm_sysfs_minor_alloc(struct drm_minor *minor)
 {
 	const char *minor_str;
include/drm/drm_connector.h +2 -0
index c8061992d6cb..b8977c4eab14 100644
@@ -886,6 +886,8 @@ struct drm_connector {
 	struct device *kdev;
 	/** @attr: sysfs attributes */
 	struct device_attribute *attr;
+	/** @fwnode: associated device node supplied by platform firmware */
+	struct fwnode_handle *fwnode;
 
 	/**
 	 * @head:
Signature · 1 line
2.20.1
#2 lore raw

PATCH 2/2 drm/i915: Associate ACPI connector nodes with connector entries

In reply to Heikki Krogerus

On Intel platforms we know that the ACPI connector device node order will follow the order the driver (i915) decides. The decision is made using the custom Intel ACPI OpRegion (intel_opregion.c), though the driver does not actually know that the values it sends to ACPI there are used for associating a device node for the connectors, and assigning address for them.

In reality that custom Intel ACPI OpRegion actually violates ACPI specification (we supply dynamic information to objects that are defined static, for example _ADR), however, it makes assigning correct connector node for a connector entry straightforward (it's one-on-one mapping).

---
 drivers/gpu/drm/i915/intel_display.c | 40 ++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
drivers/gpu/drm/i915/intel_display.c +40 -0
index 008560ef4db0..27aea2ef80ac 100644
@@ -15526,6 +15526,45 @@ static int intel_initial_commit(struct drm_device *dev)
 	return ret;
 }
 
+/* NOTE: The connector order must be final before this is called. */
+static void intel_assign_connector_fwnodes(struct drm_device *dev)
+{
+	struct drm_connector_list_iter conn_iter;
+	struct device *kdev = &dev->pdev->dev;
+	struct fwnode_handle *fwnode = NULL;
+	struct drm_connector *connector;
+	struct acpi_device *adev;
+
+	drm_connector_list_iter_begin(dev, &conn_iter);
+	drm_for_each_connector_iter(connector, &conn_iter) {
+		/* Always getting the next, even when the last was not used. */
+		fwnode = device_get_next_child_node(kdev, fwnode);
+		if (!fwnode)
+			break;
+
+		switch (connector->connector_type) {
+		case DRM_MODE_CONNECTOR_LVDS:
+		case DRM_MODE_CONNECTOR_eDP:
+		case DRM_MODE_CONNECTOR_DSI:
+			/*
+			 * Integrated displays have a specific address 0x1f on
+			 * most Intel platforms, but not on all of them.
+			 */
+			adev = acpi_find_child_device(ACPI_COMPANION(kdev),
+						      0x1f, 0);
+			if (adev) {
+				connector->fwnode = acpi_fwnode_handle(adev);
+				break;
+			}
+			/* fallthrough */
+		default:
+			connector->fwnode = fwnode;
+			break;
+		}
+	}
+	drm_connector_list_iter_end(&conn_iter);
+}
+
 int intel_modeset_init(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = to_i915(dev);
@@ -15630,6 +15669,7 @@ int intel_modeset_init(struct drm_device *dev)
 
 	drm_modeset_lock_all(dev);
 	intel_modeset_setup_hw_state(dev, dev->mode_config.acquire_ctx);
+	intel_assign_connector_fwnodes(dev);
 	drm_modeset_unlock_all(dev);
 
 	for_each_intel_crtc(dev, crtc) {
Signature · 1 line
2.20.1
#3 lore raw

✓ Fi.CI.BAT: success for drm: connector firmware nodes

In reply to Heikki Krogerus
== Series Details ==

== Series Details ==

Series: drm: connector firmware nodes
URL : https://patchwork.freedesktop.org/series/58531/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5810 -> Patchwork_12592
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/58531/revisions/1/mbox/

Known issues
------------

Here are the changes found in Patchwork_12592 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-compute:
- fi-cfl-guc: NOTRUN -> SKIP [fdo#109271] +49
- fi-skl-iommu: NOTRUN -> SKIP [fdo#109271] +45

* igt@amdgpu/amd_basic@cs-gfx:
- fi-skl-6700k2: NOTRUN -> SKIP [fdo#109271] +41

* igt@amdgpu/amd_basic@cs-sdma:
- fi-skl-6770hq: NOTRUN -> SKIP [fdo#109271] +37
- fi-kbl-guc: NOTRUN -> SKIP [fdo#109271] +80

* igt@amdgpu/amd_basic@userptr:
- fi-whl-u: NOTRUN -> SKIP [fdo#109271] +41
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]

* igt@amdgpu/amd_cs_nop@sync-compute0:
- fi-bdw-gvtdvm: NOTRUN -> SKIP [fdo#109271] +42

* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> SKIP [fdo#109271] +41

* igt@gem_exec_basic@basic-vebox:
- fi-ivb-3770: NOTRUN -> SKIP [fdo#109271] +48

* igt@gem_exec_basic@gtt-bsd:
- fi-bwr-2160: NOTRUN -> SKIP [fdo#109271] +103

* igt@gem_exec_basic@gtt-bsd2:
- fi-kbl-7500u: NOTRUN -> SKIP [fdo#109271] +9

* igt@gem_exec_basic@readonly-bsd:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76

* igt@gem_exec_basic@readonly-bsd1:
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] +57

* igt@gem_exec_gttfill@basic:
- fi-skl-gvtdvm: NOTRUN -> SKIP [fdo#109271] +41

* igt@gem_exec_store@basic-bsd2:
- fi-hsw-4770: NOTRUN -> SKIP [fdo#109271] +41

* igt@gem_mmap_gtt@basic-write-cpu-read-gtt:
- fi-apl-guc: NOTRUN -> SKIP [fdo#109271] +50

* igt@gem_ringfill@basic-default-fd:
- fi-elk-e7500: NOTRUN -> SKIP [fdo#109271] +73

* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: NOTRUN -> DMESG-FAIL [fdo#110235 ]

* igt@i915_selftest@live_execlists:
- fi-apl-guc: NOTRUN -> INCOMPLETE [fdo#103927] / [fdo#109720]

* igt@kms_busy@basic-flip-a:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

* igt@kms_busy@basic-flip-c:

    - fi-kbl-guc:         NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
    - fi-bwr-2160:        NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-elk-e7500:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-ilk-650:         NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-byt-j1900:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-byt-n2820:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: NOTRUN -> DMESG-WARN [fdo#103841]

* igt@kms_chamelium@dp-edid-read:
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] +56

* igt@kms_chamelium@dp-hpd-fast:
- fi-ilk-650: NOTRUN -> SKIP [fdo#109271] +69

* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62
- fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] +52

* igt@kms_chamelium@vga-edid-read:
- fi-cfl-8700k: NOTRUN -> SKIP [fdo#109271] +45
- fi-hsw-4770r: NOTRUN -> SKIP [fdo#109271] +45

* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: NOTRUN -> SKIP [fdo#109271] +45

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-whl-u: NOTRUN -> FAIL [fdo#103375] +3
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* igt@kms_psr@cursor_plane_move:
- fi-whl-u: NOTRUN -> FAIL [fdo#107383] +3

* igt@runner@aborted:
- fi-kbl-7500u: NOTRUN -> FAIL [fdo#103841]
- fi-bxt-dsi: NOTRUN -> FAIL [fdo#109516]

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109516]: https://bugs.freedesktop.org/show_bug.cgi?id=109516
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235

Participating hosts (9 -> 33)
------------------------------

Additional (25): fi-skl-6770hq fi-bdw-gvtdvm fi-apl-guc fi-snb-2520m fi-pnv-d510 fi-byt-n2820 fi-skl-6600u fi-hsw-4770r fi-bxt-dsi fi-bsw-n3050 fi-byt-j1900 fi-bwr-2160 fi-ilk-650 fi-kbl-7500u fi-hsw-4770 fi-ivb-3770 fi-elk-e7500 fi-skl-6700k2 fi-skl-gvtdvm fi-cfl-8700k fi-cfl-guc fi-kbl-guc fi-whl-u fi-kbl-x1275 fi-skl-iommu
Missing (1): fi-kbl-soraka

Build changes
-------------

* Linux: CI_DRM_5810 -> Patchwork_12592

CI_DRM_5810: 5ab8acfb062b61cb361308064c36052fe5f445aa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4902: 3d325bb211d8cd84c6862c9945185a937395cb44 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12592: 5f1b3154b3bca38bd0ab9eaebc68758a6e81c62d @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

5f1b3154b3bc drm/i915: Associate ACPI connector nodes with connector entries d13c09c2d924 drm: Add fwnode member to the struct drm_connector

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12592/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✗ Fi.CI.IGT: failure for drm: connector firmware nodes

In reply to Heikki Krogerus
== Series Details ==

== Series Details ==

Series: drm: connector firmware nodes
URL : https://patchwork.freedesktop.org/series/58531/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5810_full -> Patchwork_12592_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12592_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12592_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_12592_full:

### IGT changes ###

#### Possible regressions ####

* igt@perf_pmu@idle-no-semaphores-bcs0:
- shard-iclb: PASS -> INCOMPLETE

Known issues
------------

Here are the changes found in Patchwork_12592_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-clear:
- shard-snb: NOTRUN -> INCOMPLETE [fdo#105411]

* igt@gem_ctx_param@invalid-param-get:
- shard-skl: NOTRUN -> FAIL [fdo#109559]

* igt@gem_ctx_param@set-priority-not-supported:
- shard-iclb: NOTRUN -> SKIP [fdo#109314]

* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> SKIP [fdo#109313]

* igt@gem_exec_parallel@bsd1:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +126

* igt@gem_exec_parse@basic-rejected:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +1

* igt@gem_exec_suspend@basic-s3:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]

* igt@gem_mocs_settings@mocs-settings-bsd1:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +14

* igt@gem_mocs_settings@mocs-settings-dirty-render:
- shard-iclb: NOTRUN -> SKIP [fdo#110206]

* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-iclb: PASS -> INCOMPLETE [fdo#109801]

* igt@gem_pread@stolen-uncached:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +107

* igt@gem_softpin@evict-snoop:
- shard-iclb: NOTRUN -> SKIP [fdo#109312]

* igt@gem_stolen@stolen-clear:
- shard-iclb: NOTRUN -> SKIP [fdo#109277] +1

* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: PASS -> FAIL [fdo#108686]

* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +67

* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +11

* igt@kms_busy@basic-flip-f:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +4

* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#110222]

* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#110222] +3

* igt@kms_busy@extended-modeset-hang-oldfb-render-e:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6

* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#110222] +1

* igt@kms_busy@extended-pageflip-hang-oldfb-render-e:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +4

* igt@kms_busy@extended-pageflip-hang-oldfb-render-f:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +7

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#110222] +1

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#110222]

* igt@kms_chamelium@hdmi-cmp-nv61:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +4

* igt@kms_color@pipe-b-degamma:
- shard-iclb: NOTRUN -> FAIL [fdo#104782]

* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> FAIL [fdo#108597] / [fdo#108739]

* igt@kms_content_protection@legacy:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +103

* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: NOTRUN -> FAIL [fdo#103232] +1

* igt@kms_fbcon_fbt@psr-suspend:
- shard-iclb: NOTRUN -> FAIL [fdo#103833]

* igt@kms_flip@2x-flip-vs-rmfb-interruptible:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +8

* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-skl: PASS -> FAIL [fdo#100368]

* igt@kms_force_connector_basic@prune-stale-modes:
- shard-iclb: NOTRUN -> SKIP [fdo#109285]

* igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +17

* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#103167] +7

* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-iclb: PASS -> FAIL [fdo#105682] / [fdo#108040]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: NOTRUN -> FAIL [fdo#103167]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +80

* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-render:
- shard-iclb: PASS -> FAIL [fdo#105682] / [fdo#109247] +1

* igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
- shard-skl: NOTRUN -> FAIL [fdo#105683]

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-iclb: PASS -> FAIL [fdo#109247] +22

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
- shard-iclb: NOTRUN -> FAIL [fdo#109247] +5

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-f:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +10

* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]

* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: PASS -> FAIL [fdo#108145]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] +1

* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-glk: NOTRUN -> FAIL [fdo#108145] +1
- shard-apl: NOTRUN -> FAIL [fdo#108145] +1

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +2

* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: NOTRUN -> SKIP [fdo#109441]

* igt@kms_psr@sprite_mmap_cpu:
- shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +2

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: NOTRUN -> FAIL [fdo#109016]

* igt@kms_setmode@basic:
- shard-skl: NOTRUN -> FAIL [fdo#99912]
- shard-kbl: PASS -> FAIL [fdo#99912]

* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> FAIL [fdo#100047]

* igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
- shard-apl: PASS -> FAIL [fdo#104894] +1

* igt@perf@blocking:
- shard-iclb: PASS -> FAIL [fdo#108587]

* igt@prime_nv_api@i915_nv_double_import:
- shard-iclb: NOTRUN -> SKIP [fdo#109291] +1

* igt@prime_vgem@fence-read-hang:
- shard-iclb: NOTRUN -> SKIP [fdo#109295]

* igt@v3d_get_bo_offset@create-get-offsets:
- shard-iclb: NOTRUN -> SKIP [fdo#109315]

#### Possible fixes ####

* igt@gem_linear_blits@interruptible:
- shard-iclb: TIMEOUT [fdo#109673] -> PASS

* igt@kms_color@pipe-b-ctm-negative:
- shard-skl: FAIL [fdo#107361] -> PASS

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-iclb: FAIL [fdo#103167] -> PASS +6

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite:
- shard-iclb: FAIL [fdo#109247] -> PASS +38

* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
- shard-iclb: FAIL [fdo#105682] / [fdo#109247] -> PASS

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: FAIL [fdo#107815] / [fdo#108145] -> PASS

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS +1

* igt@kms_psr@sprite_mmap_gtt:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +5

* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683
[fdo#107361]: https://bugs.freedesktop.org/show_bug.cgi?id=107361
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108587]: https://bugs.freedesktop.org/show_bug.cgi?id=108587
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109559]: https://bugs.freedesktop.org/show_bug.cgi?id=109559
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#109801]: https://bugs.freedesktop.org/show_bug.cgi?id=109801
[fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (10 -> 9)
------------------------------

Missing (1): shard-hsw

Build changes
-------------

* Linux: CI_DRM_5810 -> Patchwork_12592

CI_DRM_5810: 5ab8acfb062b61cb361308064c36052fe5f445aa @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4902: 3d325bb211d8cd84c6862c9945185a937395cb44 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12592: 5f1b3154b3bca38bd0ab9eaebc68758a6e81c62d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12592/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Re: ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

Quoted 28 lines · Patchwork

== Series Details ==

Series: drm: connector firmware nodes
URL : https://patchwork.freedesktop.org/series/58531/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5810_full -> Patchwork_12592_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12592_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12592_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Quoted 8 lines

Here are the unknown changes that may have been introduced in Patchwork_12592_full:

### IGT changes ###

#### Possible regressions ####

* igt@perf_pmu@idle-no-semaphores-bcs0:
- shard-iclb: PASS -> INCOMPLETE

I have not idea what this is about? Is there something I need to do?

thanks,

Signature · 5 lines
heikki
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

Re: ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

Quoted 44 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Heikki Krogerus
Sent: tiistai 26. maaliskuuta 2019 10.32
To: [email protected]
Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

Quoted 11 lines · Patchwork

== Series Details ==

Series: drm: connector firmware nodes
URL : https://patchwork.freedesktop.org/series/58531/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5810_full -> Patchwork_12592_full
====================================================

Quoted 6 lines

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12592_full absolutely need to

be

Quoted 8 lines

verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12592_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Quoted 4 lines

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in

Patchwork_12592_full:

Quoted 3 lines

### IGT changes ###

Quoted 7 lines
Quoted 4 lines

#### Possible regressions ####

* igt@perf_pmu@idle-no-semaphores-bcs0:
- shard-iclb: PASS -> INCOMPLETE

I have not idea what this is about? Is there something I need to do?

Do you see from logs if relevant to your patche(s) ? If not read above. But also copying here:

Quoted 6 lines
Quoted 3 lines

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12592_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Quoted 8 lines

thanks,

--
heikki
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

Re: ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

Hi Jani,

Quoted 42 lines · Jani
Quoted 42 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Heikki Krogerus
Sent: tiistai 26. maaliskuuta 2019 10.32
To: [email protected]
Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

Quoted 11 lines · Patchwork

== Series Details ==

Series: drm: connector firmware nodes
URL : https://patchwork.freedesktop.org/series/58531/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5810_full -> Patchwork_12592_full
====================================================

Quoted 6 lines

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12592_full absolutely need to

be

Quoted 8 lines

verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12592_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Quoted 4 lines

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in

Patchwork_12592_full:

Quoted 3 lines

### IGT changes ###

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines

#### Possible regressions ####

* igt@perf_pmu@idle-no-semaphores-bcs0:
- shard-iclb: PASS -> INCOMPLETE

I have not idea what this is about? Is there something I need to do?

Do you see from logs if relevant to your patche(s) ?

Sorry, but I can't really say, as I don't know how to interpret the logs. I don't understand what that test is doing.

I'm assuming this log shows the failure:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12592/shard-iclb8/run7.log

The failure happens when running test (I'm guessing):
"[30/82] (859s left) gem_tiled_swapping (non-threaded)"

In the log there is a line that says:
"FATAL: Unable to delete script file /tmp/jenkins7657231043286309557.sh"

That certainly does not sound like anything that these patches would affect, but since I really have no idea what the test is doing, I can't really be sure.

thanks,

Signature · 5 lines
heikki
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

Re: ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

Quoted 63 lines · Heikki Krogerus

Hi Jani,

Quoted 42 lines · Jani
Quoted 42 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Heikki Krogerus
Sent: tiistai 26. maaliskuuta 2019 10.32
To: [email protected]
Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

Quoted 11 lines · Patchwork

== Series Details ==

Series: drm: connector firmware nodes
URL : https://patchwork.freedesktop.org/series/58531/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5810_full -> Patchwork_12592_full
====================================================

Quoted 6 lines

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12592_full absolutely need to

be

Quoted 8 lines

verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12592_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Quoted 4 lines

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in

Patchwork_12592_full:

Quoted 3 lines

### IGT changes ###

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines

#### Possible regressions ####

* igt@perf_pmu@idle-no-semaphores-bcs0:
- shard-iclb: PASS -> INCOMPLETE

I have not idea what this is about? Is there something I need to do?

Do you see from logs if relevant to your patche(s) ?

Sorry, but I can't really say, as I don't know how to interpret the logs. I don't understand what that test is doing.

I'm assuming this log shows the failure:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12592/shard-iclb8/run7.log

The failure happens when running test (I'm guessing):
"[30/82] (859s left) gem_tiled_swapping (non-threaded)"

Quoted 6 lines

In the log there is a line that says:
"FATAL: Unable to delete script file /tmp/jenkins7657231043286309557.sh"

That certainly does not sound like anything that these patches would affect, but since I really have no idea what the test is doing, I can't really be sure.

gem_tiled_swapping caused OOM killer to trigger which first killed the test, then killed java, and then CI put the blame on igt@perf_pmu@idle-no-semaphores-bcs0 which AFAICS did not even get to run.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx