Skip to contentSkip to conversation

clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

PATCH In review Nathan Chancellor 5 participants 14 messages Mar 27, 2019 – Apr 12, 2019 Clocksource, clockevent drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start static because its prototype was not defined in a header. Unfortunately, this causes a build warning on multi_v7_defconfig because this function is not used anywhere in this translation unit:

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should have happened.

Fixes 592ea6bd1fad ("clocksource: timer-ti-dm: Make unexported functions static")
Fixes 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static")

---

My apologies if this has already been sent, I didn't see anything in tip or on LKML.

 drivers/clocksource/timer-ti-dm.c | 28 ----------------------------
 1 file changed, 28 deletions(-)
drivers/clocksource/timer-ti-dm.c +0 -28
index 3352da6ed61f..ee8ec5a8cb16 100644
@@ -585,34 +585,6 @@ static int omap_dm_timer_set_load(struct omap_dm_timer *timer, int autoreload,
 	return 0;
 }
 
-/* Optimized set_load which removes costly spin wait in timer_start */
-static int omap_dm_timer_set_load_start(struct omap_dm_timer *timer,
-					int autoreload, unsigned int load)
-{
-	u32 l;
-
-	if (unlikely(!timer))
-		return -EINVAL;
-
-	omap_dm_timer_enable(timer);
-
-	l = omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
-	if (autoreload) {
-		l |= OMAP_TIMER_CTRL_AR;
-		omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
-	} else {
-		l &= ~OMAP_TIMER_CTRL_AR;
-	}
-	l |= OMAP_TIMER_CTRL_ST;
-
-	__omap_dm_timer_load_start(timer, l, load, timer->posted);
-
-	/* Save the context */
-	timer->context.tclr = l;
-	timer->context.tldr = load;
-	timer->context.tcrr = load;
-	return 0;
-}
 static int omap_dm_timer_set_match(struct omap_dm_timer *timer, int enable,
 				   unsigned int match)
 {
Signature · 1 line
2.21.0
#1 lore raw

Hello Nathan,

Quoted 6 lines · Nathan Chancellor

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start static because its prototype was not defined in a header. Unfortunately, this causes a build warning on multi_v7_defconfig because this function is not used anywhere in this translation unit:

Quoted 8 lines

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should have happened.

Alternatively you might want to look at "clocksource: timer-ti-dm: Add event capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of function being removed here). It is a part of an attempt to add event capture for OMAP. Of course I would like this functionality to be implemented, but as I do not have a time to continue, I cannot really object removing this function.

Just in case you'd be interested in finishing this task ;-)

ladis

Quoted 49 lines
Fixes 592ea6bd1fad ("clocksource: timer-ti-dm: Make unexported functions static")
Fixes 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static")

---

My apologies if this has already been sent, I didn't see anything in tip or on LKML.

 drivers/clocksource/timer-ti-dm.c | 28 ----------------------------
 1 file changed, 28 deletions(-)
drivers/clocksource/timer-ti-dm.c +0 -28
index 3352da6ed61f..ee8ec5a8cb16 100644
@@ -585,34 +585,6 @@ static int omap_dm_timer_set_load(struct omap_dm_timer *timer, int autoreload,
 	return 0;
 }
 
-/* Optimized set_load which removes costly spin wait in timer_start */
-static int omap_dm_timer_set_load_start(struct omap_dm_timer *timer,
-					int autoreload, unsigned int load)
-{
-	u32 l;
-
-	if (unlikely(!timer))
-		return -EINVAL;
-
-	omap_dm_timer_enable(timer);
-
-	l = omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
-	if (autoreload) {
-		l |= OMAP_TIMER_CTRL_AR;
-		omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
-	} else {
-		l &= ~OMAP_TIMER_CTRL_AR;
-	}
-	l |= OMAP_TIMER_CTRL_ST;
-
-	__omap_dm_timer_load_start(timer, l, load, timer->posted);
-
-	/* Save the context */
-	timer->context.tclr = l;
-	timer->context.tldr = load;
-	timer->context.tcrr = load;
-	return 0;
-}
 static int omap_dm_timer_set_match(struct omap_dm_timer *timer, int enable,
 
#2 lore raw
Quoted 18 lines · Ladislav Michl

Hello Nathan,

Quoted 6 lines · Nathan Chancellor

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start static because its prototype was not defined in a header. Unfortunately, this causes a build warning on multi_v7_defconfig because this function is not used anywhere in this translation unit:

Quoted 8 lines

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should have happened.

Quoted 8 lines

Alternatively you might want to look at "clocksource: timer-ti-dm: Add event capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of function being removed here). It is a part of an attempt to add event capture for OMAP. Of course I would like this functionality to be implemented, but as I do not have a time to continue, I cannot really object removing this function.

Just in case you'd be interested in finishing this task ;-)

Well seems like no other takers :) We can always find the missing function in git history when needed, so I suggest we apply this.

Adding Keerthy to Cc as he just posted a similar patch.

Regards,

Tony

#3 lore raw
Quoted 26 lines · Tony Lindgren
Quoted 25 lines · Ladislav Michl

Hello Nathan,

Quoted 6 lines · Nathan Chancellor

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start static because its prototype was not defined in a header. Unfortunately, this causes a build warning on multi_v7_defconfig because this function is not used anywhere in this translation unit:

Quoted 8 lines

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should have happened.

Alternatively you might want to look at "clocksource: timer-ti-dm: Add event capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of function being removed here). It is a part of an attempt to add event capture for OMAP. Of course I would like this functionality to be implemented, but as I do not have a time to continue, I cannot really object removing this function.

Quoted 6 lines
Quoted 1 line

Just in case you'd be interested in finishing this task ;-)

Well seems like no other takers :) We can always find the missing function in git history when needed, so I suggest we apply this.

Adding Keerthy to Cc as he just posted a similar patch.

I posted the duplicate. Thanks for looping in.

Quoted 5 lines

Regards,

Tony

#4 lore raw
In reply to Tony Lindgren

Hi Tony,

can you ask for an acked-by before pulling a patch in your tree?

Quoted 37 lines · Tony Lindgren
Quoted 18 lines · Ladislav Michl

Hello Nathan,

Quoted 6 lines · Nathan Chancellor

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start static because its prototype was not defined in a header. Unfortunately, this causes a build warning on multi_v7_defconfig because this function is not used anywhere in this translation unit:

Quoted 8 lines

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should have happened.

Quoted 8 lines

Alternatively you might want to look at "clocksource: timer-ti-dm: Add event capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of function being removed here). It is a part of an attempt to add event capture for OMAP. Of course I would like this functionality to be implemented, but as I do not have a time to continue, I cannot really object removing this function.

Just in case you'd be interested in finishing this task ;-)

Well seems like no other takers :) We can always find the missing function in git history when needed, so I suggest we apply this.

Adding Keerthy to Cc as he just posted a similar patch.

Regards,

Tony

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Acked-by
#5 lore raw

Hi,

Quoted 1 line · Daniel Lezcano

can you ask for an acked-by before pulling a patch in your tree?

I certainly do ask and wait for acks where possible :)

Note that I have not applied this patch. I just added Keerthy to Cc on this thread so maybe you misread the message earlier. My comment "seems like no other takers" was for Ladislav regarding somebody picking up his earlier work, not for picking up this patch :)

In any case, I've been waiting for you guys to pick up the patch, here's my ack if you're waiting for it:

Quoted 47 lines · Tony Lindgren
Quoted 37 lines · Ladislav Michl
Quoted 18 lines

Hello Nathan,

Quoted 6 lines · Nathan Chancellor

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start static because its prototype was not defined in a header. Unfortunately, this causes a build warning on multi_v7_defconfig because this function is not used anywhere in this translation unit:

Quoted 8 lines

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should have happened.

Quoted 8 lines

Alternatively you might want to look at "clocksource: timer-ti-dm: Add event capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of function being removed here). It is a part of an attempt to add event capture for OMAP. Of course I would like this functionality to be implemented, but as I do not have a time to continue, I cannot really object removing this function.

Just in case you'd be interested in finishing this task ;-)

Well seems like no other takers :) We can always find the missing function in git history when needed, so I suggest we apply this.

Adding Keerthy to Cc as he just posted a similar patch.

Regards,

Tony

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#6 lore raw
Quoted 6 lines · Tony Lindgren

Hi,

Quoted 1 line · Daniel Lezcano

can you ask for an acked-by before pulling a patch in your tree?

I certainly do ask and wait for acks where possible :)

Ok, I may have missed them.

Quoted 5 lines

Note that I have not applied this patch. I just added Keerthy to Cc on this thread so maybe you misread the message earlier. My comment "seems like no other takers" was for Ladislav regarding somebody picking up his earlier work, not for picking up this patch :)

Actually I was referring to the commit 592ea6bd1fad. Anyway as stated above I could have miss your call.

Quoted 4 lines

In any case, I've been waiting for you guys to pick up the patch, here's my ack if you're waiting for it:

The patch does not apply. Is it aligned with tip/timers/core ?

Quoted 47 lines
Quoted 47 lines · Tony Lindgren
Quoted 37 lines · Ladislav Michl
Quoted 18 lines

Hello Nathan,

Quoted 6 lines · Nathan Chancellor

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start static because its prototype was not defined in a header. Unfortunately, this causes a build warning on multi_v7_defconfig because this function is not used anywhere in this translation unit:

Quoted 8 lines

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should have happened.

Quoted 8 lines

Alternatively you might want to look at "clocksource: timer-ti-dm: Add event capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of function being removed here). It is a part of an attempt to add event capture for OMAP. Of course I would like this functionality to be implemented, but as I do not have a time to continue, I cannot really object removing this function.

Just in case you'd be interested in finishing this task ;-)

Well seems like no other takers :) We can always find the missing function in git history when needed, so I suggest we apply this.

Adding Keerthy to Cc as he just posted a similar patch.

Regards,

Tony

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#7 lore raw
Quoted 19 lines · Daniel Lezcano
Quoted 6 lines · Tony Lindgren

Hi,

Quoted 1 line · Daniel Lezcano

can you ask for an acked-by before pulling a patch in your tree?

I certainly do ask and wait for acks where possible :)

Ok, I may have missed them.

Quoted 5 lines

Note that I have not applied this patch. I just added Keerthy to Cc on this thread so maybe you misread the message earlier. My comment "seems like no other takers" was for Ladislav regarding somebody picking up his earlier work, not for picking up this patch :)

Actually I was referring to the commit 592ea6bd1fad. Anyway as stated above I could have miss your call.

Quoted 7 lines
Quoted 4 lines

In any case, I've been waiting for you guys to pick up the patch, here's my ack if you're waiting for it:

The patch does not apply. Is it aligned with tip/timers/core ?

The commit this fixes is in timers/urgent and it doesn't look like that has been backmerged into timers/core.

Nathan

Quoted 56 lines
Quoted 47 lines
Quoted 47 lines · Tony Lindgren
Quoted 37 lines · Ladislav Michl
Quoted 18 lines

Hello Nathan,

Quoted 6 lines · Nathan Chancellor

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start static because its prototype was not defined in a header. Unfortunately, this causes a build warning on multi_v7_defconfig because this function is not used anywhere in this translation unit:

Quoted 8 lines

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should have happened.

Quoted 8 lines

Alternatively you might want to look at "clocksource: timer-ti-dm: Add event capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of function being removed here). It is a part of an attempt to add event capture for OMAP. Of course I would like this functionality to be implemented, but as I do not have a time to continue, I cannot really object removing this function.

Just in case you'd be interested in finishing this task ;-)

Well seems like no other takers :) We can always find the missing function in git history when needed, so I suggest we apply this.

Adding Keerthy to Cc as he just posted a similar patch.

Regards,

Tony

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#8 lore raw
Quoted 23 lines · Nathan Chancellor
Quoted 22 lines · Daniel Lezcano
Quoted 6 lines · Tony Lindgren

Hi,

Quoted 1 line · Daniel Lezcano

can you ask for an acked-by before pulling a patch in your tree?

I certainly do ask and wait for acks where possible :)

Ok, I may have missed them.

Quoted 5 lines

Note that I have not applied this patch. I just added Keerthy to Cc on this thread so maybe you misread the message earlier. My comment "seems like no other takers" was for Ladislav regarding somebody picking up his earlier work, not for picking up this patch :)

Actually I was referring to the commit 592ea6bd1fad. Anyway as stated above I could have miss your call.

Quoted 3 lines

In any case, I've been waiting for you guys to pick up the patch, here's my ack if you're waiting for it:

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

The patch does not apply. Is it aligned with tip/timers/core ?

The commit this fixes is in timers/urgent and it doesn't look like that has been backmerged into timers/core.

I can see those fixes in timers/core:

Fixes 592ea6bd1fad ("clocksource: timer-ti-dm: Make unexported

functions static")

Fixes 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make

omap_dm_timer_set_load_start() static")

Are you referring to another fix?

Quoted 56 lines
Quoted 56 lines
Quoted 47 lines
Quoted 47 lines · Tony Lindgren
Quoted 37 lines · Ladislav Michl
Quoted 18 lines

Hello Nathan,

Quoted 6 lines · Nathan Chancellor

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start static because its prototype was not defined in a header. Unfortunately, this causes a build warning on multi_v7_defconfig because this function is not used anywhere in this translation unit:

Quoted 8 lines

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should have happened.

Quoted 8 lines

Alternatively you might want to look at "clocksource: timer-ti-dm: Add event capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of function being removed here). It is a part of an attempt to add event capture for OMAP. Of course I would like this functionality to be implemented, but as I do not have a time to continue, I cannot really object removing this function.

Just in case you'd be interested in finishing this task ;-)

Well seems like no other takers :) We can always find the missing function in git history when needed, so I suggest we apply this.

Adding Keerthy to Cc as he just posted a similar patch.

Regards,

Tony

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#9 lore raw

Hi,

Quoted 4 lines · Daniel Lezcano

I can see those fixes in timers/core:

Fixes 592ea6bd1fad ("clocksource: timer-ti-dm: Make unexported

functions static")

Hmm so this one was over a year ago related to the PWM series :)

Quoted 2 lines
Fixes 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make

omap_dm_timer_set_load_start() static")

Seems the warnings started with this one.

Regards,

Tony

#10 lore raw
In reply to Nathan Chancellor
Quoted 23 lines · Nathan Chancellor
Quoted 22 lines · Daniel Lezcano
Quoted 6 lines · Tony Lindgren

Hi,

Quoted 1 line · Daniel Lezcano

can you ask for an acked-by before pulling a patch in your tree?

I certainly do ask and wait for acks where possible :)

Ok, I may have missed them.

Quoted 5 lines

Note that I have not applied this patch. I just added Keerthy to Cc on this thread so maybe you misread the message earlier. My comment "seems like no other takers" was for Ladislav regarding somebody picking up his earlier work, not for picking up this patch :)

Actually I was referring to the commit 592ea6bd1fad. Anyway as stated above I could have miss your call.

Quoted 3 lines

In any case, I've been waiting for you guys to pick up the patch, here's my ack if you're waiting for it:

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

The patch does not apply. Is it aligned with tip/timers/core ?

The commit this fixes is in timers/urgent and it doesn't look like that has been backmerged into timers/core.

Anyway, probably simple to apply it directly to timers/urgent then. That's good I have other patches for the branch.

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#11 lore raw
In reply to Daniel Lezcano

Hi,

Quoted 10 lines · Daniel Lezcano
Quoted 6 lines · Tony Lindgren

Hi,

Quoted 1 line · Daniel Lezcano

can you ask for an acked-by before pulling a patch in your tree?

I certainly do ask and wait for acks where possible :)

Ok, I may have missed them.

Quoted 8 lines
Quoted 5 lines

Note that I have not applied this patch. I just added Keerthy to Cc on this thread so maybe you misread the message earlier. My comment "seems like no other takers" was for Ladislav regarding somebody picking up his earlier work, not for picking up this patch :)

Actually I was referring to the commit 592ea6bd1fad. Anyway as stated above I could have miss your call.

Hmm so commit 592ea6bd1fad was part of the PWM timer series that was posted several times from late 2017 to end of February 2018. I did not get any timer related acks or comments so I applied it together with the PWM timer changes.

I'm guessing you may have accidentally checked out some older deja-vu branch from about a year ago? Commit 592ea6bd1fad is not related to this fix.. :)

Regards,

Tony

#12 lore raw
Quoted 28 lines · Tony Lindgren

Hi,

Quoted 10 lines · Daniel Lezcano
Quoted 6 lines · Tony Lindgren

Hi,

Quoted 1 line · Daniel Lezcano

can you ask for an acked-by before pulling a patch in your tree?

I certainly do ask and wait for acks where possible :)

Ok, I may have missed them.

Quoted 8 lines
Quoted 5 lines

Note that I have not applied this patch. I just added Keerthy to Cc on this thread so maybe you misread the message earlier. My comment "seems like no other takers" was for Ladislav regarding somebody picking up his earlier work, not for picking up this patch :)

Actually I was referring to the commit 592ea6bd1fad. Anyway as stated above I could have miss your call.

Hmm so commit 592ea6bd1fad was part of the PWM timer series that was posted several times from late 2017 to end of February 2018. I did not get any timer related acks or comments so I applied it together with the PWM timer changes.

Quoted 4 lines

I'm guessing you may have accidentally checked out some older deja-vu branch from about a year ago? Commit 592ea6bd1fad is not related to this fix.. :)

Just for the record, I said this patch fixes 592ea6bd1fad because 592ea6bd1fad should have been marked this function as static, which would have exposed that this function was unused and it could have been removed at that time. I know it is a bit of a stretch for this commit (would be more appropriate for 008258d995a6 to have it) but that was my logic behind it. Not opposed to having it removed before committing.

Thanks,
Nathan

Quoted 6 lines

Regards,

Tony

#13 lore raw
Quoted 34 lines · Nathan Chancellor
Quoted 28 lines · Tony Lindgren

Hi,

Quoted 10 lines · Daniel Lezcano
Quoted 6 lines · Tony Lindgren

Hi,

Quoted 1 line · Daniel Lezcano

can you ask for an acked-by before pulling a patch in your tree?

I certainly do ask and wait for acks where possible :)

Ok, I may have missed them.

Quoted 8 lines
Quoted 5 lines

Note that I have not applied this patch. I just added Keerthy to Cc on this thread so maybe you misread the message earlier. My comment "seems like no other takers" was for Ladislav regarding somebody picking up his earlier work, not for picking up this patch :)

Actually I was referring to the commit 592ea6bd1fad. Anyway as stated above I could have miss your call.

Hmm so commit 592ea6bd1fad was part of the PWM timer series that was posted several times from late 2017 to end of February 2018. I did not get any timer related acks or comments so I applied it together with the PWM timer changes.

Quoted 4 lines

I'm guessing you may have accidentally checked out some older deja-vu branch from about a year ago? Commit 592ea6bd1fad is not related to this fix.. :)

Quoted 7 lines

Just for the record, I said this patch fixes 592ea6bd1fad because 592ea6bd1fad should have been marked this function as static, which would have exposed that this function was unused and it could have been removed at that time. I know it is a bit of a stretch for this commit (would be more appropriate for 008258d995a6 to have it) but that was my logic behind it. Not opposed to having it removed before committing.

Oh OK yes they should have all become static with the PWM series.

Regards,

Tony