Skip to contentSkip to conversation

xfs/065: make sure SCRATCH_DEV is unmount before mkfs

PATCH In review Zorro Lang 2 participants 2 messages Mar 27, 2019

lore
Share & tools
lore

Zorro Lang

author
#0 lore raw

PATCH 1/1 xfs/065: make sure SCRATCH_DEV is unmount before mkfs

Commit "8309b39a fstests: fix broken _require_scratch usage" did below change on xfs/065:

-_scratch_unmount 2>/dev/null
+_scratch_mkfs_xfs >> $seqres.full

It cause xfs/065 always fails now, as:
QA output created by 065
mkfs.xfs: /dev/sdb2 contains a mounted filesystem
...

So use _require_scratch, to make sure the SCRATCH_DEV is unmounted before mkfs.

---
 tests/xfs/065 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/065 +1 -0
index c0d1ee93..f09bd947 100755
@@ -50,6 +50,7 @@ _list_dir()
 # real QA test starts here
 _supported_fs xfs
 _supported_os Linux
+_require_scratch
 
 #
 # too much hassle to get output matching with quotas turned on
Signature · 1 line
2.17.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Zorro Lang

Commit "8309b39a fstests: fix broken _require_scratch usage" did below change on xfs/065:

-_scratch_unmount 2>/dev/null
+_scratch_mkfs_xfs >> $seqres.full

It cause xfs/065 always fails now, as:
QA output created by 065
mkfs.xfs: /dev/sdb2 contains a mounted filesystem
...

Quoted 4 lines

So use _require_scratch, to make sure the SCRATCH_DEV is unmounted before mkfs.

DOH, stupid editor... <grumble>

Sorry about that.

--D

Quoted 19 lines
---
 tests/xfs/065 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/065 +1 -0
index c0d1ee93..f09bd947 100755
@@ -50,6 +50,7 @@ _list_dir()
 # real QA test starts here
 _supported_fs xfs
 _supported_os Linux
+_require_scratch
 
 #
 # too much hassle to get output matching with quotas turned on
Signature · 1 line
2.17.2