Skip to contentSkip to conversation

straggling consolidation cleanups for v5.2

PATCH In review Paul E. McKenney 2 participants 5 messages Mar 26, 2019 – Mar 27, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover straggling consolidation cleanups for v5.2

Hello!

This series contains a few straggling RCU consolidation updates:

1. Update kprobes's documentation of obsolete RCU update functions.

2. Update netfilter comment from call_rcu_bh() to call_rcu()

Thanx, Paul

------------------------------------------------------------------------

 Documentation/kprobes.txt          |    6 +++---
 net/ipv4/netfilter/ipt_CLUSTERIP.c |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
#1 lore raw

PATCH 1/2 doc/kprobes: Update obsolete RCU update functions

The RCU flavors have been consolidated, so this commit replaces mentions of the now-obsolete synchronize_sched() function with synchronize_rcu().

Cc "Naveen N. Rao" <[email protected]>
Cc Anil S Keshavamurthy <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Masami Hiramatsu <[email protected]>
Cc Jonathan Corbet <[email protected]>
---
 Documentation/kprobes.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/kprobes.txt +3 -3
index 10f4499e677c..ee60e519438a 100644
@@ -243,10 +243,10 @@ Optimization
 ^^^^^^^^^^^^
 
 The Kprobe-optimizer doesn't insert the jump instruction immediately;
-rather, it calls synchronize_sched() for safety first, because it's
+rather, it calls synchronize_rcu() for safety first, because it's
 possible for a CPU to be interrupted in the middle of executing the
-optimized region [3]_.  As you know, synchronize_sched() can ensure
-that all interruptions that were active when synchronize_sched()
+optimized region [3]_.  As you know, synchronize_rcu() can ensure
+that all interruptions that were active when synchronize_rcu()
 was called are done, but only if CONFIG_PREEMPT=n.  So, this version
 of kprobe optimization supports only kernels with CONFIG_PREEMPT=n [4]_.
 
Signature · 1 line
2.17.1
Acked-by on v1 1/2
#2 lore raw

Re: [PATCH tip/core/rcu 1/2] doc/kprobes: Update obsolete RCU update functions

Quoted 2 lines · On Tue, 26 Mar 2019 16:00:49 -0700 "Paul E. McKenney" <[email protected]>…

The RCU flavors have been consolidated, so this commit replaces mentions of the now-obsolete synchronize_sched() function with synchronize_rcu().

Thank you for updating!

Quoted 33 lines
Cc "Naveen N. Rao" <[email protected]>
Cc Anil S Keshavamurthy <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Masami Hiramatsu <[email protected]>
Cc Jonathan Corbet <[email protected]>
---
 Documentation/kprobes.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/kprobes.txt +3 -3
index 10f4499e677c..ee60e519438a 100644
@@ -243,10 +243,10 @@ Optimization
 ^^^^^^^^^^^^
 
 The Kprobe-optimizer doesn't insert the jump instruction immediately;
-rather, it calls synchronize_sched() for safety first, because it's
+rather, it calls synchronize_rcu() for safety first, because it's
 possible for a CPU to be interrupted in the middle of executing the
-optimized region [3]_.  As you know, synchronize_sched() can ensure
-that all interruptions that were active when synchronize_sched()
+optimized region [3]_.  As you know, synchronize_rcu() can ensure
+that all interruptions that were active when synchronize_rcu()
 was called are done, but only if CONFIG_PREEMPT=n.  So, this version
 of kprobe optimization supports only kernels with CONFIG_PREEMPT=n [4]_.
 
Signature · 1 line
2.17.1
Signature · 1 line
Masami Hiramatsu <[email protected]>
author Applied
#3 lore raw

Re: [PATCH tip/core/rcu 1/2] doc/kprobes: Update obsolete RCU update functions

Quoted 9 lines · Masami Hiramatsu
Quoted 2 lines · On Tue, 26 Mar 2019 16:00:49 -0700 "Paul E. McKenney" <[email protected]>…

The RCU flavors have been consolidated, so this commit replaces mentions of the now-obsolete synchronize_sched() function with synchronize_rcu().

Thank you for updating!

Applied, thank you!

Thanx, Paul

Quoted 37 lines
Quoted 32 lines
Cc "Naveen N. Rao" <[email protected]>
Cc Anil S Keshavamurthy <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Masami Hiramatsu <[email protected]>
Cc Jonathan Corbet <[email protected]>
---
 Documentation/kprobes.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/kprobes.txt +3 -3
index 10f4499e677c..ee60e519438a 100644
@@ -243,10 +243,10 @@ Optimization
 ^^^^^^^^^^^^
 
 The Kprobe-optimizer doesn't insert the jump instruction immediately;
-rather, it calls synchronize_sched() for safety first, because it's
+rather, it calls synchronize_rcu() for safety first, because it's
 possible for a CPU to be interrupted in the middle of executing the
-optimized region [3]_.  As you know, synchronize_sched() can ensure
-that all interruptions that were active when synchronize_sched()
+optimized region [3]_.  As you know, synchronize_rcu() can ensure
+that all interruptions that were active when synchronize_rcu()
 was called are done, but only if CONFIG_PREEMPT=n.  So, this version
 of kprobe optimization supports only kernels with CONFIG_PREEMPT=n [4]_.
 
Signature · 1 line
2.17.1
Signature · 1 line
Masami Hiramatsu <[email protected]>
#4 lore raw

PATCH 2/2 net/ipv4/netfilter: Update comment from call_rcu_bh() to call_rcu()

In reply to Paul E. McKenney

The RCU flavors have been consolidated, so this commit replaces a comment's mention of call_rcu_bh() with call_rcu().

Cc Pablo Neira Ayuso <[email protected]>
Cc Florian Westphal <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Alexey Kuznetsov <[email protected]>
Cc Hideaki YOSHIFUJI <[email protected]>
---
 net/ipv4/netfilter/ipt_CLUSTERIP.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/netfilter/ipt_CLUSTERIP.c +1 -1
index 835d50b279f5..a2a88ab07f7b 100644
@@ -56,7 +56,7 @@ struct clusterip_config {
 #endif
 	enum clusterip_hashmode hash_mode;	/* which hashing mode */
 	u_int32_t hash_initval;			/* hash initialization */
-	struct rcu_head rcu;			/* for call_rcu_bh */
+	struct rcu_head rcu;			/* for call_rcu */
 	struct net *net;			/* netns for pernet list */
 	char ifname[IFNAMSIZ];			/* device ifname */
 };
Signature · 1 line
2.17.1