Skip to contentSkip to conversation

package/mtd: backport patch to remove errors for devices without ecc support

PATCH New Thomas De Schampheleire 2 participants 3 messages Mar 27, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mtd: backport patch to remove errors for devices without ecc support

From: Thomas De Schampheleire <[email protected]>

Since the introduction of mtd-utils 2.0.2, following error can appear on e.g. flash_erase calls:

libmtd: error!: ECCGETLAYOUT ioctl request failed
error 122 (Operation not supported)

The error should only be printed if there was an actual error in the ECCGETLAYOUT ioctl call, not when the ioctl is not supported.

Backport an upstream patch that fixes this issue.

---
 ...nt-an-error-message-for-devices-with.patch | 43 +++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 package/mtd/0002-libmtd-don-t-print-an-error-message-for-devices-with.patch
package/mtd/0002-libmtd-don-t-print-an-error-message-for-devices-with.patch new file +43 -0
new file mode 100644
index 0000000000..55de2bf0a8
@@ -0,0 +1,43 @@
+From a63a209d8ee8f21722a3b07d01d904bca5dbbc31 Mon Sep 17 00:00:00 2001
+From: David Oberhollenzer <[email protected]>
+Date: Wed, 12 Sep 2018 09:40:34 +0200
+Subject: [PATCH] libmtd: don't print an error message for devices without ecc
+ support
+
+The libmtd library tries to obtain the available OOB size via the sysfs
+with a fallback to the ECCGETLAYOUT ioctl. For some devices (e.g. plat-ram),
+the fallback path is always taken and prints an error message to stderr
+since the ioctl fails.
+
+This patch fixes the fallback path by suppressing the error message if
+errno is set to EOPNOTSUPP (i.e. the device simply doesn't support that).
+
+Fixes: a10353584f93 ("libmtd: Add support to access OOB available size")
+Reported-by: Chris Packham <[email protected]>
+Reviewed-by: Xiaolei Li <[email protected]>
+Tested-by: Chris Packham <[email protected]>
+Signed-off-by: David Oberhollenzer <[email protected]>
+[For inclusion in Buildroot:]
+Signed-off-by: Thomas De Schampheleire <[email protected]>
+
+
+---
+ lib/libmtd_legacy.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/lib/libmtd_legacy.c b/lib/libmtd_legacy.c
+index 97fef04..2b7f65f 100644
+--- a/lib/libmtd_legacy.c
++++ b/lib/libmtd_legacy.c
+@@ -235,6 +235,8 @@ int legacy_get_mtd_oobavail(const char *node)
+ 
+ 	ret = ioctl(fd, ECCGETLAYOUT, &usrlay);
+ 	if (ret < 0) {
++		if (errno == EOPNOTSUPP)
++			goto out_close;
+ 		sys_errmsg("ECCGETLAYOUT ioctl request failed");
+ 		goto out_close;
+ 	}
+-- 
+2.19.2
+
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 package/mtd: backport patch to remove errors for devices without ecc support

Hi Thomas,

Quoted 5 lines · Thomas De Schampheleire

From: Thomas De Schampheleire <[email protected]>

Since the introduction of mtd-utils 2.0.2, following error can appear on e.g. flash_erase calls:

Quoted 7 lines

libmtd: error!: ECCGETLAYOUT ioctl request failed
error 122 (Operation not supported)

The error should only be printed if there was an actual error in the ECCGETLAYOUT ioctl call, not when the ioctl is not supported.

Backport an upstream patch that fixes this issue.

Why not bump to 2.1.0 instead?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 package/mtd: backport patch to remove errors for devices without ecc support

El mi?., 27 mar. 2019 a las 15:11, Baruch Siach (<[email protected]>) escribi?:

Quoted 12 lines

Hi Thomas,

Quoted 8 lines · Thomas De Schampheleire

From: Thomas De Schampheleire <[email protected]>

Since the introduction of mtd-utils 2.0.2, following error can appear on e.g. flash_erase calls:

libmtd: error!: ECCGETLAYOUT ioctl request failed
error 122 (Operation not supported)

Quoted 7 lines
Quoted 4 lines

The error should only be printed if there was an actual error in the ECCGETLAYOUT ioctl call, not when the ioctl is not supported.

Backport an upstream patch that fixes this issue.

Why not bump to 2.1.0 instead?

Ah, because at the time I wrote this patch, it was not yet released :-)

But yes, that would be the logical thing to do...

/Thomas