Skip to contentSkip to conversation

Staging: media: davinci_vpfe: Remove unused macros

PATCH In review Madhumitha Prabakaran 2 participants 3 messages Mar 27, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: media: davinci_vpfe: Remove unused macros

Remove unused macros from kernel tree.

---
 drivers/staging/media/davinci_vpfe/dm365_isif_regs.h | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/media/davinci_vpfe/dm365_isif_regs.h +0 -3
index 6695680817b9..368c8a83a985 100644
@@ -109,9 +109,6 @@
 #define FMTLNV					0x128
 #define FMTRLEN					0x12c
 #define FMTHCNT					0x130
-#define FMTAPTR_BASE				0x134
-/* Below macro for addresses FMTAPTR0 - FMTAPTR15 */
-#define FMTAPTR(i)			(FMTAPTR_BASE + (i * 4))
 #define FMTPGMVF0				0x174
 #define FMTPGMVF1				0x178
 #define FMTPGMAPU0				0x17c
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 1 line · Madhumitha Prabakaran

Remove unused macros from kernel tree.

That says shat you did, but why? What if someone wants to know this information in the future? Deleting unused hardware description macros isn't always a good thing to do, as sometimes that is the only way people can find documentation on the chips involved.

thanks,

greg k-h

#2 lore raw
Quoted 7 lines · Greg KH
Quoted 1 line · Madhumitha Prabakaran

Remove unused macros from kernel tree.

That says shat you did, but why? What if someone wants to know this information in the future? Deleting unused hardware description macros isn't always a good thing to do, as sometimes that is the only way people can find documentation on the chips involved.

I will drop this one

Thanks

Quoted 4 lines

thanks,

greg k-h