package/glm: bump to version 0.9.9.4
PATCH 1/1 package/glm: bump to version 0.9.9.4
- Disable tests as they are enabled by default since version 0.9.9.1:
https://github.com/g-truc/glm/commit/d307d390193f4027faec48ac79d7f74b2bec6e56
- Static and shared libraries are always built since version 0.9.9.1:
https://github.com/g-truc/glm/commit/a23dd2f800185a5e233534fed82fc5c2840fbe5c
So, disable them as GLM is header-only (it should be noted that upstream wants to keep those libraries as the commit to disable them has been reverted:
https://github.com/g-truc/glm/commit/ca8372490eb8742d402878c9e930b891225982e6
- Add hash for license file (now in manual.md#section0)
Fixes:
- http://autobuild.buildroot.org/results/3cf1fd3387bd4952470edcfcb93d44f58c9e7ff7
--- package/glm/glm.hash | 3 ++- package/glm/glm.mk | 10 ++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-)
package/glm/glm.hash +2 -1
@@ -1,2 +1,3 @@ # Locally calculated -sha256 a220e60f8711265595be3221e530d632d5823641ecd46a3a54bc174933bff14c glm-0.9.8.4.tar.gz +sha256 3a073eb8f3be07cee74481db0e1f78eda553b554941e405c863ab64de6a2e954 glm-0.9.9.4.tar.gz +sha256 337130631a714eeae017556cad101d5324c2961214120b6214741d3d43667086 manual.md
package/glm/glm.mk +8 -2
@@ -4,14 +4,20 @@ # ################################################################################ -GLM_VERSION = 0.9.8.4 +GLM_VERSION = 0.9.9.4 GLM_SITE = $(call github,g-truc,glm,$(GLM_VERSION)) GLM_LICENSE = MIT -GLM_LICENSE_FILES = copying.txt +GLM_LICENSE_FILES = manual.md # GLM is a header-only library, it only makes sense # to have it installed into the staging directory. GLM_INSTALL_STAGING = YES GLM_INSTALL_TARGET = NO +# Don't build libraries as GLM is header-only +GLM_CONF_OPTS = \ + -DGLM_TEST_ENABLE=OFF \ + -DBUILD_SHARED_LIBS=OFF \ + -DBUILD_STATIC_LIBS=OFF + $(eval $(cmake-package))
Signature · 1 line
2.14.1
Thomas Petazzoni
AppliedPATCH 1/1 package/glm: bump to version 0.9.9.4
Quoted 10 lines · On Wed, 27 Mar 2019 18:11:03 +0100 Fabrice Fontaine…
- Disable tests as they are enabled by default since version 0.9.9.1:
https://github.com/g-truc/glm/commit/d307d390193f4027faec48ac79d7f74b2bec6e56
- Static and shared libraries are always built since version 0.9.9.1:
https://github.com/g-truc/glm/commit/a23dd2f800185a5e233534fed82fc5c2840fbe5c
So, disable them as GLM is header-only (it should be noted that upstream wants to keep those libraries as the commit to disable them has been reverted:
https://github.com/g-truc/glm/commit/ca8372490eb8742d402878c9e930b891225982e6
- Add hash for license file (now in manual.md#section0)
Quoted 8 lines
Fixes:
- http://autobuild.buildroot.org/results/3cf1fd3387bd4952470edcfcb93d44f58c9e7ff7Signed-off-by Fabrice Fontaine <[email protected]>--- package/glm/glm.hash | 3 ++- package/glm/glm.mk | 10 ++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-)
Applied to master, thanks. To be honest, I still don't understand what is this library that they are building but not really using. Do you understand better what it is ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/glm: bump to version 0.9.9.4
Hi Thomas,
Le mer. 27 mars 2019 ? 20:10, Thomas Petazzoni
<[email protected]> a ?crit :
Quoted 23 lines
Quoted 10 lines · On Wed, 27 Mar 2019 18:11:03 +0100 Fabrice Fontaine…
- Disable tests as they are enabled by default since version 0.9.9.1:
https://github.com/g-truc/glm/commit/d307d390193f4027faec48ac79d7f74b2bec6e56
- Static and shared libraries are always built since version 0.9.9.1:
https://github.com/g-truc/glm/commit/a23dd2f800185a5e233534fed82fc5c2840fbe5c
So, disable them as GLM is header-only (it should be noted that upstream wants to keep those libraries as the commit to disable them has been reverted:
https://github.com/g-truc/glm/commit/ca8372490eb8742d402878c9e930b891225982e6
- Add hash for license file (now in manual.md#section0)Quoted 8 lines
Fixes:
- http://autobuild.buildroot.org/results/3cf1fd3387bd4952470edcfcb93d44f58c9e7ff7Signed-off-by Fabrice Fontaine <[email protected]>--- package/glm/glm.hash | 3 ++- package/glm/glm.mk | 10 ++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-)
Quoted 3 lines
Applied to master, thanks. To be honest, I still don't understand what is this library that they are building but not really using. Do you understand better what it is ?
I don't understand either, I asked upstream about it here:
https://github.com/g-truc/glm/pull/871
But I didn't get any answer.
Then, I sent a patch to remove those libraries that was merged but reverted a few hours later.
The only information that I found is the commit title on the commit before the revert: "Allow to browse GLM source"
(https://github.com/g-truc/glm/commit/5a5a0a88b010892f678a01bd39156d346bc5e3f0).
Quoted 8 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Best Regards,
Fabrice
PATCH 1/1 package/glm: bump to version 0.9.9.4
Quoted 30 lines · Fabrice Fontaine
Hi Thomas,
Le mer. 27 mars 2019 ? 20:10, Thomas Petazzoni
<[email protected]> a ?crit :Quoted 23 lines
Quoted 10 lines · On Wed, 27 Mar 2019 18:11:03 +0100 Fabrice Fontaine…
- Disable tests as they are enabled by default since version 0.9.9.1:
https://github.com/g-truc/glm/commit/d307d390193f4027faec48ac79d7f74b2bec6e56
- Static and shared libraries are always built since version 0.9.9.1:
https://github.com/g-truc/glm/commit/a23dd2f800185a5e233534fed82fc5c2840fbe5c
So, disable them as GLM is header-only (it should be noted that upstream wants to keep those libraries as the commit to disable them has been reverted:
https://github.com/g-truc/glm/commit/ca8372490eb8742d402878c9e930b891225982e6
- Add hash for license file (now in manual.md#section0)Quoted 8 lines
Fixes:
- http://autobuild.buildroot.org/results/3cf1fd3387bd4952470edcfcb93d44f58c9e7ff7Signed-off-by Fabrice Fontaine <[email protected]>--- package/glm/glm.hash | 3 ++- package/glm/glm.mk | 10 ++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-)Quoted 3 lines
Applied to master, thanks. To be honest, I still don't understand what is this library that they are building but not really using. Do you understand better what it is ?
Quoted 8 lines
I don't understand either, I asked upstream about it here:
https://github.com/g-truc/glm/pull/871
But I didn't get any answer.Then, I sent a patch to remove those libraries that was merged but reverted a few hours later.
The only information that I found is the commit title on the commit before the revert: "Allow to browse GLM source"
With such a commit message, I guess that the GLM maintainers use an IDE that
parses CMakeLists.txt. Removing the glm subdir implicitly removes everything from the IDE. It is included in the IDE through glm/detail/glm.cpp, or maybe through the source_group commands.
Regards,
Arnout
Quoted 17 lines
(https://github.cglm/detail/glm.cppom/g-truc/glm/commit/5a5a0a88b010892f678a01bd39156d346bc5e3f0).
Quoted 8 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.comBest Regards,
Fabrice
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot