Skip to contentSkip to conversation

media: wl128x: Fix some error handling in fmc_prepare()

PATCH New Dan Carpenter 1 participant 1 message Mar 28, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: wl128x: Fix some error handling in fmc_prepare()

The st_register() returns have changed over time, but these days it never returns -1. We should just be checking for any negative error codes.

---
 drivers/media/radio/wl128x/fmdrv_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/radio/wl128x/fmdrv_common.c +1 -1
index 1614809f7d35..c3b90f2ac93f 100644
@@ -1521,7 +1521,7 @@ int fmc_prepare(struct fmdev *fmdev)
 		}
 
 		ret = 0;
-	} else if (ret = -1) {
+	} else if (ret < 0) {
 		fmerr("st_register failed %d\n", ret);
 		return -EAGAIN;
 	}
Signature · 1 line
2.17.1