Skip to contentSkip to conversation

Staging: rtl8192u: Use BIT macro

PATCH New Madhumitha Prabakaran 1 participant 1 message Mar 28, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8192u: Use BIT macro

Use BIT macro, as kernel provides the macro for improving uniform and more readable way to define these constants.

Issue suggested by Coccinelle.

---
 drivers/staging/rtl8192u/r8180_93cx6.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/staging/rtl8192u/r8180_93cx6.c +12 -12
index 163daed789b4..f98bb11a66af 100644
@@ -125,21 +125,21 @@ int eprom_read(struct net_device *dev, u32 addr)
 
 	if (priv->epromtype == EPROM_93c56) {
 		addr_str[7] = addr & 1;
-		addr_str[6] = addr & (1 << 1);
-		addr_str[5] = addr & (1 << 2);
-		addr_str[4] = addr & (1 << 3);
-		addr_str[3] = addr & (1 << 4);
-		addr_str[2] = addr & (1 << 5);
-		addr_str[1] = addr & (1 << 6);
-		addr_str[0] = addr & (1 << 7);
+		addr_str[6] = addr & BIT(1);
+		addr_str[5] = addr & BIT(2);
+		addr_str[4] = addr & BIT(3);
+		addr_str[3] = addr & BIT(4);
+		addr_str[2] = addr & BIT(5);
+		addr_str[1] = addr & BIT(6);
+		addr_str[0] = addr & BIT(7);
 		addr_len = 8;
 	} else {
 		addr_str[5] = addr & 1;
-		addr_str[4] = addr & (1 << 1);
-		addr_str[3] = addr & (1 << 2);
-		addr_str[2] = addr & (1 << 3);
-		addr_str[1] = addr & (1 << 4);
-		addr_str[0] = addr & (1 << 5);
+		addr_str[4] = addr & BIT(1);
+		addr_str[3] = addr & BIT(2);
+		addr_str[2] = addr & BIT(3);
+		addr_str[1] = addr & BIT(4);
+		addr_str[0] = addr & BIT(5);
 		addr_len = 6;
 	}
 	eprom_cs(dev, 1);
Signature · 1 line
2.17.1