package/openldap: don't patch libtool
PATCH 1/1 package/openldap: don't patch libtool
openldap uses its own libtool, static build with atomic fails with our patches since February 6th 2019 on:
/bin/sh ../../libtool --mode=link /home/buildroot/autobuild/run/instance-0/output/host/bin/or1k-linux-gcc -static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -static -static -o idtest idtest.o liblber.la ../../libraries/liblutil/liblutil.a -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib -lssl -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib -lz -pthread -latomic -lcrypto -lz -pthread -latomic
/home/buildroot/autobuild/run/instance-0/output/host/bin/or1k-linux-gcc -static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -static -static -o etest etest.o -pthread -pthread ./.libs/liblber.a -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib ../../libraries/liblutil/liblutil.a -lssl -lcrypto -lz -pthread /home/buildroot/autobuild/run/instance-0/output/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/5.4.0/../../../../or1k-buildroot-linux-uclibc/lib//libatomic.so
To fix this error, set OPENLDAP_LIBTOOL_PATCH to NO
Fixes:
- http://autobuild.buildroot.org/results/ab4f85fd21cacfaef6b0b43a38da6a4a1d32ecb6
--- package/openldap/openldap.mk | 1 + 1 file changed, 1 insertion(+)
package/openldap/openldap.mk +1 -0
@@ -11,6 +11,7 @@ OPENLDAP_LICENSE = OpenLDAP Public License OPENLDAP_LICENSE_FILES = LICENSE OPENLDAP_INSTALL_STAGING = YES OPENLDAP_DEPENDENCIES = host-pkgconf +OPENLDAP_LIBTOOL_PATCH = NO ifeq ($(BR2_PACKAGE_OPENSSL),y) OPENLDAP_TLS = openssl
Signature · 1 line
2.14.1
PATCH 1/1 package/openldap: don't patch libtool
Hello Fabrice,
Quoted 8 lines · On Thu, 28 Mar 2019 18:29:37 +0100 Fabrice Fontaine…
openldap uses its own libtool, static build with atomic fails with our patches since February 6th 2019 on:
/bin/sh../../libtool --mode=link/home/buildroot/autobuild/run/instance-0/output/host/bin/or1k-linux-gcc-static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -static -static -o idtest idtest.o liblber.la ../../libraries/liblutil/liblutil.a -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib -lssl -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib -lz -pthread -latomic -lcrypto -lz -pthread -latomic
/home/buildroot/autobuild/run/instance-0/output/host/bin/or1k-linux-gcc-static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -static -static -o etest etest.o -pthread -pthread ./.libs/liblber.a -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib ../../libraries/liblutil/liblutil.a -lssl -lcrypto -lz -pthread/home/buildroot/autobuild/run/instance-0/output/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/5.4.0/../../../../or1k-buildroot-linux-uclibc/lib//libatomic.soTo fix this error, set
OPENLDAP_LIBTOOL_PATCHto NO
Do you understand why openldap is specifically affected ? I'm a bit worried about "randomly" disabling libtool patching.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/openldap: don't patch libtool
Hello Thomas,
Le jeu. 28 mars 2019 ? 18:54, Thomas Petazzoni
<[email protected]> a ?crit :
Quoted 9 lines
Hello Fabrice,
Quoted 3 lines · On Thu, 28 Mar 2019 18:29:37 +0100 Fabrice Fontaine…
openldap uses its own libtool, static build with atomic fails with our patches since February 6th 2019 on:
Quoted 8 lines
Quoted 5 lines
/bin/sh../../libtool --mode=link/home/buildroot/autobuild/run/instance-0/output/host/bin/or1k-linux-gcc-static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -static -static -o idtest idtest.o liblber.la ../../libraries/liblutil/liblutil.a -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib -lssl -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib -lz -pthread -latomic -lcrypto -lz -pthread -latomic
/home/buildroot/autobuild/run/instance-0/output/host/bin/or1k-linux-gcc-static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -static -static -o etest etest.o -pthread -pthread ./.libs/liblber.a -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib ../../libraries/liblutil/liblutil.a -lssl -lcrypto -lz -pthread/home/buildroot/autobuild/run/instance-0/output/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/5.4.0/../../../../or1k-buildroot-linux-uclibc/lib//libatomic.soTo fix this error, set
OPENLDAP_LIBTOOL_PATCHto NODo you understand why openldap is specifically affected ? I'm a bit worried about "randomly" disabling libtool patching.
Nope, I don't understand why this issue is only affecting openldap and I don't understand why the failures started on February 6th. There was no updates on openldap so perhaps there is a specific issue with some of the toolchains or with our libtool patches?
I'll take some time to investigate.
Quoted 6 lines
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Best Regards,
Fabrice
PATCH 1/1 package/openldap: don't patch libtool
Hello Thomas,
Le jeu. 28 mars 2019 ? 21:31, Fabrice Fontaine
<[email protected]> a ?crit :
Quoted 20 lines
Hello Thomas,
Le jeu. 28 mars 2019 ? 18:54, Thomas Petazzoni
<[email protected]> a ?crit :Quoted 15 lines
Hello Fabrice,
Quoted 8 lines · On Thu, 28 Mar 2019 18:29:37 +0100 Fabrice Fontaine…
openldap uses its own libtool, static build with atomic fails with our patches since February 6th 2019 on:
/bin/sh../../libtool --mode=link/home/buildroot/autobuild/run/instance-0/output/host/bin/or1k-linux-gcc-static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -static -static -o idtest idtest.o liblber.la ../../libraries/liblutil/liblutil.a -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib -lssl -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib -lz -pthread -latomic -lcrypto -lz -pthread -latomic
/home/buildroot/autobuild/run/instance-0/output/host/bin/or1k-linux-gcc-static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -static -static -o etest etest.o -pthread -pthread ./.libs/liblber.a -L/home/buildroot/autobuild/run/instance-0/output/host/bin/../or1k-buildroot-linux-uclibc/sysroot/usr/lib ../../libraries/liblutil/liblutil.a -lssl -lcrypto -lz -pthread/home/buildroot/autobuild/run/instance-0/output/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/5.4.0/../../../../or1k-buildroot-linux-uclibc/lib//libatomic.soTo fix this error, set
OPENLDAP_LIBTOOL_PATCHto NO
Quoted 7 lines
Quoted 2 lines
Do you understand why openldap is specifically affected ? I'm a bit worried about "randomly" disabling libtool patching.
Nope, I don't understand why this issue is only affecting openldap and I don't understand why the failures started on February 6th. There was no updates on openldap so perhaps there is a specific issue with some of the toolchains or with our libtool patches?
I'll take some time to investigate.
The issue is raised by this openldap specific patch (added in 2005) on ltmain.sh:
https://github.com/openldap/openldap/commit/7b6a088a2590fdad10286d10050b769e48554e13.
This patch adds a use_static_libs that is not managed by
https://git.buildroot.net/buildroot/tree/support/libtool/buildroot-libtool-v1.5.patch.
So, the issue can be fixed if I patch ltmain.sh to revert those changes. However, I suppose that this patch won't be upstreamable.
Quoted 10 lines
Quoted 7 lines
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.comBest Regards,
Fabrice
Best Regards,
Fabrice
PATCH 1/1 package/openldap: don't patch libtool
Hello,
Quoted 8 lines · On Fri, 29 Mar 2019 00:00:58 +0100 Fabrice Fontaine…
The issue is raised by this openldap specific patch (added in 2005) on
ltmain.sh:
https://github.com/openldap/openldap/commit/7b6a088a2590fdad10286d10050b769e48554e13.
This patch adds ause_static_libsthat is not managed by
https://git.buildroot.net/buildroot/tree/support/libtool/buildroot-libtool-v1.5.patch.So, the issue can be fixed if I patch
ltmain.shto revert those changes. However, I suppose that this patch won't be upstreamable.
Thanks for the research. I applied your alternate solution, which you proposed as v2. To be honest, I'm not sure which one was the best option, so I've decided pretty much arbitrarily.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com