v4l: add I / P frame min max QP definitions
Subsystems (2)
PATCH 1/1 v4l: add I / P frame min max QP definitions
Add following V4L2 QP parameters for H.264:
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP
These controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
--- drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 ++++++ 2 files changed, 10 insertions(+)
drivers/media/v4l2-core/v4l2-ctrls.c +4 -0
@@ -825,6 +825,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER :return "H264 Number of HC Layers" ;case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP :return "H264 Set QP Value for HC Layers" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;
include/uapi/linux/v4l2-controls.h +6 -0
@@ -533,6 +533,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type { };#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER (V4L2_CID_MPEG_BASE+381)#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
Signature · 1 line
2.20.1.495.gaa96b0ce6b-goog
PATCH v2 1/1 v4l: add I / P frame min max QP definitions
Add following V4L2 QP parameters for H.264:
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP
These controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
---
Changelog since v1:
- Add description in document.
.../media/uapi/v4l/extended-controls.rst | 16 ++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 ++++++ 3 files changed, 26 insertions(+)
Documentation/media/uapi/v4l/extended-controls.rst +16 -0
@@ -1214,6 +1214,22 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.
drivers/media/v4l2-core/v4l2-ctrls.c +4 -0
@@ -825,6 +825,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER :return "H264 Number of HC Layers" ;case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP :return "H264 Set QP Value for HC Layers" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;
include/uapi/linux/v4l2-controls.h +6 -0
@@ -533,6 +533,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type { };#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER (V4L2_CID_MPEG_BASE+381)#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
Signature · 1 line
2.20.1.495.gaa96b0ce6b-goog
Quoted 8 lines · Fish Lin
Add following V4L2 QP parameters for H.264:
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QPThese controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
How will this interact with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP?
Or are drivers supposed to have either V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP or these new controls? If so, then that should be documented.
Regards,
Hans
Quoted 71 lines
Signed-off-by Fish Lin <[email protected]>---
Changelog since v1:
- Add description in document..../media/uapi/v4l/extended-controls.rst | 16 ++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 ++++++ 3 files changed, 26 insertions(+)Documentation/media/uapi/v4l/extended-controls.rst +16
-0@@ -1214,6 +1214,22 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.drivers/media/v4l2-core/v4l2-ctrls.c +4
-0@@ -825,6 +825,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER :return "H264 Number of HC Layers" ;case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP :return "H264 Set QP Value for HC Layers" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;include/uapi/linux/v4l2-controls.h +6
-0@@ -533,6 +533,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type { };#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER (V4L2_CID_MPEG_BASE+381)#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
Hi Hans,
For I frame min QP, if global min QP is set, the QP choose algorithm should meet both of them, hence QP will >= max(V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP, V4L2_CID_MPEG_VIDEO_H264_MIN_QP).
And this is also the same to the P frame and max QP.
I can add some description to describe this behavior in the document.
Thanks,
Fish
Hans Verkuil <[email protected]> 於 2019年1月30日 週三 下午3:57寫道:
Quoted 92 lines · Fish Lin
Quoted 8 lines
Add following V4L2 QP parameters for H.264:
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QPThese controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
How will this interact with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP?
Or are drivers supposed to have either V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP or these new controls? If so, then that should be documented.
Regards,
Hans
Quoted 71 lines
Signed-off-by Fish Lin <[email protected]>---
Changelog since v1:
- Add description in document..../media/uapi/v4l/extended-controls.rst | 16 ++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 ++++++ 3 files changed, 26 insertions(+)Documentation/media/uapi/v4l/extended-controls.rst +16
-0@@ -1214,6 +1214,22 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.drivers/media/v4l2-core/v4l2-ctrls.c +4
-0@@ -825,6 +825,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER :return "H264 Number of HC Layers" ;case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP :return "H264 Set QP Value for HC Layers" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;include/uapi/linux/v4l2-controls.h +6
-0@@ -533,6 +533,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type { };#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER (V4L2_CID_MPEG_BASE+381)#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
Signature · 1 line
Fish Lin | Software Engineer | [email protected] | +886-921-925519
PATCH v3 1/1 v4l: add I / P frame min max QP definitions
In reply to Fish LinAdd following V4L2 QP parameters for H.264:
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP
These controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
---
Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.
Changelog since v1:
- Add description in document.
.../media/uapi/v4l/extended-controls.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)
Documentation/media/uapi/v4l/extended-controls.rst +24 -0
@@ -1214,6 +1214,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is set, the quantization parameter + should be chosen to meet both of the requirement. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is set, the quantization parameter + should be chosen to meet both of the requirement. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is set, the quantization parameter + should be chosen to meet both of the requirement. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is set, the quantization parameter + should be chosen to meet both of the requirement. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.
drivers/media/v4l2-core/v4l2-ctrls.c +4 -0
@@ -825,6 +825,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER :return "H264 Number of HC Layers" ;case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP :return "H264 Set QP Value for HC Layers" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;
include/uapi/linux/v4l2-controls.h +6 -0
@@ -533,6 +533,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type { };#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER (V4L2_CID_MPEG_BASE+381)#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
Signature · 1 line
2.20.1.495.gaa96b0ce6b-goog
Quoted 28 lines · Fish Lin
Add following V4L2 QP parameters for H.264:
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QPThese controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
Signed-off-by Fish Lin <[email protected]>---
Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.Changelog since v1:
- Add description in document..../media/uapi/v4l/extended-controls.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)Documentation/media/uapi/v4l/extended-controls.rst +0
-0
Documentation/media/uapi/v4l/extended-controls.rst enum v4l2_mpeg_video_h264_entropy_mode - · line 1220
Quoted 7 lines
Documentation/media/uapi/v4l/extended-controls.rst +4
-0@@ -1214,6 +1214,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is set, the quantization parameter
is set -> is also set
Documentation/media/uapi/v4l/extended-controls.rst enum v4l2_mpeg_video_h264_entropy_mode - · line 1221
Quoted 1 line
Documentation/media/uapi/v4l/extended-controls.rst +1
-0+ should be chosen to meet both of the requirement.
both of the requirement -> both requirements
Ditto for the other three controls below.
However, you might want to wait a little bit since I have this patch pending:
https://patchwork.linuxtv.org/patch/54388/
which will require a rebase of your patch anyway.
Regards,
Hans
Quoted 55 lines
Documentation/media/uapi/v4l/extended-controls.rst +19
-0+ +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is set, the quantization parameter + should be chosen to meet both of the requirement. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is set, the quantization parameter + should be chosen to meet both of the requirement. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is set, the quantization parameter + should be chosen to meet both of the requirement. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.drivers/media/v4l2-core/v4l2-ctrls.c +4
-0@@ -825,6 +825,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER :return "H264 Number of HC Layers" ;case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP :return "H264 Set QP Value for HC Layers" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;include/uapi/linux/v4l2-controls.h +6
-0@@ -533,6 +533,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type { };#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER (V4L2_CID_MPEG_BASE+381)#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
Got it, I'll submit another patch after your patch merged.
Thanks,
Fish
Hans Verkuil <[email protected]> 於 2019年2月8日 週五 下午5:58寫道:
Quoted 112 lines · Fish Lin
Quoted 28 lines
Add following V4L2 QP parameters for H.264:
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QPThese controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
Signed-off-by Fish Lin <[email protected]>---
Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.Changelog since v1:
- Add description in document..../media/uapi/v4l/extended-controls.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)Documentation/media/uapi/v4l/extended-controls.rst +0
-0Documentation/media/uapi/v4l/extended-controls.rst enum v4l2_mpeg_video_h264_entropy_mode - · line 1220
Quoted 7 lines
Documentation/media/uapi/v4l/extended-controls.rst +4
-0@@ -1214,6 +1214,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is set, the quantization parameteris set -> is also set
Documentation/media/uapi/v4l/extended-controls.rst enum v4l2_mpeg_video_h264_entropy_mode - · line 1221
Quoted 1 line
Documentation/media/uapi/v4l/extended-controls.rst +1
-0+ should be chosen to meet both of the requirement.both of the requirement -> both requirements
Ditto for the other three controls below.
However, you might want to wait a little bit since I have this patch pending:
https://patchwork.linuxtv.org/patch/54388/
which will require a rebase of your patch anyway.
Regards,
Hans
Quoted 55 lines
Documentation/media/uapi/v4l/extended-controls.rst +19
-0+ +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is set, the quantization parameter + should be chosen to meet both of the requirement. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is set, the quantization parameter + should be chosen to meet both of the requirement. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is set, the quantization parameter + should be chosen to meet both of the requirement. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.drivers/media/v4l2-core/v4l2-ctrls.c +4
-0@@ -825,6 +825,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER :return "H264 Number of HC Layers" ;case V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP :return "H264 Set QP Value for HC Layers" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;include/uapi/linux/v4l2-controls.h +6
-0@@ -533,6 +533,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type { };#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER (V4L2_CID_MPEG_BASE+381)#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
PATCH v4 1/1 Add following V4L2 QP parameters for H.264: * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP
In reply to Fish LinThese controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
---
Changelog since v3:
- Put document in ext-ctrls-codec.rst instead of extended-controls.rst (which was previous version).
Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.
Changelog since v1:
- Add description in document.
.../media/uapi/v4l/ext-ctrls-codec.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +24 -0
@@ -1048,6 +1048,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.
drivers/media/v4l2-core/v4l2-ctrls.c +4 -0
@@ -828,6 +828,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION :return "H264 Constrained Intra Pred" ;case V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET :return "H264 Chroma QP Index Offset" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;
include/uapi/linux/v4l2-controls.h +6 -0
@@ -535,6 +535,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type {#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382)#define V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION (V4L2_CID_MPEG_BASE+383)#define V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET (V4L2_CID_MPEG_BASE+384) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
Signature · 1 line
2.21.0.360.g471c308f928-goog
Re: [PATCH v4] Add following V4L2 QP parameters for H.264: * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP
This subject line is insanely long :-)
Please use a short subject line for v5 (i.e. "Add V4L2 QP parameters for H.264") and mention the actual parameters you are adding in the commit log.
Some more comments below:
Quoted 26 lines · Fish Lin
These controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
Signed-off-by Fish Lin <[email protected]>---
Changelog since v3:
- Put document inext-ctrls-codec.rstinstead ofextended-controls.rst(which was previous version).Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.Changelog since v1:
- Add description in document..../media/uapi/v4l/ext-ctrls-codec.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)Documentation/media/uapi/v4l/ext-ctrls-codec.rst +0
-0
Documentation/media/uapi/v4l/ext-ctrls-codec.rst enum v4l2_mpeg_video_h264_entropy_mode - · line 1052
Quoted 5 lines
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +2
-0@@ -1048,6 +1048,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 I frame, to limit I frame
H264 -> the H264
frame, to -> frame to
Same below.
Documentation/media/uapi/v4l/ext-ctrls-codec.rst enum v4l2_mpeg_video_h264_entropy_mode - · line 1053
Quoted 1 line
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +1
-0+ quality in a range. Valid range: from 0 to 51. If
in -> to
(you limit a value *to* a range, not 'in a range')
Same below.
Regards,
Hans
Quoted 57 lines
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +21
-0+ V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.drivers/media/v4l2-core/v4l2-ctrls.c +4
-0@@ -828,6 +828,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION :return "H264 Constrained Intra Pred" ;case V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET :return "H264 Chroma QP Index Offset" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;include/uapi/linux/v4l2-controls.h +6
-0@@ -535,6 +535,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type {#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382)#define V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION (V4L2_CID_MPEG_BASE+383)#define V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET (V4L2_CID_MPEG_BASE+384) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
Re: [PATCH v4] Add following V4L2 QP parameters for H.264: * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP
Got it, thanks!
Fish
Hans Verkuil <[email protected]> 於 2019年3月20日 週三 下午11:00寫道:
Quoted 116 lines
This subject line is insanely long :-)
Please use a short subject line for v5 (i.e. "Add V4L2 QP parameters for H.264") and mention the actual parameters you are adding in the commit log.
Some more comments below:
Quoted 26 lines · Fish Lin
These controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
Signed-off-by Fish Lin <[email protected]>---
Changelog since v3:
- Put document inext-ctrls-codec.rstinstead ofextended-controls.rst(which was previous version).Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.Changelog since v1:
- Add description in document..../media/uapi/v4l/ext-ctrls-codec.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)Documentation/media/uapi/v4l/ext-ctrls-codec.rst +0
-0Documentation/media/uapi/v4l/ext-ctrls-codec.rst enum v4l2_mpeg_video_h264_entropy_mode - · line 1052
Quoted 5 lines
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +2
-0@@ -1048,6 +1048,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 I frame, to limit I frameH264 -> the H264
frame, to -> frame toSame below.
Documentation/media/uapi/v4l/ext-ctrls-codec.rst enum v4l2_mpeg_video_h264_entropy_mode - · line 1053
Quoted 1 line
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +1
-0+ quality in a range. Valid range: from 0 to 51. Ifin -> to
(you limit a value *to* a range, not 'in a range')
Same below.
Regards,
Hans
Quoted 57 lines
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +21
-0+ V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.drivers/media/v4l2-core/v4l2-ctrls.c +4
-0@@ -828,6 +828,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION :return "H264 Constrained Intra Pred" ;case V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET :return "H264 Chroma QP Index Offset" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;include/uapi/linux/v4l2-controls.h +6
-0@@ -535,6 +535,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type {#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382)#define V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION (V4L2_CID_MPEG_BASE+383)#define V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET (V4L2_CID_MPEG_BASE+384) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
PATCH v5 1/1 v4l: add I / P frame min max QP definitions
In reply to Fish LinAdd following V4L2 QP parameters for H.264:
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP
These controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
---
Changelog since v4:
- Fix patch subject and send again.
Changelog since v3:
- Put document in ext-ctrls-codec.rst instead of extended-controls.rst (which was previous version).
Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.
Changelog since v1:
- Add description in document.
.../media/uapi/v4l/ext-ctrls-codec.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +24 -0
@@ -1048,6 +1048,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 I frame, to limit I frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for H264 P frame, to limit P frame + quality in a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.
drivers/media/v4l2-core/v4l2-ctrls.c +4 -0
@@ -828,6 +828,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION :return "H264 Constrained Intra Pred" ;case V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET :return "H264 Chroma QP Index Offset" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;
include/uapi/linux/v4l2-controls.h +6 -0
@@ -535,6 +535,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type {#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382)#define V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION (V4L2_CID_MPEG_BASE+383)#define V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET (V4L2_CID_MPEG_BASE+384) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
Signature · 1 line
2.21.0.360.g471c308f928-goog
PATCH v6 1/1 v4l: add I / P frame min max QP definitions
In reply to Fish LinAdd following V4L2 QP parameters for H.264:
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP
These controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
---
Changelog since v5:
- Adjust documentation wording.
Changelog since v4:
- Fix patch subject and send again.
Changelog since v3:
- Put document in ext-ctrls-codec.rst instead of extended-controls.rst (which was previous version).
Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.
Changelog since v1:
- Add description in document.
.../media/uapi/v4l/ext-ctrls-codec.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +24 -0
@@ -1048,6 +1048,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.
drivers/media/v4l2-core/v4l2-ctrls.c +4 -0
@@ -828,6 +828,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION :return "H264 Constrained Intra Pred" ;case V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET :return "H264 Chroma QP Index Offset" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;
include/uapi/linux/v4l2-controls.h +6 -0
@@ -535,6 +535,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type {#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382)#define V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION (V4L2_CID_MPEG_BASE+383)#define V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET (V4L2_CID_MPEG_BASE+384) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
--
2.21.0.225.g810b269d1ac-goog
Quoted 88 lines · Fish Lin
Add following V4L2 QP parameters for H.264:
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QPThese controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
Signed-off-by Fish Lin <[email protected]>---
Changelog since v5:
- Adjust documentation wording.Changelog since v4:
- Fix patch subject and send again.Changelog since v3:
- Put document inext-ctrls-codec.rstinstead ofextended-controls.rst(which was previous version).Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.Changelog since v1:
- Add description in document..../media/uapi/v4l/ext-ctrls-codec.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)Documentation/media/uapi/v4l/ext-ctrls-codec.rst +24
-0@@ -1048,6 +1048,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.drivers/media/v4l2-core/v4l2-ctrls.c +4
-0@@ -828,6 +828,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION :return "H264 Constrained Intra Pred" ;case V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET :return "H264 Chroma QP Index Offset" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;include/uapi/linux/v4l2-controls.h +0
-0
include/uapi/linux/v4l2-controls.h enum v4l2_mpeg_video_h264_hierarchical_coding_type { · line 539
Quoted 5 lines
include/uapi/linux/v4l2-controls.h +2
-0@@ -535,6 +535,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type {#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382)#define V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION (V4L2_CID_MPEG_BASE+383)#define V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET (V4L2_CID_MPEG_BASE+384) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390)
There is no need for a gap in numbering. Just start with +385.
Sorry for this, I missed that in the previous reviews. Everything else looks good to me, so if you post a v7 I'll take it.
Thanks!
Hans
Quoted 10 lines
include/uapi/linux/v4l2-controls.h +4
-1+#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402) --2.21.0.225.g810b269d1ac-goog
Hans Verkuil <[email protected]> 於 2019年3月28日 週四 下午11:01寫道:
Quoted 105 lines · Fish Lin
Quoted 88 lines
Add following V4L2 QP parameters for H.264:
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QPThese controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
Signed-off-by Fish Lin <[email protected]>---
Changelog since v5:
- Adjust documentation wording.Changelog since v4:
- Fix patch subject and send again.Changelog since v3:
- Put document inext-ctrls-codec.rstinstead ofextended-controls.rst(which was previous version).Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.Changelog since v1:
- Add description in document..../media/uapi/v4l/ext-ctrls-codec.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)Documentation/media/uapi/v4l/ext-ctrls-codec.rst +24
-0@@ -1048,6 +1048,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.drivers/media/v4l2-core/v4l2-ctrls.c +4
-0@@ -828,6 +828,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION :return "H264 Constrained Intra Pred" ;case V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET :return "H264 Chroma QP Index Offset" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;include/uapi/linux/v4l2-controls.h +0
-0include/uapi/linux/v4l2-controls.h enum v4l2_mpeg_video_h264_hierarchical_coding_type { · line 539
Quoted 5 lines
include/uapi/linux/v4l2-controls.h +2
-0@@ -535,6 +535,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type {#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382)#define V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION (V4L2_CID_MPEG_BASE+383)#define V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET (V4L2_CID_MPEG_BASE+384) + +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+390)There is no need for a gap in numbering. Just start with +385.
Sorry for this, I missed that in the previous reviews. Everything else looks good to me, so if you post a v7 I'll take it.
Thanks!
Hans
Quoted 11 lines
Quoted 10 lines
include/uapi/linux/v4l2-controls.h +4
-1+#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+391) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+392) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+393) +#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402) --2.21.0.225.g810b269d1ac-goog
Thanks for the review!
Fish
PATCH v7 1/1 v4l: add I / P frame min max QP definitions
In reply to Fish LinAdd following V4L2 QP parameters for H.264:
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP
These controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
---
Changelog since v6:
- Adjust ctrl id start from 385.
Changelog since v5:
- Adjust documentation wording.
Changelog since v4:
- Fix patch subject and send again.
Changelog since v3:
- Put document in ext-ctrls-codec.rst instead of extended-controls.rst (which was previous version).
Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.
Changelog since v1:
- Add description in document.
.../media/uapi/v4l/ext-ctrls-codec.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +24 -0
@@ -1048,6 +1048,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.
drivers/media/v4l2-core/v4l2-ctrls.c +4 -0
@@ -828,6 +828,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION :return "H264 Constrained Intra Pred" ;case V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET :return "H264 Chroma QP Index Offset" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;
include/uapi/linux/v4l2-controls.h +4 -0
@@ -535,6 +535,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type {#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382)#define V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION (V4L2_CID_MPEG_BASE+383)#define V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET (V4L2_CID_MPEG_BASE+384) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+385) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+386) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+387) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+388)#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
--
2.21.0.225.g810b269d1ac-goog
Sorry, please ignore this patch, I mis-edit the patch file, will send the correct one.
Fish
Fish Lin <[email protected]> 於 2019年3月29日 週五 上午10:59寫道:
Quoted 105 lines
Add following V4L2 QP parameters for H.264:
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
*V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QPThese controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
Signed-off-by Fish Lin <[email protected]>---
Changelog since v6:
- Adjust ctrl id start from 385.Changelog since v5:
- Adjust documentation wording.Changelog since v4:
- Fix patch subject and send again.Changelog since v3:
- Put document inext-ctrls-codec.rstinstead ofextended-controls.rst(which was previous version).Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.Changelog since v1:
- Add description in document..../media/uapi/v4l/ext-ctrls-codec.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 6 +++++ 3 files changed, 34 insertions(+)Documentation/media/uapi/v4l/ext-ctrls-codec.rst +24
-0@@ -1048,6 +1048,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.drivers/media/v4l2-core/v4l2-ctrls.c +4
-0@@ -828,6 +828,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION :return "H264 Constrained Intra Pred" ;case V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET :return "H264 Chroma QP Index Offset" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;include/uapi/linux/v4l2-controls.h +4
-1@@ -535,6 +535,12 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type {#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382)#define V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION (V4L2_CID_MPEG_BASE+383)#define V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET (V4L2_CID_MPEG_BASE+384) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+385) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+386) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+387) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+388)#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402) --2.21.0.225.g810b269d1ac-goog
PATCH v8 1/1 v4l: add I / P frame min max QP definitions
In reply to Fish LinAdd following V4L2 QP parameters for H.264:
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP
* V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP
These controls will limit QP range for intra and inter frame, provide more manual control to improve video encode quality.
---
Changelog since v7:
- Correct patch format.
Changelog since v6:
- Adjust ctrl id start from 385.
Changelog since v5:
- Adjust documentation wording.
Changelog since v4:
- Fix patch subject and send again.
Changelog since v3:
- Put document in ext-ctrls-codec.rst instead of extended-controls.rst (which was previous version).
Changelog since v2:
- Add interaction with V4L2_CID_MPEG_VIDEO_H264_MIN/MAX_QP description in the document.
Changelog since v1:
- Add description in document.
.../media/uapi/v4l/ext-ctrls-codec.rst | 24 +++++++++++++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ include/uapi/linux/v4l2-controls.h | 4 ++++ 3 files changed, 32 insertions(+)
Documentation/media/uapi/v4l/ext-ctrls-codec.rst +24 -0
@@ -1048,6 +1048,30 @@ enum v4l2_mpeg_video_h264_entropy_mode - Quantization parameter for an B frame for H264. Valid range: from 0 to 51. +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 I frame to limit I frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (integer)`` + Minimum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MIN_QP is also set, the quantization parameter + should be chosen to meet both requirements. + +``V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (integer)`` + Maximum quantization parameter for the H264 P frame to limit P frame + quality to a range. Valid range: from 0 to 51. If + V4L2_CID_MPEG_VIDEO_H264_MAX_QP is also set, the quantization parameter + should be chosen to meet both requirements. + ``V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (integer)`` Quantization parameter for an I frame for MPEG4. Valid range: from 1 to 31.
drivers/media/v4l2-core/v4l2-ctrls.c +4 -0
@@ -828,6 +828,10 @@ const char *v4l2_ctrl_get_name(u32 id)case V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION :return "H264 Constrained Intra Pred" ;case V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET :return "H264 Chroma QP Index Offset" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP :return "H264 I-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP :return "H264 I-Frame Maximum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP :return "H264 P-Frame Minimum QP Value" ; +case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP :return "H264 P-Frame Maximum QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP :return "MPEG4 I-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP :return "MPEG4 P-Frame QP Value" ;case V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP :return "MPEG4 B-Frame QP Value" ;
include/uapi/linux/v4l2-controls.h +4 -0
@@ -535,6 +535,10 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type {#define V4L2_CID_MPEG_VIDEO_H264_HIERARCHICAL_CODING_LAYER_QP (V4L2_CID_MPEG_BASE+382)#define V4L2_CID_MPEG_VIDEO_H264_CONSTRAINED_INTRA_PREDICTION (V4L2_CID_MPEG_BASE+383)#define V4L2_CID_MPEG_VIDEO_H264_CHROMA_QP_INDEX_OFFSET (V4L2_CID_MPEG_BASE+384) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+385) +#define V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+386) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP (V4L2_CID_MPEG_BASE+387) +#define V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP (V4L2_CID_MPEG_BASE+388)#define V4L2_CID_MPEG_VIDEO_MPEG4_I_FRAME_QP (V4L2_CID_MPEG_BASE+400)#define V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP (V4L2_CID_MPEG_BASE+401)#define V4L2_CID_MPEG_VIDEO_MPEG4_B_FRAME_QP (V4L2_CID_MPEG_BASE+402)
Signature · 1 line
2.21.0.392.gf8f6787159e-goog