Skip to contentSkip to conversation

mm: balloon: drop unused function stubs

PATCH In review David Hildenbrand 5 participants 5 messages Mar 29, 2019 – Apr 2, 2019 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: balloon: drop unused function stubs

These are leftovers from the pre-"general non-lru movable page" era.

---
 include/linux/balloon_compaction.h | 15 ---------------
 1 file changed, 15 deletions(-)
include/linux/balloon_compaction.h +0 -15
index f111c780ef1d..f31521dcb09a 100644
@@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
 	list_del(&page->lru);
 }
 
-static inline bool __is_movable_balloon_page(struct page *page)
-{
-	return false;
-}
-
-static inline bool balloon_page_movable(struct page *page)
-{
-	return false;
-}
-
-static inline bool isolated_balloon_page(struct page *page)
-{
-	return false;
-}
-
 static inline bool balloon_page_isolate(struct page *page)
 {
 	return false;
Signature · 1 line
2.17.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · David Hildenbrand

These are leftovers from the pre-"general non-lru movable page" era.

---
  include/linux/balloon_compaction.h | 15 ---------------
  1 file changed, 15 deletions(-)

Cheers,
-Mukesh

Quoted 27 lines
include/linux/balloon_compaction.h +0 -15
index f111c780ef1d..f31521dcb09a 100644
@@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
  	list_del(&page->lru);
  }
 
-static inline bool __is_movable_balloon_page(struct page *page)
-{
-	return false;
-}
-
-static inline bool balloon_page_movable(struct page *page)
-{
-	return false;
-}
-
-static inline bool isolated_balloon_page(struct page *page)
-{
-	return false;
-}
-
  static inline bool balloon_page_isolate(struct page *page)
  {
  	return false;
Acked-by on v1 1/1
#2 lore raw
In reply to David Hildenbrand
Quoted 3 lines · David Hildenbrand

These are leftovers from the pre-"general non-lru movable page" era.

Quoted 32 lines
---
 include/linux/balloon_compaction.h | 15 ---------------
 1 file changed, 15 deletions(-)
include/linux/balloon_compaction.h +0 -15
index f111c780ef1d..f31521dcb09a 100644
@@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
 	list_del(&page->lru);
 }
 
-static inline bool __is_movable_balloon_page(struct page *page)
-{
-	return false;
-}
-
-static inline bool balloon_page_movable(struct page *page)
-{
-	return false;
-}
-
-static inline bool isolated_balloon_page(struct page *page)
-{
-	return false;
-}
-
 static inline bool balloon_page_isolate(struct page *page)
 {
 	return false;
Signature · 1 line
2.17.2
Acked-by on v1 1/1
#3 lore raw
In reply to David Hildenbrand
Quoted 36 lines

These are leftovers from the pre-"general non-lru movable page" era.

---
 include/linux/balloon_compaction.h | 15 ---------------
 1 file changed, 15 deletions(-)
include/linux/balloon_compaction.h +0 -15
index f111c780ef1d..f31521dcb09a 100644
@@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page
 *page)
 	list_del(&page->lru);
 }
 
-static inline bool __is_movable_balloon_page(struct page *page)
-{
-	return false;
-}
-
-static inline bool balloon_page_movable(struct page *page)
-{
-	return false;
-}
-
-static inline bool isolated_balloon_page(struct page *page)
-{
-	return false;
-}
-
 static inline bool balloon_page_isolate(struct page *page)
 {
Quoted 3 lines

return false;
--
2.17.2

Looks good to me.

Quoted 2 lines
Acked-by on v1 1/1
#4 lore raw
In reply to David Hildenbrand
Quoted 36 lines · David Hildenbrand

These are leftovers from the pre-"general non-lru movable page" era.

---
 include/linux/balloon_compaction.h | 15 ---------------
 1 file changed, 15 deletions(-)
include/linux/balloon_compaction.h +0 -15
index f111c780ef1d..f31521dcb09a 100644
@@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
 	list_del(&page->lru);
 }
 
-static inline bool __is_movable_balloon_page(struct page *page)
-{
-	return false;
-}
-
-static inline bool balloon_page_movable(struct page *page)
-{
-	return false;
-}
-
-static inline bool isolated_balloon_page(struct page *page)
-{
-	return false;
-}
-
 static inline bool balloon_page_isolate(struct page *page)
 {
 	return false;
Signature · 1 line
2.17.2