Skip to contentSkip to conversation

lib/igt_kms: Clear pipe color management properties on reset.

PATCH In review Maarten Lankhorst 3 participants 4 messages Mar 29, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 lib/igt_kms: Clear pipe color management properties on reset.

Just like we try to sanitize all properties in igt_plane_reset, we should do the same for pipe properties. Loading a wrong lut could affect passing and failing tests, so we need to be careful and set sane defaults for everything.

---
 lib/igt_kms.c | 9 +++++++++
 1 file changed, 9 insertions(+)
lib/igt_kms.c +9 -0
index 43f45997073c..05cb9bd22090 100644
@@ -1804,6 +1804,15 @@ static void igt_pipe_reset(igt_pipe_t *pipe)
 	igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_ACTIVE, 0);
 	igt_pipe_obj_clear_prop_changed(pipe, IGT_CRTC_OUT_FENCE_PTR);
 
+	if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM))
+		igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_CTM, 0);
+
+	if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_GAMMA_LUT))
+		igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_GAMMA_LUT, 0);
+
+	if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_DEGAMMA_LUT))
+		igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_DEGAMMA_LUT, 0);
+
 	pipe->out_fence_fd = -1;
 }
 
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH 2/2 otests/kms_yuv: Add yuv specific tests, v5.

Add tests excercising switching between various scaled/unscaled transitions to and from various nv12 formats, since some of the workarounds mention this may fail.

We also add NV12 specific clipping/scaling tests, to make sure that YUV src coordinates are always programmed as a multiple of 2 correctly, and verify scaling/clipping works with CRC tests.

crop-scale-bug shows a corruption when scaling and cropping at the same time.

The subpixel clip test rotates and clips a rectangle on each side, which should produce the same CRC as when that part of the rectangle is hidden by a cursor and a whole 2x2 pixel is hidden.

Changes since v1:
- Reset plane position to 0,0 at the start of yuv_valid_width_plane().
- Handle Swati's feedback.
Changes since v2:
- Skip 90°/270° rotation in tests when formats don't support it.
- Add all new HDR formats to test.
- Use igt_plane_has_format_mod.
- Support tests on !i915 by checking if X/Y tiling modifiers are supported.
- Do not enable untested planes to prevent exhausing memory bandwidth and available NV12 Y planes in the rgb-switch-scaled test.
Changes since v3:
- Add a sanity test to sanity test YUV conversion paths, on all planes and pipes.
- Dynamically generate list of YUV tests through igt_format_array_fill. Changes since v4:
- Decrease size to 64x64 to reduce test execution time even more, some YUV conversion routines are slow.
- Don't clear degamma/ctm, this is done in core now.

---
 tests/Makefile.sources |   1 +
 tests/kms_yuv.c        | 936 +++++++++++++++++++++++++++++++++++++++++
 tests/meson.build      |   1 +
 3 files changed, 938 insertions(+)
 create mode 100644 tests/kms_yuv.c
tests/Makefile.sources +1 -0
index 71ccf00af256..5eb46087e362 100644
@@ -74,6 +74,7 @@ TESTS_progs = \
 	kms_universal_plane \
 	kms_vblank \
 	kms_vrr \
+	kms_yuv \
 	meta_test \
 	perf \
 	perf_pmu \
tests/kms_yuv.c new file +936 -0

936 lines not on this page · raw message

tests/meson.build +1 -0
index 9015f809ed05..8ca7fe5f4917 100644
@@ -61,6 +61,7 @@ test_progs = [
 	'kms_universal_plane',
 	'kms_vblank',
 	'kms_vrr',
+	'kms_yuv',
 	'meta_test',
 	'perf',
 	'prime_busy',
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v1 1/2
#2 lore raw
In reply to Maarten Lankhorst
Quoted 6 lines · Maarten Lankhorst

Just like we try to sanitize all properties in igt_plane_reset, we should do the same for pipe properties. Loading a wrong lut could affect passing and failing tests, so we need to be careful and set sane defaults for everything.

Quoted 31 lines
---
 lib/igt_kms.c | 9 +++++++++
 1 file changed, 9 insertions(+)
lib/igt_kms.c +9 -0
index 43f45997073c..05cb9bd22090 100644
@@ -1804,6 +1804,15 @@ static void igt_pipe_reset(igt_pipe_t *pipe)
 	igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_ACTIVE, 0);
 	igt_pipe_obj_clear_prop_changed(pipe, IGT_CRTC_OUT_FENCE_PTR);
 
+	if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM))
+		igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_CTM, 0);
+
+	if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_GAMMA_LUT))
+		igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_GAMMA_LUT, 0);
+
+	if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_DEGAMMA_LUT))
+		igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_DEGAMMA_LUT, 0);
+
 	pipe->out_fence_fd = -1;
 }
 
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#3 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] lib/igt_kms: Clear pipe color management properties on reset.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] lib/igt_kms: Clear pipe color management properties on reset.
URL : https://patchwork.freedesktop.org/series/58724/
State : failure

== Summary ==

CI Bug Log - changes from IGT_4912 -> IGTPW_2736
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2736 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2736, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/58724/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2736:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live_uncore:
- fi-kbl-8809g: PASS -> DMESG-FAIL

Known issues
------------

Here are the changes found in IGTPW_2736 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_basic@basic-vebox:
- fi-ivb-3770: NOTRUN -> SKIP [fdo#109271] +48

* igt@i915_pm_rpm@module-reload:
- fi-skl-6600u: PASS -> INCOMPLETE [fdo#107807]

* igt@kms_chamelium@vga-edid-read:
- fi-hsw-4770r: NOTRUN -> SKIP [fdo#109271] +45

* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

#### Possible fixes ####

* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS

* igt@i915_selftest@live_hangcheck:
- fi-icl-u2: INCOMPLETE [fdo#108569] -> PASS

* igt@i915_selftest@live_uncore:
- fi-skl-gvtdvm: DMESG-FAIL [fdo#110210] -> PASS

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: FAIL [fdo#103167] -> PASS

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210

Participating hosts (45 -> 42)
------------------------------

Additional (2): fi-hsw-4770r fi-ivb-3770
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-bdw-samus

Build changes
-------------

* IGT: IGT_4912 -> IGTPW_2736

CI_DRM_5835: a87cb5da301d892d69d44b106a007caea8386935 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2736: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2736/
IGT_4912: 66deae8b6fa69540f069d6551cd22013f5343948 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Testlist changes ==

+++ 756 lines
--- 0 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2736/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev