regulator: vctrl: Remove unneeded continue statement
PATCH 1/1 regulator: vctrl: Remove unneeded continue statement
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/vctrl-regulator.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/regulator/vctrl-regulator.c +1 -3
@@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev) ctrl_uV =regulator_list_voltage (ctrl_reg, i);if (ctrl_uV < vrange_ctrl->min_uV || - ctrl_uV > vrange_ctrl->max_uV) { + ctrl_uV > vrange_ctrl->max_uV) rdesc->n_voltages--; -continue ; - } }if (rdesc->n_voltages ==0 ) {
Signature · 1 line
2.17.1
Quoted 1 line · Axel Lin
Signed-off-by Axel Lin <[email protected]>
Yeah indeed! but where is commit text atleast a one-liner.
Otherwise looks good to me.
Reviewed-by Mukesh Ojha <[email protected]>
Cheers,
-Mukesh
Quoted 20 lines
--- drivers/regulator/vctrl-regulator.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/regulator/vctrl-regulator.c +1
-3@@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev) ctrl_uV =regulator_list_voltage (ctrl_reg, i);if (ctrl_uV < vrange_ctrl->min_uV || - ctrl_uV > vrange_ctrl->max_uV) { + ctrl_uV > vrange_ctrl->max_uV) rdesc->n_voltages--; -continue ; - } }if (rdesc->n_voltages ==0 ) {
Hi Axel,
On Fri, Mar 29, 2019 at 09:46:31AM +0800, Axel Lin wrote:
As Mukesh already mentioned, there should be a short description.
Quoted 10 lines
Signed-off-by Axel Lin <[email protected]>--- drivers/regulator/vctrl-regulator.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/regulator/vctrl-regulator.c +0
-0
drivers/regulator/vctrl-regulator.c static int vctrl_init_vtable(struct platform_device *pdev) · line 340
Quoted 8 lines
drivers/regulator/vctrl-regulator.c +1
-3@@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev) ctrl_uV =regulator_list_voltage (ctrl_reg, i);if (ctrl_uV < vrange_ctrl->min_uV || - ctrl_uV > vrange_ctrl->max_uV) { + ctrl_uV > vrange_ctrl->max_uV) rdesc->n_voltages--; -continue ; - }
indeed, the 'continue' is pointless here. I guess at some stage of development something else was done in the loop and this is a leftover.
Reviewed-by Matthias Kaehlcke <[email protected]>