lib/bitmap.c: remove unused EXPORT_SYMBOLs
Subsystems (2)
Rasmus Villemoes
reviewerPATCH 1/2 lib/bitmap.c: remove unused EXPORT_SYMBOLs
AFAICT, there have never been any callers of these functions outside mm/mempolicy.c (via their nodemask.h wrappers). In particular, no modular code has ever used them, and given their somewhat exotic semantics, I highly doubt they will ever find such a use. In any case, no need to export them currently.
--- lib/bitmap.c | 4 ---- 1 file changed, 4 deletions(-)
lib/bitmap.c +0 -4
@@ -757,7 +757,6 @@ void bitmap_remap(unsigned long *dst, const unsigned long *src,set_bit (bitmap_ord_to_pos (new, n % w, nbits), dst); } } -EXPORT_SYMBOL (bitmap_remap);/** * bitmap_bitremap - Apply map defined by a pair of bitmaps to a single bit
@@ -795,7 +794,6 @@ int bitmap_bitremap(int oldbit, const unsigned long *old,else return bitmap_ord_to_pos (new, n % w, bits); } -EXPORT_SYMBOL (bitmap_bitremap);/** * bitmap_onto - translate one bitmap relative to another
@@ -930,7 +928,6 @@ void bitmap_onto(unsigned long *dst, const unsigned long *orig, m++; } } -EXPORT_SYMBOL (bitmap_onto);/** * bitmap_fold - fold larger bitmap into smaller, modulo specified size
@@ -955,7 +952,6 @@ void bitmap_fold(unsigned long *dst, const unsigned long *orig,for_each_set_bit (oldbit, orig, nbits)set_bit (oldbit % sz, dst); } -EXPORT_SYMBOL (bitmap_fold);/* * Common code for bitmap_*_region() routines.
Signature · 1 line
2.20.1
Rasmus Villemoes
reviewerPATCH 2/2 lib/bitmap.c: guard exotic bitmap functions by CONFIG_NUMA
The bitmap_remap, _bitremap, _onto and _fold functions are only used, via their node_ wrappers, in mm/mempolicy.c, which is only built for CONFIG_NUMA. The helper bitmap_ord_to_pos used by these functions is global, but its only external caller is node_random() in lib/nodemask.c, which is also guarded by CONFIG_NUMA.
For !CONFIG_NUMA:
add/remove: 0/6 grow/shrink: 0/0 up/down: 0/-621 (-621)
Function old new delta
bitmap_pos_to_ord 20 - -20 bitmap_ord_to_pos 70 - -70 bitmap_bitremap 81 - -81 bitmap_fold 113 - -113 bitmap_onto 123 - -123 bitmap_remap 214 - -214
Total: Before=4776, After=4155, chg -13.00%
--- lib/bitmap.c | 2 ++ 1 file changed, 2 insertions(+)
lib/bitmap.c +2 -0
@@ -649,6 +649,7 @@ int bitmap_parselist_user(const char __user *ubuf,EXPORT_SYMBOL (bitmap_parselist_user); +#ifdef CONFIG_NUMA /** * bitmap_pos_to_ord - find ordinal of set bit at given position in bitmap * @buf: pointer to a bitmap
@@ -952,6 +953,7 @@ void bitmap_fold(unsigned long *dst, const unsigned long *orig,for_each_set_bit (oldbit, orig, nbits) set_bit(oldbit % sz, dst); } +#endif /* CONFIG_NUMA */ /* * Common code for bitmap_*_region() routines.
Signature · 1 line
2.20.1