Skip to contentSkip to conversation

rcu: tree_plugin: Dump specified number of blocked tasks

PATCH Applied Neeraj Upadhyay 3 participants 3 messages Mar 29, 2019 RCU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rcu: tree_plugin: Dump specified number of blocked tasks

dump_blkd_tasks() uses 10 as the max number of blocked tasks, which are printed. However, it has an argument which provides that number. So, use the argument value instead. As all callers currently pass 10 as the number, there isn't any impact.

---
 kernel/rcu/tree_plugin.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/tree_plugin.h +1 -1
index 3960294..08bcd87 100644
@@ -740,7 +740,7 @@ void exit_rcu(void)
 	i = 0;
 	list_for_each(lhp, &rnp->blkd_tasks) {
 		pr_cont(" %p", lhp);
-		if (++i >= 10)
+		if (++i >= ncheck)
 			break;
 	}
 	pr_cont("\n");
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Neeraj Upadhyay

dump_blkd_tasks() uses 10 as the max number of blocked tasks, which are printed. However, it has an argument which provides that number. So, use the argument value instead. As all callers currently pass 10 as the number, there isn't any impact.

Looks good to me.

Cheers,
-Mukesh

Quoted 17 lines
---
  kernel/rcu/tree_plugin.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/tree_plugin.h +1 -1
index 3960294..08bcd87 100644
@@ -740,7 +740,7 @@ void exit_rcu(void)
  	i = 0;
  	list_for_each(lhp, &rnp->blkd_tasks) {
  		pr_cont(" %p", lhp);
-		if (++i >= 10)
+		if (++i >= ncheck)
  			break;
  	}
  	pr_cont("\n");
#2 lore raw
Quoted 8 lines · Mukesh Ojha
Quoted 6 lines · Neeraj Upadhyay

dump_blkd_tasks() uses 10 as the max number of blocked tasks, which are printed. However, it has an argument which provides that number. So, use the argument value instead. As all callers currently pass 10 as the number, there isn't any impact.

Quoted 5 lines
Quoted 1 line

Looks good to me.

Applied, thank you both!

Thanx, Paul

Quoted 21 lines

Cheers,
-Mukesh

Quoted 17 lines
---
 kernel/rcu/tree_plugin.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/tree_plugin.h +1 -1
index 3960294..08bcd87 100644
@@ -740,7 +740,7 @@ void exit_rcu(void)
 	i = 0;
 	list_for_each(lhp, &rnp->blkd_tasks) {
 		pr_cont(" %p", lhp);
-		if (++i >= 10)
+		if (++i >= ncheck)
 			break;
 	}
 	pr_cont("\n");