Riscv: CONFIG_DEFAULT_DEVICE_TREE failures
I attempted to merge in the latest master branch into
https://github.com/sifive/u-boot/tree/sandbox and I got the following error, which seems somewhat broken..
Device Tree Source is not correctly specified. Please define 'CONFIG_DEFAULT_DEVICE_TREE' or build with 'DEVICE_TREE=<device_tree>' argument
dts/Makefile:28: recipe for target 'arch/riscv/dts/fu540.dtb' failed
Does anyone have any idea what would have caused that?
Also any feedback or pointers on why the serial_sifive.c driver with CONFIG_DM_SERIAL would not work, but serial_hifive.c without CONFIG_DM_SERIAL does seem to work might be appreciated.
Tom Rini
Reviewed-by Chris PackhamQuoted 9 lines · Troy Benjegerdes
I attempted to merge in the latest master branch into
https://github.com/sifive/u-boot/tree/sandbox and I got the following error, which seems somewhat broken..Device Tree Source is not correctly specified. Please define '
CONFIG_DEFAULT_DEVICE_TREE' or build with 'DEVICE_TREE=<device_tree>' argument
Quoted 8 lines
dts/Makefile:28: recipe for target '
arch/riscv/dts/fu540.dtb' failedDoes anyone have any idea what would have caused that?
Also any feedback or pointers on why the
serial_sifive.cdriver withCONFIG_DM_SERIALwould not work, butserial_hifive.cwithoutCONFIG_DM_SERIALdoes seem to work might be appreciated.
You'll need to do something like
commit 89c2b5c02049aea746b1edee0b4e1d8519dec2f4
Author: Masahiro Yamada <[email protected]> Date: Thu Mar 14 14:58:33 2019 +0900
ARM: fix arch/arm/dts/Makefile
Since commit 27cb7300ffda ("Ensure device tree DTS is compiled"), build succeeds irrespective of the correctness of Makefile.
In fact, you can compile any defconfig without adding any entry in arch/*/dts/Makefile.
As a result, a lot of wrong code have been merged unnoticed.
I am going to revert that commit, and lots of hidden issues have come to light:
[1] Typos
armada-3720-uDPU.dts, sun8i-a83t-tbs-a711.dts
use the extension ".dts" instead of ".dtb"
[2] DTB is associated to undefined CONFIG option
For example, mx6sllevk_defconfig defines CONFIG_MX6SLL, but associates its device tree to CONFIG_MX6SL, which is undefined.
[3] Lots of entries are missing
But to arch/riscv/dts/Makefile
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190331/245a6dd7/attachment.sig>
Quoted 53 lines · Tom Rini
Quoted 9 lines · Troy Benjegerdes
I attempted to merge in the latest master branch into
https://github.com/sifive/u-boot/tree/sandbox and I got the following error, which seems somewhat broken..Device Tree Source is not correctly specified. Please define '
CONFIG_DEFAULT_DEVICE_TREE' or build with 'DEVICE_TREE=<device_tree>' argumentQuoted 8 lines
dts/Makefile:28: recipe for target '
arch/riscv/dts/fu540.dtb' failedDoes anyone have any idea what would have caused that?
Also any feedback or pointers on why the
serial_sifive.cdriver withCONFIG_DM_SERIALwould not work, butserial_hifive.cwithoutCONFIG_DM_SERIALdoes seem to work might be appreciated.You'll need to do something like
commit
89c2b5c02049aea746b1edee0b4e1d8519dec2f4Author: Masahiro Yamada <[email protected]> Date: Thu Mar 14 14:58:33 2019 +0900ARM: fix
arch/arm/dts/MakefileSince commit
27cb7300ffda("Ensure device tree DTS is compiled"), build succeeds irrespective of the correctness ofMakefile.In fact, you can compile any defconfig without adding any entry in
arch/*/dts/Makefile.As a result, a lot of wrong code have been merged unnoticed.
I am going to revert that commit, and lots of hidden issues have come to light:
[1] Typos
armada-3720-uDPU.dts,sun8i-a83t-tbs-a711.dtsuse the extension ".dts" instead of ".dtb"
[2] DTB is associated to undefined CONFIG option
For example,
mx6sllevk_defconfigdefinesCONFIG_MX6SLL, but associates its device tree toCONFIG_MX6SL, which is undefined.
Quoted 11 lines
[3] Lots of entries are missing
Signed-off-by Masahiro Yamada <[email protected]>Reviewed-by Chris Packham <[email protected]>[trini: add imx6ul pico dtbs]Signed-off-by Tom Rini <[email protected]>But to
arch/riscv/dts/MakefileSignature · 1 line
Tom
I ended up reverting that commit, and we now have https://github.com/sifive/u-boot/tree/sandbox booting to a prompt based on upstream master.
It still needs the macb driver ported over, and probably re-worked to do what Rockchip boards do to put the Denali memory init code in the device tree.
Quoted 60 lines · Troy Benjegerdes
Quoted 60 lines · Tom Rini
Quoted 9 lines · Troy Benjegerdes
I attempted to merge in the latest master branch into
https://github.com/sifive/u-boot/tree/sandbox and I got the following error, which seems somewhat broken..Device Tree Source is not correctly specified. Please define '
CONFIG_DEFAULT_DEVICE_TREE' or build with 'DEVICE_TREE=<device_tree>' argumentQuoted 8 lines
dts/Makefile:28: recipe for target '
arch/riscv/dts/fu540.dtb' failedDoes anyone have any idea what would have caused that?
Also any feedback or pointers on why the
serial_sifive.cdriver withCONFIG_DM_SERIALwould not work, butserial_hifive.cwithoutCONFIG_DM_SERIALdoes seem to work might be appreciated.You'll need to do something like
commit
89c2b5c02049aea746b1edee0b4e1d8519dec2f4Author: Masahiro Yamada <[email protected]> Date: Thu Mar 14 14:58:33 2019 +0900ARM: fix
arch/arm/dts/MakefileSince commit
27cb7300ffda("Ensure device tree DTS is compiled"), build succeeds irrespective of the correctness ofMakefile.In fact, you can compile any defconfig without adding any entry in
arch/*/dts/Makefile.As a result, a lot of wrong code have been merged unnoticed.
I am going to revert that commit, and lots of hidden issues have come to light:
[1] Typos
armada-3720-uDPU.dts,sun8i-a83t-tbs-a711.dtsuse the extension ".dts" instead of ".dtb"
[2] DTB is associated to undefined CONFIG option
For example,
mx6sllevk_defconfigdefinesCONFIG_MX6SLL, but associates its device tree toCONFIG_MX6SL, which is undefined.[3] Lots of entries are missing
Signed-off-by Masahiro Yamada <[email protected]>Reviewed-by Chris Packham <[email protected]>[trini: add imx6ul pico dtbs]Signed-off-by Tom Rini <[email protected]>
Quoted 5 lines
Quoted 1 line
But to
arch/riscv/dts/MakefileI ended up reverting that commit, and we now have
https://github.com/sifive/u-boot/tree/sandbox booting to a prompt based on upstream master.
Note that you just need something like:
obj-y += first.dtb \
second.dtb
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190403/a37cf0fa/attachment.sig>
Quoted 64 lines · Tom Rini
Quoted 62 lines · Troy Benjegerdes
Quoted 61 lines · Tom Rini
Quoted 9 lines · Troy Benjegerdes
I attempted to merge in the latest master branch into
https://github.com/sifive/u-boot/tree/sandbox and I got the following error, which seems somewhat broken..Device Tree Source is not correctly specified. Please define '
CONFIG_DEFAULT_DEVICE_TREE' or build with 'DEVICE_TREE=<device_tree>' argumentQuoted 8 lines
dts/Makefile:28: recipe for target '
arch/riscv/dts/fu540.dtb' failedDoes anyone have any idea what would have caused that?
Also any feedback or pointers on why the
serial_sifive.cdriver withCONFIG_DM_SERIALwould not work, butserial_hifive.cwithoutCONFIG_DM_SERIALdoes seem to work might be appreciated.You'll need to do something like
commit
89c2b5c02049aea746b1edee0b4e1d8519dec2f4Author: Masahiro Yamada <[email protected]> Date: Thu Mar 14 14:58:33 2019 +0900ARM: fix
arch/arm/dts/MakefileSince commit
27cb7300ffda("Ensure device tree DTS is compiled"), build succeeds irrespective of the correctness ofMakefile.In fact, you can compile any defconfig without adding any entry in
arch/*/dts/Makefile.As a result, a lot of wrong code have been merged unnoticed.
I am going to revert that commit, and lots of hidden issues have come to light:
[1] Typos
armada-3720-uDPU.dts,sun8i-a83t-tbs-a711.dtsuse the extension ".dts" instead of ".dtb"
[2] DTB is associated to undefined CONFIG option
For example,
mx6sllevk_defconfigdefinesCONFIG_MX6SLL, but associates its device tree toCONFIG_MX6SL, which is undefined.[3] Lots of entries are missing
Signed-off-by Masahiro Yamada <[email protected]>Reviewed-by Chris Packham <[email protected]>[trini: add imx6ul pico dtbs]Signed-off-by Tom Rini <[email protected]>But to
arch/riscv/dts/Makefile
Quoted 7 lines
Quoted 3 lines
I ended up reverting that commit, and we now have
https://github.com/sifive/u-boot/tree/sandbox booting to a prompt based on upstream master.Note that you just need something like:
obj-y += first.dtb \
second.dtb
It should be:
dtb-y += first.dtb \
second.dtb
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 69 lines · Masahiro Yamada
Quoted 68 lines · Tom Rini
Quoted 65 lines · Troy Benjegerdes
Quoted 53 lines · Tom Rini
Quoted 9 lines · Troy Benjegerdes
I attempted to merge in the latest master branch into
https://github.com/sifive/u-boot/tree/sandbox and I got the following error, which seems somewhat broken..Device Tree Source is not correctly specified. Please define '
CONFIG_DEFAULT_DEVICE_TREE' or build with 'DEVICE_TREE=<device_tree>' argumentQuoted 8 lines
dts/Makefile:28: recipe for target '
arch/riscv/dts/fu540.dtb' failedDoes anyone have any idea what would have caused that?
Also any feedback or pointers on why the
serial_sifive.cdriver withCONFIG_DM_SERIALwould not work, butserial_hifive.cwithoutCONFIG_DM_SERIALdoes seem to work might be appreciated.You'll need to do something like
commit
89c2b5c02049aea746b1edee0b4e1d8519dec2f4Author: Masahiro Yamada <[email protected]> Date: Thu Mar 14 14:58:33 2019 +0900ARM: fix
arch/arm/dts/MakefileSince commit
27cb7300ffda("Ensure device tree DTS is compiled"), build succeeds irrespective of the correctness ofMakefile.In fact, you can compile any defconfig without adding any entry in
arch/*/dts/Makefile.As a result, a lot of wrong code have been merged unnoticed.
I am going to revert that commit, and lots of hidden issues have come to light:
[1] Typos
armada-3720-uDPU.dts,sun8i-a83t-tbs-a711.dtsuse the extension ".dts" instead of ".dtb"
[2] DTB is associated to undefined CONFIG option
For example,
mx6sllevk_defconfigdefinesCONFIG_MX6SLL, but associates its device tree toCONFIG_MX6SL, which is undefined.Quoted 8 lines
[3] Lots of entries are missing
Signed-off-by Masahiro Yamada <[email protected]>Reviewed-by Chris Packham <[email protected]>[trini: add imx6ul pico dtbs]Signed-off-by Tom Rini <[email protected]>But to
arch/riscv/dts/MakefileI ended up reverting that commit, and we now have
https://github.com/sifive/u-boot/tree/sandbox booting to a prompt based on upstream master.
Quoted 8 lines
Quoted 3 lines
Note that you just need something like:
obj-y += first.dtb \
second.dtbIt should be:
dtb-y += first.dtb \
second.dtb
Ah right, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190403/c3ff7c48/attachment.sig>