Skip to contentSkip to conversation

ARM: rmobile: rcar-gen2: Activate bootm_size

PATCH New Marek Vasut 2 participants 2 messages Mar 30, 2019 Arm/RISC-V/Renesas architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: rmobile: rcar-gen2: Activate bootm_size

Commit d245059ff797 ("ARM: rmobile: rcar-gen3: Activate bootm_size") only fixed the superfluous CONFIG_SYS_BOOTMAPSZ for R-Car Gen3, even though it listed all affected boards. Apply the same fix to Gen2.

Fixes d245059ff797 ("ARM: rmobile: rcar-gen3: Activate bootm_size")
Cc Eugeniu Rosca <[email protected]>
---
 include/configs/rcar-gen2-common.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/rcar-gen2-common.h +0 -1
index 9213d33e21..7f72ff2e11 100644
@@ -38,7 +38,6 @@
 #define CONFIG_SYS_MONITOR_BASE		0x00000000
 #define CONFIG_SYS_MONITOR_LEN		(256 * 1024)
 #define CONFIG_SYS_MALLOC_LEN		(1 * 1024 * 1024)
-#define CONFIG_SYS_BOOTMAPSZ		(8 * 1024 * 1024)
 
 /* ENV setting */
 #define CONFIG_ENV_ADDR	0xC0000
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 ARM: rmobile: rcar-gen2: Activate bootm_size

Hi Marek,

Quoted 2 lines · Marek Vasut

Commit d245059ff797 ("ARM: rmobile: rcar-gen3: Activate bootm_size") only fixed the superfluous CONFIG_SYS_BOOTMAPSZ for R-Car Gen3 [..]

I don't think 'superfluous' is the best wording here, since (according to its README description) CONFIG_SYS_BOOTMAPSZ invalidates/overrides the user-provided 'bootm_size' by taking precedence over the latter.

But I agree with the contents of this patch, since it resembles the aforementioned commit and brings more harmony between Gen2 and Gen3.

I don't have any Gen2 board to test it, but from code review standpoint:

Best regards,
Eugeniu.