Skip to contentSkip to conversation

vim: update to 8.1.1097

PATCH In review Oleksandr Kravchuk 4 participants 7 messages Mar 31, 2019 – Apr 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 vim: update to 8.1.1097

---
 .../vim/{vim-tiny_8.1.1017.bb => vim-tiny_8.1.1097.bb}          | 0
 meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1097.bb}   | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-tiny_8.1.1097.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1097.bb} (98%)
meta/recipes-support/vim/vim-tiny_8.1.1097.bb renamed from meta/recipes-support/vim/vim-tiny_8.1.1017.bb +0 -0
similarity index 100%
rename from meta/recipes-support/vim/vim-tiny_8.1.1017.bb
rename to meta/recipes-support/vim/vim-tiny_8.1.1097.bb
meta/recipes-support/vim/vim_8.1.1097.bb renamed from meta/recipes-support/vim/vim_8.1.1017.bb +1 -1
similarity index 98%
rename from meta/recipes-support/vim/vim_8.1.1017.bb
rename to meta/recipes-support/vim/vim_8.1.1097.bb
index 7627d2844b..4de1bc3807 100644
@@ -13,7 +13,7 @@ SRC_URI = "git://github.com/vim/vim.git \
            file://vim-add-knob-whether-elf.h-are-checked.patch;patchdir=.. \
            file://0001-src-Makefile-improve-reproducibility.patch;patchdir=.. \
 "
-SRCREV = "493fbe4abee660d30b4f2aef87b754b0a720213c"
+SRCREV = "4fc8e2f8bb3eb42df0f72cfcc1f8f8e567e7ce4f"
 
 S = "${WORKDIR}/git/src"
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 20 lines · Oleksandr Kravchuk
---
 .../vim/{vim-tiny_8.1.1017.bb => vim-tiny_8.1.1097.bb}          | 0
 meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1097.bb}   | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-tiny_8.1.1097.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1097.bb} (98%)
meta/recipes-support/vim/vim-tiny_8.1.1097.bb renamed from meta/recipes-support/vim/vim-tiny_8.1.1017.bb +0 -0
similarity index 100%
rename from meta/recipes-support/vim/vim-tiny_8.1.1017.bb
rename to meta/recipes-support/vim/vim-tiny_8.1.1097.bb
meta/recipes-support/vim/vim_8.1.1097.bb renamed from meta/recipes-support/vim/vim_8.1.1017.bb +0 -0
similarity index 98%
rename from meta/recipes-support/vim/vim_8.1.1017.bb
rename to meta/recipes-support/vim/vim_8.1.1097.bb
index 7627d2844b..4de1bc3807 100644

meta/recipes-support/vim/vim_8.1.1097.bb SRC_URI = "git://github.com/vim/vim.git \ · line 18

Quoted 7 lines
meta/recipes-support/vim/vim_8.1.1097.bb renamed from meta/recipes-support/vim/vim_8.1.1017.bb +1 -1
@@ -13,7 +13,7 @@ SRC_URI = "git://github.com/vim/vim.git \
            file://vim-add-knob-whether-elf.h-are-checked.patch;patchdir=.. \
            file://0001-src-Makefile-improve-reproducibility.patch;patchdir=.. \
 "
-SRCREV = "493fbe4abee660d30b4f2aef87b754b0a720213c"
+SRCREV = "4fc8e2f8bb3eb42df0f72cfcc1f8f8e567e7ce4f"
 
 S = "${WORKDIR}/git/src"

Looks better, thanks. Is there a particular fix / change you're doing this for? I ask since every commit is a version bump we might want to set a guideline of once a month or so for bumping vim to the latest.

Signature · 1 line
Tom
#2 lore raw
Quoted 3 lines · Tom Rini

Looks better, thanks. Is there a particular fix / change you're doing this for? I ask since every commit is a version bump we might want to set a guideline of once a month or so for bumping vim to the latest.

It's a bit insane upstream is doing that.
Should we set PV to something like PV = "8.1+git${SRCPV}"? That way devtool/AUH/RRS will not be reporting a new version for each commit, and will only do that when 8.2 is out.

Alex

#3 lore raw
Quoted 9 lines · Alexander Kanavin
Quoted 3 lines · Tom Rini

Looks better, thanks. Is there a particular fix / change you're doing this for? I ask since every commit is a version bump we might want to set a guideline of once a month or so for bumping vim to the latest.

It's a bit insane upstream is doing that.
Should we set PV to something like PV = "8.1+git${SRCPV}"? That way devtool/AUH/RRS will not be reporting a new version for each commit, and will only do that when 8.2 is out.

No, we should follow what upstream does for version numbers, it's what other distros do. And on the related topic of "is it a stable branch?", it does seem like yes, it is. We should just remember to not update it more often than say the first of the month, without a specific reason.

Signature · 1 line
Tom
#4 lore raw
Quoted 11 lines · Tom Rini
Quoted 9 lines · Alexander Kanavin
Quoted 3 lines · Tom Rini

Looks better, thanks. Is there a particular fix / change you're doing this for? I ask since every commit is a version bump we might want to set a guideline of once a month or so for bumping vim to the latest.

It's a bit insane upstream is doing that.
Should we set PV to something like PV = "8.1+git${SRCPV}"? That way devtool/AUH/RRS will not be reporting a new version for each commit, and will only do that when 8.2 is out.

Quoted 4 lines

No, we should follow what upstream does for version numbers, it's what other distros do. And on the related topic of "is it a stable branch?", it does seem like yes, it is. We should just remember to not update it more often than say the first of the month, without a specific reason.

When I've done vim updates in the past I aimed for once every 3 months. I also looked at Debian/Fedora/etc to find a version that someone else has already tested in a distribution - with vim having so many "releases" you have the same issue you'd get from picking a random commit off the master branch from another project. Matching against a version used somewhere else gives us something to compare to when we hit a bug.

Thanks,

Signature · 3 lines
Paul Barker
Managing Director & Principal Engineer
Beta Five Ltd
#5 lore raw
Quoted 17 lines · Paul Barker
Quoted 11 lines · Tom Rini
Quoted 9 lines · Alexander Kanavin
Quoted 3 lines · Tom Rini

Looks better, thanks. Is there a particular fix / change you're doing this for? I ask since every commit is a version bump we might want to set a guideline of once a month or so for bumping vim to the latest.

It's a bit insane upstream is doing that.
Should we set PV to something like PV = "8.1+git${SRCPV}"? That way devtool/AUH/RRS will not be reporting a new version for each commit, and will only do that when 8.2 is out.

Quoted 4 lines

No, we should follow what upstream does for version numbers, it's what other distros do. And on the related topic of "is it a stable branch?", it does seem like yes, it is. We should just remember to not update it more often than say the first of the month, without a specific reason.

Quoted 7 lines

When I've done vim updates in the past I aimed for once every 3 months. I also looked at Debian/Fedora/etc to find a version that someone else has already tested in a distribution - with vim having so many "releases" you have the same issue you'd get from picking a random commit off the master branch from another project. Matching against a version used somewhere else gives us something to compare to when we hit a bug.

That's also a good idea, yes. My only concern is finding something moving forward otherwise quickly enough, but Fedora might do well for that.

Signature · 1 line
Tom
#6 lore raw
Quoted 22 lines · Tom Rini
Quoted 14 lines · Paul Barker
Quoted 5 lines · Tom Rini
Quoted 4 lines · Alexander Kanavin
Quoted 3 lines · Tom Rini

Looks better, thanks. Is there a particular fix / change you're doing this for? I ask since every commit is a version bump we might want to set a guideline of once a month or so for bumping vim to the latest.

Quoted 8 lines
Quoted 4 lines

It's a bit insane upstream is doing that.
Should we set PV to something like PV = "8.1+git${SRCPV}"? That way devtool/AUH/RRS will not be reporting a new version for each commit, and will only do that when 8.2 is out.

No, we should follow what upstream does for version numbers, it's what other distros do. And on the related topic of "is it a stable branch?", it does seem like yes, it is. We should just remember to not update it more often than say the first of the month, without a specific reason.

Quoted 7 lines

When I've done vim updates in the past I aimed for once every 3 months. I also looked at Debian/Fedora/etc to find a version that someone else has already tested in a distribution - with vim having so many "releases" you have the same issue you'd get from picking a random commit off the master branch from another project. Matching against a version used somewhere else gives us something to compare to when we hit a bug.

Quoted 3 lines

That's also a good idea, yes. My only concern is finding something moving forward otherwise quickly enough, but Fedora might do well for that.

I think it is indeed a good idea for maintainers to look up for stable projects, e.g Debian.

It would be nice to have those guidelines set and clear though.