package/gettext-tiny: fix build of libintl.a
PATCH 1/1 package/gettext-tiny: fix build of libintl.a
Since libintl.a can be pulled in during the build of other shared libs, it must be compiled with -fPIC, which is what gettext-tiny's Makefile would do.
Since we provide our own CFLAGS, they override those in the Makefile.
Fix that by ensurign that -fPIC is used when building the static library.
Fixes:
http://autobuild.buildroot.org/results/a38/a3800fd4ef2536cc2b82d38ea752baa2b227bc64/
Also, since GETTEXT_TINY_OPTS is used only once and contains a single definition, get rid of it altogether.
--- package/gettext-tiny/gettext-tiny.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/gettext-tiny/gettext-tiny.mk +2 -2
@@ -9,7 +9,6 @@ GETTEXT_TINY_SITE = $(call github,sabotage-linux,gettext-tiny,$(GETTEXT_TINY_VER GETTEXT_TINY_LICENSE = MIT, GPL-3.0+ (extra gettext) GETTEXT_TINY_INSTALL_STAGING = YES GETTEXT_TINY_LICENSE_FILES = LICENSE extra/COPYING -GETTEXT_TINY_OPTS = LIBINTL=NOOP GETTEXT_TINY_PROVIDES = gettext
@@ -56,7 +55,8 @@ endif define HOST_GETTEXT_TINY_BUILD_CMDS $(HOST_MAKE_ENV) $(MAKE) -C $(@D) \ $(HOST_CONFIGURE_OPTS) \ - $(GETTEXT_TINY_OPTS) + CFLAGS="$(HOST_CFLAGS) -fPIC" \ + LIBINTL=NOOP cp $(@D)/extra/gettextize.in $(@D)/gettextize
Signature · 1 line
2.14.1
Thomas Petazzoni
AppliedPATCH 1/1 package/gettext-tiny: fix build of libintl.a
Quoted 15 lines · On Sun, 31 Mar 2019 17:34:29 +0200 "Yann E. MORIN" <[email protected]>…
Since libintl.a can be pulled in during the build of other shared libs, it must be compiled with -fPIC, which is what gettext-tiny's
Makefilewould do.Since we provide our own CFLAGS, they override those in the
Makefile.Fix that by ensurign that -fPIC is used when building the static library.
Fixes:
http://autobuild.buildroot.org/results/a38/a3800fd4ef2536cc2b82d38ea752baa2b227bc64/Also, since
GETTEXT_TINY_OPTSis used only once and contains a single definition, get rid of it altogether.
Quoted 6 lines
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Vadim Kochan <[email protected]>Cc Thomas Petazzoni <[email protected]>--- package/gettext-tiny/gettext-tiny.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com