Skip to contentSkip to conversation

Staging: comedi: drivers: pcl818: Fixed a coding style error.

PATCH Superseded Will Cunningham 3 participants 3 messages Mar 31, 2019 – Apr 1, 2019 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: comedi: drivers: pcl818: Fixed a coding style error.

Removed unnecessary parentheses.`

---
 drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/comedi/drivers/pcl818.c +4 -4
index 0af5315d4357..da5d53a288f7 100644
@@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 		pcl818_alloc_dma(dev, it->options[2]);
 
 	/* use 1MHz or 10MHz oscilator */
-	if ((it->options[3] == 0) || (it->options[3] == 10))
+	if (it->options[3] == 0 || it->options[3] == 10)
 		osc_base = I8254_OSC_BASE_10MHZ;
 	else
 		osc_base = I8254_OSC_BASE_1MHZ;
@@ -1026,7 +1026,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	devpriv->ns_min = board->ns_min;
 	if (!board->is_818) {
 		/* extended PCL718 to 100kHz DAC */
-		if ((it->options[6] == 1) || (it->options[6] == 100))
+		if (it->options[6] == 1 || it->options[6] == 100)
 			devpriv->ns_min = 10000;
 	}
 
@@ -1067,12 +1067,12 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 		s->maxdata	= 0x0fff;
 		s->range_table	= &range_unipolar5;
 		if (board->is_818) {
-			if ((it->options[4] == 1) || (it->options[4] == 10))
+			if (it->options[4] == 1 || it->options[4] == 10)
 				s->range_table = &range_unipolar10;
 			if (it->options[4] == 2)
 				s->range_table = &range_unknown;
 		} else {
-			if ((it->options[5] == 1) || (it->options[5] == 10))
+			if (it->options[5] == 1 || it->options[5] == 10)
 				s->range_table = &range_unipolar10;
 			if (it->options[5] == 2)
 				s->range_table = &range_unknown;
Signature · 1 line
2.19.2
maintainer
#1 lore raw
Quoted 1 line · Will Cunningham

Removed unnecessary parentheses.`

Odd trailing character :(

Quoted 11 lines
---
 drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/comedi/drivers/pcl818.c +0 -0
index 0af5315d4357..da5d53a288f7 100644

drivers/staging/comedi/drivers/pcl818.c static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it) · line 1015

Quoted 5 lines
drivers/staging/comedi/drivers/pcl818.c +1 -1
@@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 		pcl818_alloc_dma(dev, it->options[2]);
 
 	/* use 1MHz or 10MHz oscilator */
-	if ((it->options[3] == 0) || (it->options[3] == 10))
+	if (it->options[3] == 0 || it->options[3] == 10)

No, please leave as-is. () are there for humans to read, and having to always remember the order of operations is not something you ever want to do.

I _REALLY_ hate this option of checkpatch :(

greg k-h

Reviewed-by on v1 1/1
#2 lore raw
In reply to Will Cunningham
Quoted 1 line · Will Cunningham

Removed unnecessary parentheses.`

Remove the extra character at the end.

Fix the above thing then you can take.

Cheers,
-Mukesh

Quoted 43 lines
---
  drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/comedi/drivers/pcl818.c +4 -4
index 0af5315d4357..da5d53a288f7 100644
@@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
  		pcl818_alloc_dma(dev, it->options[2]);
 
  	/* use 1MHz or 10MHz oscilator */
-	if ((it->options[3] == 0) || (it->options[3] == 10))
+	if (it->options[3] == 0 || it->options[3] == 10)
  		osc_base = I8254_OSC_BASE_10MHZ;
  	else
  		osc_base = I8254_OSC_BASE_1MHZ;
@@ -1026,7 +1026,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
  	devpriv->ns_min = board->ns_min;
  	if (!board->is_818) {
  		/* extended PCL718 to 100kHz DAC */
-		if ((it->options[6] == 1) || (it->options[6] == 100))
+		if (it->options[6] == 1 || it->options[6] == 100)
  			devpriv->ns_min = 10000;
  	}
 
@@ -1067,12 +1067,12 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
  		s->maxdata	= 0x0fff;
  		s->range_table	= &range_unipolar5;
  		if (board->is_818) {
-			if ((it->options[4] == 1) || (it->options[4] == 10))
+			if (it->options[4] == 1 || it->options[4] == 10)
  				s->range_table = &range_unipolar10;
  			if (it->options[4] == 2)
  				s->range_table = &range_unknown;
  		} else {
-			if ((it->options[5] == 1) || (it->options[5] == 10))
+			if (it->options[5] == 1 || it->options[5] == 10)
  				s->range_table = &range_unipolar10;
  			if (it->options[5] == 2)
  				s->range_table = &range_unknown;