soc: amlogic: meson-gx-pwrc-vpu: Fix power on/off register bitmask
PATCH 1/1 soc: amlogic: meson-gx-pwrc-vpu: Fix power on/off register bitmask
The register bitmask to power on/off the VPU memories was incorectly set to 0x2 instead of 0x3. While still working, let's use the recommended vendor value instead.
Fixes 75fcb5ca4b46 ("soc: amlogic: add Meson GX VPU Domains driver")
Signed-off-by Neil Armstrong <[email protected]>
--- drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/soc/amlogic/meson-gx-pwrc-vpu.c +4 -4
@@ -54,12 +54,12 @@ static int meson_gx_pwrc_vpu_power_off(struct generic_pm_domain *genpd)/* Power Down Memories */ for (i =0 ; i <32 ; i +=2 ) {regmap_update_bits (pd->regmap_hhi,HHI_VPU_MEM_PD_REG0 , -0x2 << i,0x3 << i); +0x3 << i,0x3 << i);udelay (5 ); }for (i =0 ; i <32 ; i +=2 ) {regmap_update_bits (pd->regmap_hhi,HHI_VPU_MEM_PD_REG1 , -0x2 << i,0x3 << i); +0x3 << i,0x3 << i);udelay (5 ); }for (i =8 ; i <16 ; i++) {
@@ -108,13 +108,13 @@ static int meson_gx_pwrc_vpu_power_on(struct generic_pm_domain *genpd)/* Power Up Memories */ for (i =0 ; i <32 ; i +=2 ) {regmap_update_bits (pd->regmap_hhi,HHI_VPU_MEM_PD_REG0 , -0x2 << i,0 ); +0x3 << i,0 );udelay (5 ); }for (i =0 ; i <32 ; i +=2 ) {regmap_update_bits (pd->regmap_hhi,HHI_VPU_MEM_PD_REG1 , -0x2 << i,0 ); +0x3 << i,0 );udelay (5 ); }
Signature · 1 line
2.21.0
Kevin Hilman
maintainerQuoted 6 lines · Neil Armstrong
The register bitmask to power on/off the VPU memories was incorectly set to
0x2instead of0x3. While still working, let's use the recommended vendor value instead.Fixes 75fcb5ca4b46 ("soc: amlogic: add Meson GX VPU Domains driver")Signed-off-by Neil Armstrong <[email protected]>
Queued for v5.2,
Kevin