e2fsprogs: Fix autoheader failure
PATCH 1/1 e2fsprogs: Fix autoheader failure
Autoheader reports:
autoheader: warning: missing template: HAVE_BLKID_PROBE_ENABLE_PARTITIONS
autoheader: Use AC_DEFINE([HAVE_BLKID_PROBE_ENABLE_PARTITIONS], [], [Description])
autoheader: warning: missing template: HAVE_BLKID_PROBE_GET_TOPOLOGY
so provide appropriate descriptions for the defines.
--- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
configure.ac +2 -2
@@ -1119,9 +1119,9 @@ dnl the functions added after migrating that library to util-linux dnl if test -n "$BLKID_CMT"; then AC_CHECK_LIB(blkid, blkid_probe_get_topology, - AC_DEFINE(HAVE_BLKID_PROBE_GET_TOPOLOGY, 1)) + AC_DEFINE(HAVE_BLKID_PROBE_GET_TOPOLOGY, 1, [Define to 1 if blkid library provides blkid_probe_get_topology])) AC_CHECK_LIB(blkid, blkid_probe_enable_partitions, - AC_DEFINE(HAVE_BLKID_PROBE_ENABLE_PARTITIONS, 1)) + AC_DEFINE(HAVE_BLKID_PROBE_ENABLE_PARTITIONS, 1, [Define to 1 if blkid library provides blkid_probe_enable_partitions])) fi dnl if test -n "$DLOPEN_LIB" ; then
Signature · 1 line
2.16.4
Quoted 9 lines · Jan Kara
Autoheader reports:
autoheader: warning: missing template:
HAVE_BLKID_PROBE_ENABLE_PARTITIONS
autoheader: UseAC_DEFINE([HAVE_BLKID_PROBE_ENABLE_PARTITIONS], [], [Description])
autoheader: warning: missing template:HAVE_BLKID_PROBE_GET_TOPOLOGYso provide appropriate descriptions for the defines.
Signed-off-by Jan Kara <[email protected]>
Thanks, apologies for failing to push out the e2fsprogs fix out to git earlier, but this problem has already been fixed by commit f72ea2deb0d8.
Cheers,
- Ted
Quoted 7 lines · Theodore Ts'o
Quoted 6 lines · Jan Kara
Autoheader reports:
autoheader: warning: missing template:
HAVE_BLKID_PROBE_ENABLE_PARTITIONS
autoheader: UseAC_DEFINE([HAVE_BLKID_PROBE_ENABLE_PARTITIONS], [], [Description])
autoheader: warning: missing template:HAVE_BLKID_PROBE_GET_TOPOLOGY
Quoted 7 lines
Quoted 3 lines
so provide appropriate descriptions for the defines.
Signed-off-by Jan Kara <[email protected]>Thanks, apologies for failing to push out the e2fsprogs fix out to git earlier, but this problem has already been fixed by commit
f72ea2deb0d8.
No problem :). I was just packaging latest e2fsprogs release and stumbled upon this...
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 3 lines · Jan Kara
No problem :). I was just packaging latest e2fsprogs release and stumbled upon this...
If you are packaging the e2fsprogs v1.45, I suggest you either (a) hold back on packaging e2scrub, or (b) wait for 1.45.1, which I hope to get out fairly soon, since by packaing 1.45 for Debian unstable, we've gotten many useful bug reports and as you can see, there are a lot of e2scrub fixes that are queued up for the next release.
- Ted
Quoted 10 lines · Theodore Ts'o
Quoted 3 lines · Jan Kara
No problem :). I was just packaging latest e2fsprogs release and stumbled upon this...
If you are packaging the e2fsprogs v1.45, I suggest you either (a) hold back on packaging e2scrub, or (b) wait for 1.45.1, which I hope to get out fairly soon, since by packaing 1.45 for Debian unstable, we've gotten many useful bug reports and as you can see, there are a lot of e2scrub fixes that are queued up for the next release.
Thanks for info! I did package e2scrub but so far disabled installing any of crond files, systemd files, or udev rules so it should be harmless unless someone manually runs it...
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 12 lines · Jan Kara
Quoted 10 lines · Theodore Ts'o
Quoted 3 lines · Jan Kara
No problem :). I was just packaging latest e2fsprogs release and stumbled upon this...
If you are packaging the e2fsprogs v1.45, I suggest you either (a) hold back on packaging e2scrub, or (b) wait for 1.45.1, which I hope to get out fairly soon, since by packaing 1.45 for Debian unstable, we've gotten many useful bug reports and as you can see, there are a lot of e2scrub fixes that are queued up for the next release.
Quoted 3 lines
Thanks for info! I did package e2scrub but so far disabled installing any of crond files, systemd files, or udev rules so it should be harmless unless someone manually runs it...
I did pretty much the same thing for rawhide and I do plan to enable the whole thing with the next update.
Thanks!
-Lukas
Quoted 6 lines
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR