Skip to contentSkip to conversation

mx6: colibri: fix build due to missing DTB

PATCH New Stefano Babic 2 participants 3 messages Apr 1, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx6: colibri: fix build due to missing DTB

This fix colibri (imx6) build due to:

Device Tree Source is not correctly specified. Please define 'CONFIG_DEFAULT_DEVICE_TREE' or build with 'DEVICE_TREE=<device_tree>' argument

CONFIG_DEFAULT_DEVICE_TREE is set in default config, but it is not built because the target is missing in dts/Makefile

CC Marcel Ziswiler <[email protected]>

---

I got build error after rebasing on current Tom's master - colibri-imx6.dtb is missing from dts/Makefile.

This is to fix -next on u-boot-imx.

 arch/arm/dts/Makefile | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/dts/Makefile +3 -0
index e67b3bd767..0b39721dbc 100644
@@ -500,6 +500,9 @@ dtb-$(CONFIG_MX6Q) += \
 	imx6q-display5.dtb \
 	imx6q-logicpd.dtb
 
+dtb-$(CONFIG_TARGET_COLIBRI_IMX6) += \
+	imx6-colibri.dtb
+
 dtb-$(CONFIG_MX6QDL) += \
 	imx6dl-icore.dtb \
 	imx6dl-icore-mipi.dtb \
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 mx6: colibri: fix build due to missing DTB

Quoted 9 lines · Stefano Babic

This fix colibri (imx6) build due to:

Device Tree Source is not correctly specified. Please define 'CONFIG_DEFAULT_DEVICE_TREE' or build with 'DEVICE_TREE=<device_tree>' argument

CONFIG_DEFAULT_DEVICE_TREE is set in default config, but it is not built
because the target is missing in dts/Makefile

I already did send that one:

https://patchwork.ozlabs.org/patch/1064558/

Quoted 27 lines
CC Marcel Ziswiler <[email protected]>

---

I got build error after rebasing on current Tom's master - colibri- imx6.dtb
is missing from dts/Makefile.

This is to fix -next on u-boot-imx.

 arch/arm/dts/Makefile | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/dts/Makefile +3 -0
index e67b3bd767..0b39721dbc 100644
@@ -500,6 +500,9 @@ dtb-$(CONFIG_MX6Q) += \
 	imx6q-display5.dtb \
 	imx6q-logicpd.dtb
 
+dtb-$(CONFIG_TARGET_COLIBRI_IMX6) += \
+	imx6-colibri.dtb
+
 dtb-$(CONFIG_MX6QDL) += \
 	imx6dl-icore.dtb \
 	imx6dl-icore-mipi.dtb \
#2 lore raw

PATCH 1/1 mx6: colibri: fix build due to missing DTB

Quoted 7 lines · Marcel Ziswiler
Quoted 6 lines · Stefano Babic

This fix colibri (imx6) build due to:

Device Tree Source is not correctly specified. Please define 'CONFIG_DEFAULT_DEVICE_TREE' or build with 'DEVICE_TREE=<device_tree>' argument

Quoted 8 lines
Quoted 3 lines

CONFIG_DEFAULT_DEVICE_TREE is set in default config, but it is not built
because the target is missing in dts/Makefile

I already did send that one:

https://patchwork.ozlabs.org/patch/1064558/

Ouch, shame on me, I could fix it easier.

I have already fixed apalis, I put your to fix colibri. Anyway, I wonder why your board do not set the i.MX6 variant, at least colibri should set MC6DL and apalis MX6Q. This led to use the specific target (as I did) or ARCH_MX6 (as you did), but not CONFIG_MX6QDL as most boards.

Anyway, I will merge this on -next, thanks.

Regards,
Stefano

Quoted 27 lines
Quoted 27 lines
CC Marcel Ziswiler <[email protected]>

---

I got build error after rebasing on current Tom's master - colibri- imx6.dtb
is missing from dts/Makefile.

This is to fix -next on u-boot-imx.

 arch/arm/dts/Makefile | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/dts/Makefile +3 -0
index e67b3bd767..0b39721dbc 100644
@@ -500,6 +500,9 @@ dtb-$(CONFIG_MX6Q) += \
 	imx6q-display5.dtb \
 	imx6q-logicpd.dtb
 
+dtb-$(CONFIG_TARGET_COLIBRI_IMX6) += \
+	imx6-colibri.dtb
+
 dtb-$(CONFIG_MX6QDL) += \
 	imx6dl-icore.dtb \
 	imx6dl-icore-mipi.dtb \
Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================