Skip to contentSkip to conversation

Staging: greybus: usb: Fixed a coding style error

PATCH In review Will Cunningham 3 participants 3 messages Apr 1, 2019 – Apr 2, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: greybus: usb: Fixed a coding style error

Line was >80 characters.

---
Changes in v2:
- Created a tmp variable to shorten line length.

---
 drivers/staging/greybus/usb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/greybus/usb.c +3 -3
index 1c246c73a085..c09793b48850 100644
@@ -163,14 +163,14 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev,
 	struct gb_usb_device *gb_usb_dev;
 	struct usb_hcd *hcd;
 	int retval;
+	u16 tmp;
 
 	hcd = usb_create_hcd(&usb_gb_hc_driver, dev, dev_name(dev));
 	if (!hcd)
 		return -ENOMEM;
 
-	connection = gb_connection_create(gbphy_dev->bundle,
-					  le16_to_cpu(gbphy_dev->cport_desc->id),
-					  NULL);
+	tmp = le16_to_cpu(gbphy_dev->cport_desc->id);
+	connection = gb_connection_create(gbphy_dev->bundle, tmp, NULL);
 	if (IS_ERR(connection)) {
 		retval = PTR_ERR(connection);
 		goto exit_usb_put;
Signature · 1 line
2.19.2
#1 lore raw
Quoted 1 line · Will Cunningham

Line was >80 characters.

This looks fine, but "tmp" is not a meaningful name. That argument to gb_connection_create() is a cport id, so "cport_id" would be a much better name for the variable.

It seems picky, but details like this make the code much more understandable.

-Alex

Quoted 31 lines

---
Changes in v2:
- Created a tmp variable to shorten line length.

---
 drivers/staging/greybus/usb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/greybus/usb.c +3 -3
index 1c246c73a085..c09793b48850 100644
@@ -163,14 +163,14 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev,
 	struct gb_usb_device *gb_usb_dev;
 	struct usb_hcd *hcd;
 	int retval;
+	u16 tmp;
 
 	hcd = usb_create_hcd(&usb_gb_hc_driver, dev, dev_name(dev));
 	if (!hcd)
 		return -ENOMEM;
 
-	connection = gb_connection_create(gbphy_dev->bundle,
-					  le16_to_cpu(gbphy_dev->cport_desc->id),
-					  NULL);
+	tmp = le16_to_cpu(gbphy_dev->cport_desc->id);
+	connection = gb_connection_create(gbphy_dev->bundle, tmp, NULL);
 	if (IS_ERR(connection)) {
 		retval = PTR_ERR(connection);
 		goto exit_usb_put;
#2 lore raw
In reply to Will Cunningham
Quoted 19 lines · Will Cunningham

Line was >80 characters.

---
Changes in v2:
- Created a tmp variable to shorten line length.

---
 drivers/staging/greybus/usb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/greybus/usb.c +1 -0
index 1c246c73a085..c09793b48850 100644
@@ -163,14 +163,14 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev,
 	struct gb_usb_device *gb_usb_dev;
 	struct usb_hcd *hcd;
 	int retval;
+	u16 tmp;

drivers/staging/greybus/usb.c static int gb_usb_probe(struct gbphy_device *gbphy_dev, · line 173

Quoted 10 lines
drivers/staging/greybus/usb.c +2 -3
 
 	hcd = usb_create_hcd(&usb_gb_hc_driver, dev, dev_name(dev));
 	if (!hcd)
 		return -ENOMEM;
 
-	connection = gb_connection_create(gbphy_dev->bundle,
-					  le16_to_cpu(gbphy_dev->cport_desc->id),
-					  NULL);
+	tmp = le16_to_cpu(gbphy_dev->cport_desc->id);
+	connection = gb_connection_create(gbphy_dev->bundle, tmp, NULL);

"tmp" is the wrong name... :/

Like Joe said, it's doesn't help readability to introduce one time use temporary variables just to make the line lengths shorter. This line is 81 characters. It's fine. Just leave the original as is.

regards,
dan carpenter