Skip to contentSkip to conversation

build: Check if explicit_bzero is missing

PATCH In review Brian Gix 1 participant 2 messages Apr 1, 2019 – Apr 3, 2019 Bluetooth drivers

lore
Share & tools
lore

Brian Gix

author
#0 lore raw

PATCH v2 1/1 build: Check if explicit_bzero is missing

This check gets around the redefinition of explicit_bzero in ELL

In file included from ell/random.c:34:0:
ell/missing.h:59:20: error: static declaration of ‘explicit_bzero’ follows non-static declaration
static inline void explicit_bzero(void *s, size_t n)

                    ^~~~~~~~~~~~~~
In file included from ./ell/util.h:26:0,
                 from ell/private.h:26,
                 from ell/random.c:33:
/usr/include/string.h:435:13: note: previous declaration of ‘explicit_bzero’ was here
 extern void explicit_bzero (void *__s, size_t __n) __THROW __nonnull ((1));
             ^~~~~~~~~~~~~~
---
 configure.ac | 2 ++
 1 file changed, 2 insertions(+)
configure.ac +2 -0
index ae64ddc0f..0afe1e6db 100644
@@ -46,6 +46,8 @@ MISC_FLAGS
 AC_ARG_ENABLE(threads, AC_HELP_STRING([--enable-threads],
 		[enable threading support]), [enable_threads=${enableval}])
 
+AC_CHECK_FUNCS(explicit_bzero)
+
 AC_CHECK_FUNC(signalfd, dummy=yes,
 			AC_MSG_ERROR(signalfd support is required))
 
Signature · 1 line
2.14.5
author
#1 lore raw
Quoted 21 lines · Brian Gix

This check gets around the redefinition of explicit_bzero in ELL

In file included from ell/random.c:34:0:
ell/missing.h:59:20: error: static declaration of ‘explicit_bzero’ follows non-static declaration
static inline void explicit_bzero(void *s, size_t n)

                    ^~~~~~~~~~~~~~
In file included from ./ell/util.h:26:0,
                 from ell/private.h:26,
                 from ell/random.c:33:
/usr/include/string.h:435:13: note: previous declaration of ‘explicit_bzero’ was here
 extern void explicit_bzero (void *__s, size_t __n) __THROW __nonnull ((1));
             ^~~~~~~~~~~~~~
---
 configure.ac | 2 ++
 1 file changed, 2 insertions(+)
configure.ac +0 -0
index ae64ddc0f..0afe1e6db 100644

configure.ac MISC_FLAGS · line 53

Quoted 8 lines
configure.ac +2 -0
@@ -46,6 +46,8 @@ MISC_FLAGS
 AC_ARG_ENABLE(threads, AC_HELP_STRING([--enable-threads],
 		[enable threading support]), [enable_threads=${enableval}])
 
+AC_CHECK_FUNCS(explicit_bzero)
+
 AC_CHECK_FUNC(signalfd, dummy=yes,
 			AC_MSG_ERROR(signalfd support is required))
 

Patch Applied