regulator: lm363x: Use proper data type for regmap_read arguments
PATCH 1/2 regulator: lm363x: Use proper data type for regmap_read arguments
regmap_read() takes unsigned int reg and unsigned int *val arguments, use proper data type for these arguments.
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/lm363x-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/lm363x-regulator.c +2 -2
@@ -48,7 +48,7 @@ static const int ldo_cont_enable_time[] = {static int lm363x_regulator_enable_time (struct regulator_dev *rdev) {enum lm363x_regulator_id id =rdev_get_id (rdev); -u8 val, addr, mask; +unsigned int val, addr, mask;switch (id) {case LM3631_LDO_CONT :
@@ -71,7 +71,7 @@ static int lm363x_regulator_enable_time(struct regulator_dev *rdev)return 0 ; } -if (regmap_read (rdev->regmap, addr, (unsigned int *)&val)) +if (regmap_read (rdev->regmap, addr, &val))return -EINVAL ; val = (val & mask) >>LM3631_ENTIME_SHIFT ;
Signature · 1 line
2.17.1
PATCH 2/2 regulator: lm363x: Constify regulator_ops
The lm363x_boost_voltage_table_ops and lm363x_regulator_voltage_table_ops never need to be modified, make them const so compiler can put them to .rodata.
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/lm363x-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/lm363x-regulator.c +2 -2
@@ -82,13 +82,13 @@ static int lm363x_regulator_enable_time(struct regulator_dev *rdev)return ENABLE_TIME_USEC * val; } -static struct regulator_ops lm363x_boost_voltage_table_ops = { +static const struct regulator_ops lm363x_boost_voltage_table_ops = { .list_voltage = regulator_list_voltage_linear, .set_voltage_sel = regulator_set_voltage_sel_regmap, .get_voltage_sel = regulator_get_voltage_sel_regmap, }; -static struct regulator_ops lm363x_regulator_voltage_table_ops = { +static const struct regulator_ops lm363x_regulator_voltage_table_ops = { .list_voltage = regulator_list_voltage_linear, .set_voltage_sel = regulator_set_voltage_sel_regmap, .get_voltage_sel = regulator_get_voltage_sel_regmap,
Signature · 1 line
2.17.1