Staging: gasket: Use DIV_ROUND_UP
PATCH 1/1 Staging: gasket: Use DIV_ROUND_UP
Use DIV_ROUND_UP in-kernel function to make code simple and efficient.
Issue found using Coccinelle.
--- drivers/staging/gasket/gasket_page_table.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/gasket/gasket_page_table.c +2 -3
@@ -768,8 +768,7 @@ static bool gasket_is_extended_dev_addr_bad(struct gasket_page_table *pg_tbl, page_lvl0_idx =gasket_extended_lvl0_page_idx (pg_tbl, dev_addr);/* Get the count of affected level 0 pages. */ - num_lvl0_pages = (num_pages +GASKET_PAGES_PER_SUBTABLE -1 ) / -GASKET_PAGES_PER_SUBTABLE ; + num_lvl0_pages =DIV_ROUND_UP (num_pages,GASKET_PAGES_PER_SUBTABLE );if (gasket_components_to_dev_address (pg_tbl,0 , page_global_idx, page_offset) != dev_addr) {
@@ -1258,7 +1257,7 @@ int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, u64 size,dma_addr_t handle;void *mem;int j; -unsigned int num_pages = (size +PAGE_SIZE -1 ) /PAGE_SIZE ; +unsigned int num_pages =DIV_ROUND_UP (size,PAGE_SIZE );const struct gasket_driver_desc *driver_desc =gasket_get_driver_desc (gasket_dev);
Signature · 1 line
2.17.1
Quoted 1 line · Madhumitha Prabakaran
Use
DIV_ROUND_UPin-kernel function to make code simple and efficient.
I doubt that the code is more efficient. One could say that it is more understandable.
julia
Quoted 41 lines
Issue found using Coccinelle.
Signed-off-by Madhumitha Prabakaran <[email protected]>--- drivers/staging/gasket/gasket_page_table.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/gasket/gasket_page_table.c +2
-4@@ -768,8 +768,7 @@ static bool gasket_is_extended_dev_addr_bad(struct gasket_page_table *pg_tbl, page_lvl0_idx =gasket_extended_lvl0_page_idx (pg_tbl, dev_addr);/* Get the count of affected level 0 pages. */ - num_lvl0_pages = (num_pages +GASKET_PAGES_PER_SUBTABLE -1 ) / -GASKET_PAGES_PER_SUBTABLE ; + num_lvl0_pages =DIV_ROUND_UP (num_pages,GASKET_PAGES_PER_SUBTABLE );if (gasket_components_to_dev_address (pg_tbl,0 , page_global_idx, page_offset) != dev_addr) {@@ -1258,7 +1257,7 @@ int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, u64 size,dma_addr_t handle;void *mem;int j; -unsigned int num_pages = (size +PAGE_SIZE -1 ) /PAGE_SIZE ; +unsigned int num_pages =DIV_ROUND_UP (size,PAGE_SIZE );const struct gasket_driver_desc *driver_desc =gasket_get_driver_desc (gasket_dev); --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190402183717.10357-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.