bus/pci: fix TOCTOU issue
PATCH v2 1/1 bus/pci: fix TOCTOU issue
Using access followed by open causes a static analysis warning about Time of check versus Time of use. Also, access() and open() have different UID permission checks.
This is not a serious problem; but easy to fix by using errno instead.
Coverity issue: 300870
---
v2 - add more CC to original mail, and rebase
drivers/bus/pci/linux/pci_uio.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/bus/pci/linux/pci_uio.c +5 -6
@@ -314,12 +314,11 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx, loc->domain, loc->bus, loc->devid, loc->function, res_idx); -if (access (devname,R_OK |W_OK ) !=-1 ) { - fd =open (devname,O_RDWR ); -if (fd <0 ) -RTE_LOG (INFO ,EAL ,"%s cannot be mapped. " -"Fall-back to non prefetchable mode.\n" , - devname); + fd =open (devname,O_RDWR ); +if (fd <0 && errno !=ENOENT ) { +RTE_LOG (INFO ,EAL ,"%s cannot be mapped. " +"Fall-back to non prefetchable mode.\n" , + devname); } }
Signature · 1 line
2.17.1
Quoted 38 lines · Stephen Hemminger
Using access followed by open causes a static analysis warning about Time of check versus Time of use. Also,
access()andopen()have different UID permission checks.This is not a serious problem; but easy to fix by using errno instead.
Coverity issue: 300870
Fixes 4a928ef9f611 ("bus/pci: enable write combining during mapping")Signed-off-by Stephen Hemminger <[email protected]>---
v2 - add more CC to original mail, and rebasedrivers/bus/pci/linux/pci_uio.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)drivers/bus/pci/linux/pci_uio.c +5
-6@@ -314,12 +314,11 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx, loc->domain, loc->bus, loc->devid, loc->function, res_idx); -if (access (devname,R_OK |W_OK ) !=-1 ) { - fd =open (devname,O_RDWR ); -if (fd <0 ) -RTE_LOG (INFO ,EAL ,"%s cannot be mapped. " - "Fall-back to non prefetchable mode.\n", - devname); + fd =open (devname,O_RDWR ); +if (fd <0 && errno !=ENOENT ) { +RTE_LOG (INFO ,EAL ,"%s cannot be mapped. " +"Fall-back to non prefetchable mode.\n" , + devname); }
Quoted 3 lines
}
Signature · 1 line
David Marchand
Thomas Monjalon
Applied14/06/2019 16:16, David Marchand:
Quoted 11 lines
Quoted 8 lines · Stephen Hemminger
Using access followed by open causes a static analysis warning about Time of check versus Time of use. Also,
access()andopen()have different UID permission checks.This is not a serious problem; but easy to fix by using errno instead.
Coverity issue: 300870
Fixes 4a928ef9f611 ("bus/pci: enable write combining during mapping")
Quoted 3 lines
Quoted 2 lines
Signed-off-by Stephen Hemminger <[email protected]>Reviewed-by David Marchand <[email protected]>
Applied, thanks