Skip to contentSkip to conversation

ARM: dts: imx6q-logicpd: Enable Analog audio capture

PATCH Applied Adam Ford 2 participants 4 messages Apr 2, 2019 – Apr 11, 2019

Subsystems (2)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH v2 1/1 ARM: dts: imx6q-logicpd: Enable Analog audio capture

The original submission had functional audio out and was based on reviewing other boards using the same wm8962 codec. However, the Logic PD board uses an analog microphone which was being disabled for a digital mic. This patch corrects that and explicitly sets the gpio-cfg pins all to 0x0000 which allows the analog microphone to capture audio.

---
V2: Remove 'fixes' note reference Shawn's request.

arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi +2 -2
index e31b6923cb72..db6b5b900826 100644
@@ -248,9 +248,9 @@
 		gpio-cfg = <
 			0x0000 /* 0:Default */
 			0x0000 /* 1:Default */
-			0x0013 /* 2:FN_DMICCLK */
+			0x0000 /* 2:FN_DMICCLK */
 			0x0000 /* 3:Default */
-			0x8014 /* 4:FN_DMICCDAT */
+			0x0000 /* 4:FN_DMICCDAT */
 			0x0000 /* 5:Default */
 		>;
 	};
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v2 1/1 ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend

The LCD power sequencer is very finicky. The backlight cannot be driven until after the sequencer is done. Until now, the regulators were marked with 'regulator-always-on' to make sure it came up before the backlight. This patch allows the LCD regulators to power down and prevent the backlight from being used again until the sequencer is ready. This reduces standby power consumption by ~100mW.

---
V2: Remove 'fixes' reference per Shawn's request

arch/arm/boot/dts/imx6q-logicpd.dts +2 -2
index 45eb0b7f75f8..d96ae54be338 100644
@@ -21,6 +21,8 @@
 
 	panel-lvds0 {
 		compatible = "okaya,rs800480t-7x0gp";
+		power-supply = <&reg_lcd_reset>;
+		backlight = <&backlight>;
 
 		port {
 			panel_in_lvds0: endpoint {
@@ -38,7 +40,6 @@
 		regulator-max-microvolt = <3300000>;
 		gpio = <&gpio4 17 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
-		regulator-always-on;
 		vin-supply = <&reg_3v3>;
 		startup-delay-us = <500000>;
 	};
@@ -52,7 +53,6 @@
 		regulator-max-microvolt = <3300000>;
 		gpio = <&gpio5 2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
-		regulator-always-on;
 		vin-supply = <&reg_lcd>;
 	};
 };
Signature · 1 line
2.17.1
Applied
#2 lore raw

Re: [PATCH V2] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend

Quoted 9 lines · Adam Ford

The LCD power sequencer is very finicky. The backlight cannot be driven until after the sequencer is done. Until now, the regulators were marked with 'regulator-always-on' to make sure it came up before the backlight. This patch allows the LCD regulators to power down and prevent the backlight from being used again until the sequencer is ready. This reduces standby power consumption by ~100mW.

Applied, thanks.

Applied
#3 lore raw
In reply to Adam Ford
Quoted 8 lines · Adam Ford

The original submission had functional audio out and was based on reviewing other boards using the same wm8962 codec. However, the Logic PD board uses an analog microphone which was being disabled for a digital mic. This patch corrects that and explicitly sets the gpio-cfg pins all to 0x0000 which allows the analog microphone to capture audio.

Applied, thanks.